Skip to content

Fix review feedback for Oracle RETURNING INTO support#3762

Merged
radovanradic merged 3 commits intoradovanradic/oracle-returningfrom
copilot/sub-pr-3669
Mar 18, 2026
Merged

Fix review feedback for Oracle RETURNING INTO support#3762
radovanradic merged 3 commits intoradovanradic/oracle-returningfrom
copilot/sub-pr-3669

Conversation

Copy link
Contributor

Copilot AI commented Mar 18, 2026

  • Fix returningIdx computed on cleanLower but used as index into finalQueryString
  • Fix empty query string in QueryResult.of("") - now assembles SQL from queryParts
  • Fix JSON-entity branch missing unescapedColumns.add(identityName)
  • Emit both name and dataType members unconditionally in OUT parameter annotation
  • Add triggerPostLoad call for entity results in Oracle CallableStatement path
  • Fix inconsistent indentation in QueryResultOutParameterBinding record
  • Replace literal '?' with SqlQueryBuilder.DEFAULT_POSITIONAL_PARAMETER_MARKER constant and add clarifying comment

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Co-authored-by: radovanradic <10271067+radovanradic@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 18, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/xml/tools/xml-extractor.jar --fileList=/tmp/codeql-scratch-6a366402fabce74f/dbs/java/working/files-to-index10955522328101770956.list --sourceArchiveDir=/tmp/codeql-scratch-6a366402fabce74f/dbs/java/src --outputDir=/tmp/codeql-scratch-6a366402fabce74f/dbs/java/trap/java (dns block)
  • ge.micronaut.io
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=2000m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] [#2669] Support RETURNING INTO clause for INSERT/UPDATE/DELETE in Oracle database Fix review feedback for Oracle RETURNING INTO support Mar 18, 2026
Copilot AI requested a review from radovanradic March 18, 2026 16:01
@radovanradic radovanradic marked this pull request as ready for review March 18, 2026 16:14
…dSql comment

Co-authored-by: radovanradic <10271067+radovanradic@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 18, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • ge.micronaut.io
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=2000m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@radovanradic radovanradic merged commit 48ccd1e into radovanradic/oracle-returning Mar 18, 2026
1 check passed
@radovanradic radovanradic deleted the copilot/sub-pr-3669 branch March 18, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants