Skip to content

Added $ (dollar sign) escape for kotlin generator #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 6.18.x
Choose a base branch
from
Open

Added $ (dollar sign) escape for kotlin generator #2388

wants to merge 1 commit into from

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Oct 4, 2025

Fixed #2379

@altro3 altro3 added the type: bug Something isn't working label Oct 4, 2025
@altro3 altro3 mentioned this pull request Oct 4, 2025
Open
@altro3 altro3 requested review from graemerocher and sdelamo October 4, 2025 09:57
@graemerocher
Copy link
Contributor

there appear to be some failing tests on the target branch. It would be good if you could rebase this and correct the failures so we can get clean builds

@altro3
Copy link
Collaborator Author

altro3 commented Oct 4, 2025 •
edited
Loading

@graemerocher All tests passed. I ask about help early with this problem with Sonatype Auth several times:

{8AD49AF9-71D3-4491-9D20-003FC60FBAA5}

I also asked @sdelamo in discord, but he isn't available now. Please, repair sonatype. Now all PR's failed because of it

@graemerocher
Copy link
Contributor

the issue with sonatype auth was fixed in this commit 4efdff4#diff-0d634959c8276ae976e39ba475e63d0b9ec27824470c79f1971f58fe37c46325R64

but tests are still failing on CI

@altro3
Copy link
Collaborator Author

altro3 commented Oct 4, 2025

@graemerocher also, please, create a new release branch for all these PR's - 6.19.x

@altro3
Copy link
Collaborator Author

altro3 commented Oct 4, 2025

@graemerocher ok, let's try to rebuild this PR: this is fix for broken test, after micronaut-data was upgraded in main branch:

#2383

@altro3
Copy link
Collaborator Author

altro3 commented Oct 4, 2025

I rebased it now, will see

@altro3 altro3 changed the title Added $ (dollar sign) escape for kotlin Added $ (dollar sign) escape for kotlin generator Oct 7, 2025
@altro3 altro3 requested a review from graemerocher October 7, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo Awaiting requested review from sdelamo

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unescaped dollar signs in generated kotlin sources
2 participants
@altro3 @graemerocher