Fix compat tests due to esp-idf moving include files #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peripheral register definitions were moved to a new directory
inside the ESP-IDF: components/soc/{cpu_type}/register.
This change caused our compat tests to fail because they
depended on predefined register constants.
This commit resolves the issue by adding the new directory to
GCC's include search path using the -I option.
Additionally, all header files in this new directory are now
added to the DefinesDB for the compat tests with RTC macros.
Fixes micropython#100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peripheral register definitions were moved to a new directory inside the ESP-IDF: components/soc/{cpu_type}/register.
This change caused our compat tests to fail because they depended on predefined register constants.
This PR resolves the issue by adding the new directory to GCC's include search path using the -I option.
Additionally, all header files in this new directory are now added to the DefinesDB for the compat tests with RTC macros.
Fixes #101.