Skip to content

Add System.Text.Json support to AdaptiveCards .NET library #9191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 7 commits into
base: main
Choose a base branch
from

Complete System.Text.Json migration with documentation and Azure feed

e04eaaa
Select commit
Loading
Failed to load commit list.
Draft

Add System.Text.Json support to AdaptiveCards .NET library #9191

Complete System.Text.Json migration with documentation and Azure feed
e04eaaa
Select commit
Loading
Failed to load commit list.
Azure Pipelines / AdaptiveCards-.NET-PR failed Jun 19, 2025 in 6m 56s

Build #2506.19011 had test failures

3 errors / 3 warnings

Details

Tests

  • Failed: 98 (34.27%)
  • Passed: 187 (65.38%)
  • Other: 1 (0.35%)
  • Total: 286
Code coverage

  • 4362 of 12862 blocks covered (33.91%)
  • 18264 of 23501 lines covered (77.72%)

Annotations

Check failure on line 2163 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AdaptiveCards-.NET-PR

Build log #L2163 

Test Run Failed.

Check failure on line 2182 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AdaptiveCards-.NET-PR

Build log #L2182 

Error: The process 'C:\a\_tasks\VSTest_ef087383-ee5e-42c7-9a53-ab56c98420f9\2.248.3\Modules\DTAExecutionHost.exe' failed with exit code 1

Check failure on line 2183 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AdaptiveCards-.NET-PR

Build log #L2183 

Vstest failed with error. Check logs for failures. There might be failed tests.

Check failure on line 1 in AdaptiveCards.Test.SerializationTests.Media

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AdaptiveCards-.NET-PR

AdaptiveCards.Test.SerializationTests.Media 

Test method AdaptiveCards.Test.SerializationTests.Media threw exception: 
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
Raw output 
    at System.Collections.Generic.List`1.get_Item(Int32 index)
   at AdaptiveCards.Test.SerializationTests.Media() in \source\dotnet\Test\AdaptiveCards.Test\SerializationTests.cs:line 831
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in AdaptiveCards.Test.AdaptiveActionTests.TestActions_SerializationOfMode

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AdaptiveCards-.NET-PR

AdaptiveCards.Test.AdaptiveActionTests.TestActions_SerializationOfMode 

Assert.AreEqual failed. Expected:<{
  "type": "AdaptiveCard",
  "version": "1.5",
  "body": [
    {
      "text": "Hello World",
      "wrap": false,
      "maxLines": 0,
      "type": "TextBlock",
      "id": "textBlock",
      "separator": false,
      "isVisible": true
    },
    {
      "type": "Input.Text",
      "id": "textInput",
      "separator": false,
      "isVisible": true
    },
    {
      "type": "Container",
      "id": "container",
      "separator": false,
      "isVisible": true
    },
    {
      "type": "Input.ChoiceSet",
      "id": "choiceSetInput",
      "separator": false,
      "isVisible": true
    }
  ],
  "actions": [
    {
      "type": "Action.Submit",
      "id": "submitAction",
      "title": "Action.Submit"
    }
  ]
}>. Actual:<{
  "type": "AdaptiveCard",
  "version": "1.5",
  "actions": [
    {
      "type": "Action.Submit",
      "id": "submitAction",
      "title": "Action.Submit"
    }
  ]
}>.
Raw output 
   at AdaptiveCards.Test.AdaptiveActionTests.RoundTripTest(String expectedCard, String cardInTest) in \source\dotnet\Test\AdaptiveCards.Test\AdaptiveActionTests.cs:line 169
   at AdaptiveCards.Test.AdaptiveActionTests.TestActions_SerializationOfMode() in \source\dotnet\Test\AdaptiveCards.Test\AdaptiveActionTests.cs:line 285
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in AdaptiveCards.Test.AdaptiveCardApiTests.TestResourceInformation

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AdaptiveCards-.NET-PR

AdaptiveCards.Test.AdaptiveCardApiTests.TestResourceInformation 

CollectionAssert.AreEqual failed. (Different number of elements.)
Raw output 
   at AdaptiveCards.Test.AdaptiveCardApiTests.TestResourceInformation() in \source\dotnet\Test\AdaptiveCards.Test\AdaptiveCardApiTests.cs:line 240
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in AdaptiveCards.Test.SeparatorSpacingTests.TestSpacingAndSeparator

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AdaptiveCards-.NET-PR

AdaptiveCards.Test.SeparatorSpacingTests.TestSpacingAndSeparator 

Test method AdaptiveCards.Test.SeparatorSpacingTests.TestSpacingAndSeparator threw exception: 
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
Raw output 
    at System.Collections.Generic.List`1.get_Item(Int32 index)
   at AdaptiveCards.Test.SeparatorSpacingTests.TestSpacingAndSeparator() in \source\dotnet\Test\AdaptiveCards.Test\SeparatorSpacingTests.cs:line 14
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
View more details on Azure Pipelines