Integration testing framework #211

rodrigobr-msft · 2025-10-29T21:29:24Z

This pull request introduces a new integration testing framework for agent-based applications, adding core abstractions, client utilities, and environment setup. It establishes a modular structure for integration tests, including agent and response clients, application runners, and environment definitions. The changes also add requirements for new dependencies and set up import/export patterns for the new modules.

Key changes include:

Core abstractions and environment setup:

Added the Environment abstract base class to define the structure and initialization of integration test environments, supporting agent applications, storage, adapters, and connection management. (dev/integration/src/core/environment.py)
Introduced the ApplicationRunner abstract base class for managing the lifecycle (start/stop) of agent applications in integration tests, with support for asynchronous context management. (dev/integration/src/core/application_runner.py)

Client utilities:

Implemented AgentClient for sending authenticated activities to agent endpoints, including support for access token acquisition and handling both simple and expect-replies message flows. (dev/integration/src/core/client/agent_client.py)
Added ResponseClient to simulate a server receiving activities, supporting activity validation and response logic, with a stub for streamed activity handling. (dev/integration/src/core/client/response_client.py)
Added a Python version of BotResponse for simulating bot endpoints, including activity storage, streaming support, and a simple aiohttp-based web server. (dev/integration/src/core/client/bot_response.py)

Integration framework and utilities:

Created the integration decorator/factory, providing flexible integration test setup using service URLs, sample/environment classes, or aiohttp apps, and supporting response server hosting. (dev/integration/src/core/integration.py)
Added module-level exports in core/__init__.py and core/client/__init__.py for consistent import patterns. (dev/integration/src/core/__init__.py, dev/integration/src/core/client/__init__.py) [1] [2]

Dependency and environment configuration:

Added new dependencies (aioresponses, microsoft-agents-activity, microsoft-agents-hosting-core) to the integration environment and requirements. (dev/integration/env.TEMPLATE, dev/integration/requirements.txt) [1] [2]

These changes lay the groundwork for robust, modular, and reusable integration tests for agent-based systems.

dev/integration/src/core/client/bot_response.py

Copilot

Pull Request Overview

This PR introduces an integration testing framework for Microsoft Agents applications. It provides infrastructure for setting up and testing agent applications with support for multiple hosting environments (initially aiohttp), sample applications, and client interactions.

Key changes:

Integration testing framework with decorator-based test setup supporting service URLs, sample applications, or raw aiohttp apps
Client libraries for sending messages to agents (AgentClient) and receiving responses (ResponseClient)
Environment abstraction for hosting agents with an initial aiohttp implementation
Sample application structure with a quickstart example demonstrating basic agent functionality

Reviewed Changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated 28 comments.

Show a summary per file

File	Description
dev/integration/src/tests/test_quickstart.py	Adds integration test for quickstart sample functionality
dev/integration/src/samples/quickstart_sample.py	Implements a basic agent sample with greeting and echo handlers
dev/integration/src/samples/init.py	Exports QuickstartSample class
dev/integration/src/environments/aiohttp_environment.py	Provides aiohttp-based hosting environment for agents
dev/integration/src/environments/init.py	Exports AiohttpEnvironment class
dev/integration/src/core/sample.py	Defines abstract base class for sample applications
dev/integration/src/core/integration_fixtures.py	Provides pytest fixtures for integration testing
dev/integration/src/core/integration.py	Implements decorator for integration test setup with multiple strategies
dev/integration/src/core/environment.py	Defines abstract base class for hosting environments
dev/integration/src/core/client/response_client.py	Implements client for receiving and managing agent responses
dev/integration/src/core/client/bot_response.py	Provides alternative bot response server implementation
dev/integration/src/core/client/auto_client.py	Contains commented-out auto-client functionality
dev/integration/src/core/client/agent_client.py	Implements client for sending activities to agents
dev/integration/src/core/client/init.py	Exports client classes
dev/integration/src/core/application_runner.py	Provides base class for running applications in separate threads
dev/integration/src/core/init.py	Exports core integration testing components
dev/integration/requirements.txt	Adds aioresponses dependency
dev/integration/env.TEMPLATE	Template for environment configuration

Comments suppressed due to low confidence (1)

dev/integration/src/environments/aiohttp_environment.py:2

Import of 'E' is not used.

from tkinter import E

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-29T21:34:00Z

dev/integration/src/core/aiohttp/aiohttp_environment.py

@@ -0,0 +1,74 @@
+
+from tkinter import E


Unused import of 'E' from 'tkinter'. This appears to be a leftover import that should be removed as tkinter is not used in this file.

Suggested change

from tkinter import E

Copilot · 2025-10-29T21:34:01Z

dev/integration/src/core/client/response_client.py

+        self._prev_stdout = None
+        self._service_endpoint = service_endpoint
+        self._activities_list = []
+        self._activities_list_lock = []


The lock should be a Lock() instance, not an empty list. This will cause the with statement on line 53 to fail since lists don't support the context manager protocol. Change to self._activities_list_lock = Lock().

Suggested change

self._activities_list_lock = []

self._activities_list_lock = Lock()

Copilot · 2025-10-29T21:34:01Z

dev/integration/integration_tests/test_quickstart.py

+    async def test_quickstart_functionality(self, agent_client, response_client):
+        await agent_client.send("hi")
+        await asyncio.sleep(2)
+        response = (await response_client.pop())[0]


The ResponseClient class does not have a pop() method defined. This will cause an AttributeError at runtime.

Suggested change

response = (await response_client.pop())[0]

response = (await response_client.get())[0]

Copilot · 2025-10-29T21:34:01Z

dev/integration/src/core/integration.py

+            target_cls.setup_method = setup_method
+            target_cls.teardown_method = teardown_method
+
+            target_cls = Integration._with_response_server(target_cls, host_response)


Reference to Integration class should be _Integration as that's the actual class name defined on line 16.

Copilot · 2025-10-29T21:34:02Z

dev/integration/src/core/integration.py

+            def setup_method(self):
+                self._environment = environment_cls(sample_cls.get_config())
+                await self._environment.__aenter__()
+
+                self._sample = sample_cls(self._environment)
+                await self._sample.__aenter__()
+
+            def teardown_method(self):


Missing async keyword for setup_method. This function uses await so it must be defined as async def setup_method(self):.

Suggested change

def setup_method(self):

self._environment = environment_cls(sample_cls.get_config())

await self._environment.__aenter__()

self._sample = sample_cls(self._environment)

await self._sample.__aenter__()

def teardown_method(self):

async def setup_method(self):

self._environment = environment_cls(sample_cls.get_config())

await self._environment.__aenter__()

self._sample = sample_cls(self._environment)

await self._sample.__aenter__()

async def teardown_method(self):

Copilot · 2025-10-29T21:34:06Z

dev/integration/src/core/client/agent_client.py

+import os
+import json
+import asyncio
+from typing import Any, Optional, cast


Import of 'Any' is not used.

Suggested change

from typing import Any, Optional, cast

from typing import Optional, cast

Copilot · 2025-10-29T21:34:06Z

dev/integration/src/core/client/bot_response.py

+import asyncio
+import json
+import sys
+import threading


Import of 'threading' is not used.

Suggested change

import threading

Copilot · 2025-10-29T21:34:07Z

dev/integration/src/core/client/bot_response.py

+
+from aiohttp import web, ClientSession
+from aiohttp.web import Request, Response
+import aiohttp_security


Import of 'aiohttp_security' is not used.

Suggested change

import aiohttp_security

Copilot · 2025-10-29T21:34:07Z

dev/integration/src/core/integration.py

@@ -0,0 +1,151 @@
+from typing import Optional, TypeVar, Union, Callable, Any


Import of 'Union' is not used.

Suggested change

from typing import Optional, TypeVar, Union, Callable, Any

from typing import Optional, TypeVar, Callable, Any

Copilot · 2025-10-29T21:34:07Z

dev/integration/src/core/integration_fixtures.py

@@ -0,0 +1,38 @@
+from typing import TypeVar, Any, AsyncGenerator, Callable


Import of 'Any' is not used.
Import of 'TypeVar' is not used.

Suggested change

from typing import TypeVar, Any, AsyncGenerator, Callable

from typing import AsyncGenerator, Callable

Copilot

Pull Request Overview

Copilot reviewed 24 out of 29 changed files in this pull request and generated 17 comments.

Comments suppressed due to low confidence (5)

dev/integration/src/core/integration.py:72

Variable setup_method is not used.

            async def setup_method(self):

dev/integration/src/core/integration.py:79

Variable teardown_method is not used.

            async def teardown_method(self):

dev/integration/src/environments/aiohttp_environment.py:2

Import of 'E' is not used.

from tkinter import E

dev/integration/src/tests/core/client/test_agent_client.py:10

Keyword argument 'base_url' is not a supported parameter name of AgentClient.init.

        return AgentClient(base_url="")

dev/integration/src/tests/core/client/test_agent_client.py:16

Keyword argument 'base_url' is not a supported parameter name of AgentClient.init.

            client = AgentClient(base_url="https://example.com")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T22:25:44Z

dev/integration/src/tests/core/client/test_response_client.py

@@ -0,0 +1,19 @@
+from re import A


Unused import 'A' from the 're' module. This import should be removed as it serves no purpose.

Suggested change

from re import A

Copilot · 2025-10-30T22:25:45Z

dev/integration/src/core/integration.py

+            async def setup_method(self):
+                self._environment = environment_cls(sample_cls.get_config())
+                await self._environment.__aenter__()
+
+                self._sample = sample_cls(self._environment)
+                await self._sample.__aenter__()


Missing assignment of setup_method and teardown_method to target_cls. The decorated methods should be assigned like target_cls.setup_method = setup_method and target_cls.teardown_method = teardown_method before calling _with_response_client, similar to the from_service_url method.

Copilot · 2025-10-30T22:25:45Z

dev/integration/src/core/integration.py

+        def decorator(target_cls: T) -> T:
+
+            async def setup_method(self):
+                self._environment = environment_cls(sample_cls.get_config())


sample_cls.get_config() is an async method but is being called without await. This should be await sample_cls.get_config() to properly retrieve the configuration.

Suggested change

self._environment = environment_cls(sample_cls.get_config())

self._environment = environment_cls(await sample_cls.get_config())

Copilot · 2025-10-30T22:25:45Z

dev/integration/src/core/aiohttp/aiohttp_environment.py

+            authorization=self.authorization,
+            **self.agents_sdk_config


Reference to undefined attribute self.agents_sdk_config. This attribute is not defined in the init_env method or anywhere in the class. Either define this attribute or remove the unpacking.

Suggested change

authorization=self.authorization,

**self.agents_sdk_config

authorization=self.authorization

Copilot · 2025-10-30T22:25:45Z

dev/integration/src/core/application_runner.py

+    async def __aenter__(self) -> None:
+
+        if self._thread:
+            raise RuntimeError("Server is already running")
+
+        self._thread = Thread(target=self._start_server, daemon=True)
+        self._thread.start()
+


The __aenter__ method should return self (or the ApplicationRunner instance) to support the context manager protocol properly. Change return type to 'ApplicationRunner' and add return self at the end.

Suggested change

async def __aenter__(self) -> None:

if self._thread:

raise RuntimeError("Server is already running")

self._thread = Thread(target=self._start_server, daemon=True)

self._thread.start()

async def __aenter__(self) -> "ApplicationRunner":

if self._thread:

raise RuntimeError("Server is already running")

self._thread = Thread(target=self._start_server, daemon=True)

self._thread.start()

return self

Copilot · 2025-10-30T22:25:48Z

dev/integration/src/core/integration.py

+
+import aiohttp.web
+
+from .application_runner import ApplicationRunner


Import of 'ApplicationRunner' is not used.

Suggested change

from .application_runner import ApplicationRunner

Copilot · 2025-10-30T22:25:48Z

dev/integration/src/core/integration.py

+
+from .application_runner import ApplicationRunner
+from .environment import Environment
+from .client import AgentClient, ResponseClient


Import of 'AgentClient' is not used.

Suggested change

from .client import AgentClient, ResponseClient

from .client import ResponseClient

Copilot · 2025-10-30T22:25:48Z

dev/integration/src/tests/core/test_integration_from_sample.py

+    Sample
+)
+
+from ._common import SimpleRunner, OtherSimpleRunner


Import of 'OtherSimpleRunner' is not used.

Suggested change

from ._common import SimpleRunner, OtherSimpleRunner

from ._common import SimpleRunner

Copilot · 2025-10-30T22:25:49Z

dev/integration/src/tests/test_framework/core/test_integration_from_service_url.py

@@ -0,0 +1,7 @@
+import pytest


Import of 'pytest' is not used.

Suggested change

import pytest

Copilot · 2025-10-30T22:25:49Z

dev/integration/src/tests/core/test_integration_from_service_url.py

+from src.core import integration
+


Import of 'integration' is not used.

Suggested change

from src.core import integration

dev/integration/src/core/client/response_client.py

Copilot

Pull Request Overview

Copilot reviewed 24 out of 29 changed files in this pull request and generated 17 comments.

Comments suppressed due to low confidence (1)

dev/integration/src/environments/aiohttp_environment.py:2

Import of 'E' is not used.

from tkinter import E

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-31T00:13:08Z

dev/integration/src/core/aiohttp/aiohttp_environment.py

@@ -0,0 +1,74 @@
+
+from tkinter import E


Unused import E from the tkinter module should be removed. This import is not used anywhere in the code and tkinter is unrelated to the aiohttp environment implementation.

Suggested change

from tkinter import E

Copilot · 2025-10-31T00:13:08Z

dev/integration/src/tests/test_framework/core/test_application_runner.py

+        app = {}
+        runner = SimpleRunner(app)
+        async with runner as r:
+            sleep(0.1)


Using synchronous sleep() in an async test function blocks the event loop. Replace with await asyncio.sleep(0.1) to properly yield control in the async context.

Copilot · 2025-10-31T00:13:08Z

dev/integration/src/tests/test_framework/core/test_application_runner.py

+        app = {}
+        runner = SimpleRunner(app)
+        async with runner as r:
+            sleep(0.1)


Using synchronous sleep() in an async test function blocks the event loop. Replace with await asyncio.sleep(0.1) to properly yield control in the async context.

Copilot · 2025-10-31T00:13:09Z

dev/integration/src/tests/test_framework/core/test_application_runner.py

+        app = {}
+        runner = SimpleRunner(app)
+        async with runner as r:
+            sleep(0.1)


Using synchronous sleep() in an async test function blocks the event loop. Replace with await asyncio.sleep(0.1) to properly yield control in the async context.

Copilot · 2025-10-31T00:13:09Z

dev/integration/src/core/integration.py

+            async def setup_method(self):
+                self._environment = environment_cls(sample_cls.get_config())
+                await self._environment.__aenter__()
+
+                self._sample = sample_cls(self._environment)
+                await self._sample.__aenter__()


The sample_cls.get_config() is an async classmethod (as seen in sample.py), but it's being called without await. This should be await sample_cls.get_config() to properly retrieve the configuration.

Copilot · 2025-10-31T00:13:10Z

dev/integration/src/core/client/response_client.py

+import sys
+from io import StringIO
+from typing import Optional
+from threading import Lock


Import of 'Lock' is not used.

Copilot · 2025-10-31T00:13:11Z

dev/integration/src/tests/core/client/test_agent_client.py

+
+    @pytest.fixture
+    def agent_client(self) -> AgentClient:
+        return AgentClient(base_url="")


Keyword argument 'base_url' is not a supported parameter name of AgentClient.init.

Copilot · 2025-10-31T00:13:11Z

dev/integration/src/tests/core/client/test_agent_client.py

+        async def context_manager():
+            with aioresponses() as mocked:
+                mocked.get("https://example.com/service-url", payload={"serviceUrl": "https://service.example.com"})
+                client = AgentClient(base_url="https://example.com")


Keyword argument 'base_url' is not a supported parameter name of AgentClient.init.

Copilot · 2025-10-31T00:13:11Z

dev/integration/src/tests/core/client/test_response_client.py

+        return ResponseClient(base_url="")
+
+    @pytest.fixture
+    def service_url(self):
+        with aioresponses() as mocked:
+            mocked.get("https://example.com/service-url", payload={"serviceUrl": "https://service.example.com"})
+            client = ResponseClient(base_url="https://example.com")


Keyword argument 'base_url' is not a supported parameter name of ResponseClient.init.

Suggested change

return ResponseClient(base_url="")

@pytest.fixture

def service_url(self):

with aioresponses() as mocked:

mocked.get("https://example.com/service-url", payload={"serviceUrl": "https://service.example.com"})

client = ResponseClient(base_url="https://example.com")

return ResponseClient("")

@pytest.fixture

def service_url(self):

with aioresponses() as mocked:

mocked.get("https://example.com/service-url", payload={"serviceUrl": "https://service.example.com"})

client = ResponseClient("https://example.com")

Copilot · 2025-10-31T00:13:11Z

dev/integration/src/tests/core/client/test_response_client.py

+        return ResponseClient(base_url="")
+
+    @pytest.fixture
+    def service_url(self):
+        with aioresponses() as mocked:
+            mocked.get("https://example.com/service-url", payload={"serviceUrl": "https://service.example.com"})
+            client = ResponseClient(base_url="https://example.com")


Keyword argument 'base_url' is not a supported parameter name of ResponseClient.init.

Suggested change

return ResponseClient(base_url="")

@pytest.fixture

def service_url(self):

with aioresponses() as mocked:

mocked.get("https://example.com/service-url", payload={"serviceUrl": "https://service.example.com"})

client = ResponseClient(base_url="https://example.com")

return ResponseClient("")

@pytest.fixture

def service_url(self):

with aioresponses() as mocked:

mocked.get("https://example.com/service-url", payload={"serviceUrl": "https://service.example.com"})

client = ResponseClient("https://example.com")

Copilot

Pull Request Overview

Copilot reviewed 25 out of 30 changed files in this pull request and generated 10 comments.

Comments suppressed due to low confidence (1)

dev/integration/src/environments/aiohttp_environment.py:2

Import of 'E' is not used.

from tkinter import E

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-03T16:19:51Z

dev/integration/src/core/integration.py

+                self._service_url = service_url
+
+            async def teardown_method(self):
+                self._service_url = service_url


The teardown_method is redundantly reassigning the service_url that was already set in setup_method. This assignment serves no purpose in cleanup and should be removed.

Suggested change

self._service_url = service_url

pass

Copilot · 2025-11-03T16:19:52Z

dev/integration/src/core/integration_fixtures.py

+            yield response_client
+
+    @pytest.fixture
+    def create_response_client(self) -> Callable[None, ResponseClient]:


The type annotation Callable[None, ResponseClient] is incorrect. For a callable with no arguments, use Callable[[], ResponseClient] instead. None is not a valid argument specification.

Suggested change

def create_response_client(self) -> Callable[None, ResponseClient]:

def create_response_client(self) -> Callable[[], ResponseClient]:

Copilot · 2025-11-03T16:19:52Z

dev/integration/src/tests/test_framework/core/test_application_runner.py

+        app = {}
+        runner = OtherSimpleRunner(app)
+        async with runner as r:
+            sleep(0.1)


Using synchronous sleep() in an async test blocks the event loop. Replace with await asyncio.sleep(0.1) to properly yield control in async context.

Copilot · 2025-11-03T16:19:52Z

dev/integration/src/tests/test_framework/core/test_application_runner.py

+        app = {}
+        runner = SimpleRunner(app)
+        async with runner:
+            sleep(0.1)


Using synchronous sleep() in an async test blocks the event loop. Replace with await asyncio.sleep(0.1) to properly yield control in async context.

Copilot · 2025-11-03T16:19:52Z

dev/integration/src/core/client/response_client.py

+    async def _handle_conversation(self, request: Request) -> Response:
+        try:
+            body = await request.text()
+            activity = Activity.model_validate(body)


The body from request.text() is a string, but Activity.model_validate() expects a dict. This should be Activity.model_validate_json(body) or parse the JSON first with json.loads(body) then validate.

Copilot · 2025-11-03T16:19:53Z

dev/integration/src/core/client/agent_client.py

+            return cast(Activity, activity_or_text)
+
+    async def send_activity(self, activity_or_text: Activity | str, timeout: Optional[float] = None) -> str:
+        timeout = timeout or self._default_timeout


Variable timeout is not used.

Copilot · 2025-11-03T16:19:53Z

dev/integration/src/core/client/agent_client.py

+        return content
+
+    async def send_expect_replies(self, activity_or_text: Activity | str, timeout: Optional[float] = None) -> list[Activity]:
+        timeout = timeout or self._default_timeout


Variable timeout is not used.

Copilot · 2025-11-03T16:19:53Z

dev/integration/src/core/client/response_client.py

+            body = await request.text()
+            activity = Activity.model_validate(body)
+
+            conversation_id = activity.conversation.id if activity.conversation else None


Variable conversation_id is not used.

Suggested change

conversation_id = activity.conversation.id if activity.conversation else None

Copilot · 2025-11-03T16:19:54Z

dev/integration/src/tests/test_framework/core/client/test_agent_client.py

@@ -0,0 +1,65 @@
+import json
+from contextlib import contextmanager


Import of 'contextmanager' is not used.

Suggested change

from contextlib import contextmanager

Copilot · 2025-11-03T16:19:54Z

dev/integration/src/tests/test_framework/core/client/test_agent_client.py

+import re
+


Import of 're' is not used.

Suggested change

import re

Copilot

Pull Request Overview

Copilot reviewed 25 out of 30 changed files in this pull request and generated 13 comments.

Comments suppressed due to low confidence (2)

dev/integration/src/core/aiohttp/aiohttp_environment.py:2

Import of 'E' is not used.

from tkinter import E

dev/integration/src/core/aiohttp/aiohttp_environment.py:3

Import of 'run_app' is not used.

from aiohttp.web import Request, Response, Application, run_app

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-03T20:14:42Z

dev/integration/src/core/aiohttp/aiohttp_runner.py

@@ -0,0 +1,115 @@
+from typing import Optional
+from typing import Optional


Duplicate import statement for typing.Optional. Remove the duplicate on line 2.

Suggested change

from typing import Optional

Copilot · 2025-11-03T20:14:42Z

dev/integration/src/core/aiohttp/aiohttp_environment.py

+        APP["agent_app"] = self.agent_application
+        APP["adapter"] = self.adapter
+
+        return AiohttpRunner(APP)


Missing import for AiohttpRunner. The class is used but not imported. Add from .aiohttp_runner import AiohttpRunner to the imports.

Copilot · 2025-11-03T20:14:42Z

dev/integration/src/core/aiohttp/aiohttp_runner.py

+
+    async def __aenter__(self):
+        if self._server_thread:
+            raise RuntimeError("ResponseClient is already running.")


Error message references 'ResponseClient' but this is the AiohttpRunner class. The message should be 'AiohttpRunner is already running.' or 'Server is already running.'

Suggested change

raise RuntimeError("ResponseClient is already running.")

raise RuntimeError("AiohttpRunner is already running.")

Copilot · 2025-11-03T20:14:42Z

dev/integration/src/core/aiohttp/aiohttp_runner.py

+
+    async def _stop_server(self):
+        if not self._server_thread:
+            raise RuntimeError("ResponseClient is not running.")


Error message references 'ResponseClient' but this is the AiohttpRunner class. The message should be 'AiohttpRunner is not running.' or 'Server is not running.'

Copilot · 2025-11-03T20:14:43Z

dev/integration/src/core/aiohttp/aiohttp_runner.py

+
+    async def __aexit__(self, exc_type, exc, tb):
+        if not self._server_thread:
+            raise RuntimeError("ResponseClient is not running.")


Error message references 'ResponseClient' but this is the AiohttpRunner class. The message should be 'AiohttpRunner is not running.' or 'Server is not running.'

Copilot · 2025-11-03T20:14:44Z

dev/integration/src/core/aiohttp/aiohttp_environment.py

@@ -0,0 +1,59 @@
+
+from tkinter import E
+from aiohttp.web import Request, Response, Application, run_app


Unused import run_app. This import is not used in the file and should be removed.

Suggested change

from aiohttp.web import Request, Response, Application, run_app

from aiohttp.web import Request, Response, Application

Copilot · 2025-11-03T20:14:44Z

dev/integration/src/core/integration.py

@@ -0,0 +1,50 @@
+import pytest


Import of 'pytest' is not used.

Suggested change

import pytest

Copilot · 2025-11-03T20:14:44Z

dev/integration/src/core/integration.py

@@ -0,0 +1,50 @@
+import pytest
+from typing import Optional, TypeVar, Union, Callable, Any


Import of 'Any' is not used.
Import of 'Union' is not used.

Suggested change

from typing import Optional, TypeVar, Union, Callable, Any

from typing import Optional, TypeVar, Callable

Copilot · 2025-11-03T20:14:45Z

dev/integration/src/core/integration.py

+
+import aiohttp.web
+
+from .application_runner import ApplicationRunner


Import of 'ApplicationRunner' is not used.

Suggested change

from .application_runner import ApplicationRunner

Copilot · 2025-11-03T20:14:45Z

dev/integration/src/core/integration.py

+
+from .application_runner import ApplicationRunner
+from .environment import Environment
+from .client import AgentClient, ResponseClient


Import of 'AgentClient' is not used.
Import of 'ResponseClient' is not used.

Suggested change

from .client import AgentClient, ResponseClient

dev/integration/src/core/client/response_client.py

+                    await asyncio.sleep(0.1)  # Simulate processing delay
+                return Response(status=200, text="Activity received")
+        except Exception as e:
+            return Response(status=500, text=str(e))


To fix the problem, the detailed error message must not be returned to the external user. Instead, we should log the error server-side for developers/administrators and send a generic error message in the HTTP response.
The best way to do this in the provided snippet is:

Use the standard logging module to log the exception, including a stack trace, in the exception handler.

Return a generic message like "An internal server error occurred" in the Response, with status 500.

No changes are required except within the _handle_conversation method and adding a logging import at the top if not already present.

Copilot

Pull Request Overview

Copilot reviewed 25 out of 30 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (2)

dev/integration/src/core/aiohttp/aiohttp_environment.py:2

Import of 'E' is not used.

from aiohttp.web import Request, Response, Application, run_app

dev/integration/src/core/aiohttp/aiohttp_environment.py:3

Import of 'run_app' is not used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-03T20:57:54Z

dev/integration/src/core/aiohttp/aiohttp_runner.py

+        self._server_thread = Thread(
+            target=lambda: asyncio.run(self._start_server()), daemon=True
+        )
+        self._server_thread.start()


Error message refers to 'ResponseClient' but this is the AiohttpRunner class. Change the message to 'AiohttpRunner is already running.' or 'Server is already running.'

Copilot · 2025-11-03T20:57:54Z

dev/integration/src/core/aiohttp/aiohttp_runner.py

+
+        self._shutdown_event.clear()


Re-raising the exception without modification is unnecessary. Either remove the try-except block entirely or handle the exception meaningfully (e.g., logging, cleanup, or error transformation).

Copilot · 2025-11-03T20:57:54Z

dev/integration/integration_tests/test_quickstart.py

+from ..core import integration
+
+
+@integration(service_url="http://localhost:3978/api/messages")


The @integration decorator is called with 'service_url' as a parameter, but the IntegrationFixtures class expects 'messaging_endpoint' to be set. Based on the code in integration.py line 125, only 'messaging_endpoint' parameter is handled, not 'service_url'. This will likely cause the decorator to raise a ValueError.

Suggested change

@integration(service_url="http://localhost:3978/api/messages")

@integration(messaging_endpoint="http://localhost:3978/api/messages")

Copilot · 2025-11-03T20:57:55Z

dev/integration/src/core/client/agent_client.py

+        activity = self._to_activity(activity_or_text)
+        activity.delivery_mode = DeliveryModes.expect_replies
+
+        content = await self.send_request(activity)


Variable timeout is not used.

Copilot · 2025-11-03T20:57:55Z

dev/integration/src/tests/test_framework/core/test_integration_from_service_url.py

+        with aioresponses() as mocked:
+
+            def callback(url, **kwargs):
+                a = requests.post(


Variable a is not used.

Suggested change

a = requests.post(

requests.post(

Copilot · 2025-11-03T20:57:55Z

dev/integration/src/core/integration.py

+from typing import (
+    Optional,
+    TypeVar,
+    Union,
+    Callable,
+    Any,
+    AsyncGenerator,
+)


Import of 'Union' is not used.

Copilot · 2025-11-03T20:57:55Z

dev/integration/src/core/integration.py

+
+import aiohttp.web
+
+from .application_runner import ApplicationRunner


Import of 'ApplicationRunner' is not used.

Suggested change

from .application_runner import ApplicationRunner

Copilot · 2025-11-03T20:57:56Z

dev/integration/src/tests/test_framework/core/client/test_response_client.py

+        assert activities[0].type == "message"
+        assert activities[0].text == "Hello, World!"


This 'assert' statement contains an expression which may have side effects.

Suggested change

assert activities[0].type == "message"

assert activities[0].text == "Hello, World!"

activity = activities[0]

assert activity.type == "message"

assert activity.text == "Hello, World!"

Copilot

Pull Request Overview

Copilot reviewed 27 out of 33 changed files in this pull request and generated 16 comments.

Comments suppressed due to low confidence (8)

dev/integration/src/core/client/agent_client.py:1

Import of 'os' is not used.

import os

dev/integration/src/core/aiohttp/aiohttp_environment.py:2

Import of 'run_app' is not used.

from aiohttp.web import Request, Response, Application, run_app

dev/integration/src/core/integration.py:10

Import of 'Union' is not used.

from typing import (
    Optional,
    TypeVar,
    Union,
    Callable,
    Any,
    AsyncGenerator,
)

dev/integration/src/core/client/response_client.py:6

Import of 'Thread' is not used.
Import of 'Event' is not used.

from threading import Lock, Thread, Event

dev/integration/src/tests/test_framework/core/client/test_agent_client.py:2

Import of 'contextmanager' is not used.

from contextlib import contextmanager

dev/integration/src/tests/test_framework/core/client/test_agent_client.py:3

Import of 're' is not used.

import re

dev/integration/src/tests/test_framework/core/test_integration_from_service_url.py:4

Import of 'copy' is not used.
dev/integration/src/tests/test_quickstart.py:2
Import of 'asyncio' is not used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-03T21:28:05Z

dev/integration/src/tests/integration/test_quickstart.py

@@ -0,0 +1,12 @@
+import pytest
+import asyncio


The 'asyncio' module is imported but not used in this file. Remove this unused import.

Copilot · 2025-11-03T21:28:06Z

dev/integration/src/tests/test_framework/core/test_integration_from_service_url.py

+import pytest
+import asyncio
+import requests
+from copy import copy


The 'copy' function is imported but not used in this file. Remove this unused import.

Copilot · 2025-11-03T21:28:06Z

dev/integration/env.TEMPLATE

+aioresponses
+microsoft-agents-activity
+microsoft-agents-hosting-core


This file appears to be misnamed or incorrectly formatted. Based on the naming pattern 'env.TEMPLATE' and comparison with 'dev/integration/src/tests/env.TEMPLATE', this should likely contain environment variable templates (e.g., KEY=value format) rather than package names. The content looks like it belongs in a requirements file instead.

Suggested change

aioresponses

microsoft-agents-activity

microsoft-agents-hosting-core

# Example environment variable template

# Copy this file to .env and fill in the values as needed

API_KEY=

DATABASE_URL=

DEBUG=false

Copilot · 2025-11-03T21:28:06Z

dev/integration/src/core/environment.py

+    def create_runner(self) -> ApplicationRunner:
+        """Create an application runner for the environment."""


The abstract method signature for 'create_runner' in the base class returns 'ApplicationRunner' without parameters, but the concrete implementation in 'AiohttpEnvironment' requires 'host' and 'port' parameters. This creates an inconsistent interface. Consider adding these parameters to the base class signature or using a configuration object.

Suggested change

def create_runner(self) -> ApplicationRunner:

"""Create an application runner for the environment."""

def create_runner(self, host: str, port: int) -> ApplicationRunner:

"""Create an application runner for the environment.

Args:

host (str): The host address to bind the runner.

port (int): The port number to bind the runner.

"""

Copilot · 2025-11-03T21:28:07Z

dev/integration/src/core/client/agent_client.py

@@ -0,0 +1,130 @@
+import os


The 'os' module is imported but not used anywhere in this file. Remove this unused import.

Suggested change

import os

Copilot · 2025-11-03T21:28:09Z

dev/integration/src/tests/test_framework/core/test_integration_from_service_url.py

+        with aioresponses() as mocked:
+
+            def callback(url, **kwargs):
+                a = requests.post(


Variable a is not used.

Copilot · 2025-11-03T21:28:10Z

dev/integration/src/core/aiohttp/aiohttp_environment.py

+            **self.config
+        )
+
+    def create_runner(self, host: str, port: int) -> ApplicationRunner:


This method requires 3 positional arguments, whereas overridden Environment.create_runner requires 1.

Copilot · 2025-11-03T21:28:10Z

dev/integration/src/core/aiohttp/aiohttp_environment.py

@@ -0,0 +1,58 @@
+from tkinter import E


Import of 'E' is not used.

Suggested change

from tkinter import E

Copilot · 2025-11-03T21:28:10Z

dev/integration/src/core/integration.py

+
+import aiohttp.web
+
+from .application_runner import ApplicationRunner


Import of 'ApplicationRunner' is not used.

Suggested change

from .application_runner import ApplicationRunner

Copilot · 2025-11-03T21:28:10Z

dev/integration/src/tests/test_framework/core/client/test_response_client.py

+        assert activities[0].type == "message"
+        assert activities[0].text == "Hello, World!"
+
+        assert (await response_client.pop()) == []


This 'assert' statement contains an expression which may have side effects.

Suggested change

assert (await response_client.pop()) == []

popped_activities = await response_client.pop()

assert popped_activities == []

Copilot

Pull Request Overview

Copilot reviewed 27 out of 33 changed files in this pull request and generated 9 comments.

Comments suppressed due to low confidence (1)

dev/integration/src/core/aiohttp/aiohttp_environment.py:1

Import of 'E' is not used.

from tkinter import E

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T16:34:09Z

dev/integration/src/tests/manual_test.py

+import pytest
+import asyncio
+
+from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment


Duplicate import of AiohttpEnvironment. Remove the duplicate occurrence from the import statement.

Suggested change

from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment

from src.core import integration, IntegrationFixtures, AiohttpEnvironment

Copilot · 2025-11-04T16:34:10Z

dev/integration/src/core/aiohttp/aiohttp_runner.py

+
+    async def _stop_server(self):
+        if not self._server_thread:
+            raise RuntimeError("ResponseClient is not running.")


Error message refers to 'ResponseClient' but this is the AiohttpRunner class. The message should say 'AiohttpRunner is not running.' or 'Server is not running.'

Copilot · 2025-11-04T16:34:10Z

dev/integration/src/core/client/response_client.py

+            conversation_id = (
+                activity.conversation.id if activity.conversation else None
+            )


Variable conversation_id is not used.

Suggested change

conversation_id = (

activity.conversation.id if activity.conversation else None

)

# Removed unused variable 'conversation_id'

Copilot · 2025-11-04T16:34:10Z

dev/integration/src/core/integration.py

+from typing import (
+    Optional,
+    TypeVar,
+    Union,
+    Callable,
+    Any,
+    AsyncGenerator,
+)


Import of 'Union' is not used.

Copilot · 2025-11-04T16:34:11Z

dev/integration/src/core/integration.py

+import aiohttp.web
+from dotenv import load_dotenv
+
+from .application_runner import ApplicationRunner


Import of 'ApplicationRunner' is not used.

Suggested change

from .application_runner import ApplicationRunner

Copilot · 2025-11-04T16:34:11Z

dev/integration/src/tests/manual_test.py

@@ -0,0 +1,22 @@
+import pytest


Import of 'pytest' is not used.

Suggested change

import pytest

Copilot · 2025-11-04T16:34:11Z

dev/integration/src/tests/manual_test.py

+import pytest
+import asyncio
+
+from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment


Import of 'integration' is not used.
Import of 'IntegrationFixtures' is not used.

Suggested change

from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment

from src.core import AiohttpEnvironment, AiohttpEnvironment

Copilot · 2025-11-04T16:34:12Z

dev/integration/src/tests/test_framework/core/test_integration_from_service_url.py

+import pytest
+import asyncio
+import requests
+from copy import copy


Import of 'copy' is not used.

Copilot · 2025-11-04T16:34:12Z

dev/integration/src/tests/integration/test_quickstart.py

@@ -0,0 +1,12 @@
+import pytest
+import asyncio


Import of 'asyncio' is not used.

Copilot

Pull Request Overview

Copilot reviewed 26 out of 31 changed files in this pull request and generated 9 comments.

Comments suppressed due to low confidence (1)

dev/integration/src/core/aiohttp/aiohttp_environment.py:1

Import of 'E' is not used.

from tkinter import E

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T19:46:28Z

dev/integration/src/core/client/agent_client.py

+            json=activity.model_dump(by_alias=True, exclude_unset=True, exclude_none=True, mode="json"),
+        ) as response:
+            content = await response.text()
+            breakpoint()


A breakpoint() statement is left in the production code. This should be removed before merging as it will halt execution in production environments.

Suggested change

breakpoint()

Copilot · 2025-11-04T19:46:28Z

dev/integration/src/tests/manual_test.py

+import pytest
+import asyncio
+
+from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment, AgentClient


AiohttpEnvironment is imported twice. Remove the duplicate import.

Suggested change

from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment, AgentClient

from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AgentClient

Copilot · 2025-11-04T19:46:29Z

dev/integration/src/core/client/agent_client.py

+        timeout = timeout or self._default_timeout
+        activity = self._to_activity(activity_or_text)
+        activity.delivery_mode = DeliveryModes.expect_replies
+        activity.service_url = activity.service_url or "http://localhost" # temporary fix


Hardcoded fallback URL 'http://localhost' with a comment indicating this is a 'temporary fix'. Consider making this configurable or documenting why this default is necessary. If this is truly temporary, create a TODO or track it for proper resolution.

Copilot · 2025-11-04T19:46:29Z

dev/integration/src/core/client/agent_client.py

+    async def send_activity(
+        self, activity_or_text: Activity | str, sleep: float = 0, timeout: Optional[float] = None
+    ) -> str:
+        timeout = timeout or self._default_timeout


Variable timeout is not used.

Copilot · 2025-11-04T19:46:29Z

dev/integration/src/tests/manual_test.py

+        print(f"Server running at http://{host}:{port}/api/messages")
+        while True:
+
+            res = await client.send_expect_replies("Hello, Agent!")


Variable res is not used.

Suggested change

res = await client.send_expect_replies("Hello, Agent!")

await client.send_expect_replies("Hello, Agent!")

Copilot · 2025-11-04T19:46:29Z

dev/integration/src/core/aiohttp/aiohttp_environment.py

+            **self.config
+        )
+
+    def create_runner(self, host: str, port: int) -> ApplicationRunner:


This method requires 3 positional arguments, whereas overridden Environment.create_runner requires 1.

Suggested change

def create_runner(self, host: str, port: int) -> ApplicationRunner:

def create_runner(self, runner_config: dict) -> ApplicationRunner:

host = runner_config.get("host", "127.0.0.1")

port = runner_config.get("port", 8080)

Copilot · 2025-11-04T19:46:30Z

dev/integration/src/tests/manual_test.py

@@ -0,0 +1,48 @@
+import os
+import pytest


Import of 'pytest' is not used.

Suggested change

import pytest

Copilot · 2025-11-04T19:46:30Z

dev/integration/src/tests/manual_test.py

+import pytest
+import asyncio
+
+from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment, AgentClient


Import of 'integration' is not used.
Import of 'IntegrationFixtures' is not used.

Suggested change

from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment, AgentClient

from src.core import AiohttpEnvironment, AiohttpEnvironment, AgentClient

Copilot · 2025-11-04T19:46:30Z

dev/integration/src/tests/test_framework/core/test_integration_from_service_url.py

+import pytest
+import asyncio
+import requests
+from copy import copy


Import of 'copy' is not used.

Suggested change

from copy import copy

Copilot

Pull Request Overview

Copilot reviewed 29 out of 36 changed files in this pull request and generated 14 comments.

Comments suppressed due to low confidence (1)

dev/integration/src/tests/manual_test.py:2

Import of 'pytest' is not used.

import pytest

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T22:41:25Z

dev/integration/src/core/aiohttp/aiohttp_runner.py

+
+    async def __aenter__(self):
+        if self._server_thread:
+            raise RuntimeError("ResponseClient is already running.")


Error message mentions 'ResponseClient' but this is the AiohttpRunner class. The message should say 'AiohttpRunner is already running.' or 'Server is already running.'

Suggested change

raise RuntimeError("ResponseClient is already running.")

raise RuntimeError("Server is already running.")

Copilot · 2025-11-04T22:41:26Z

dev/integration/src/tests/manual_test.py

@@ -0,0 +1,41 @@
+import os
+import pytest


Unused import. The pytest module is imported but never used in this file.

Suggested change

import pytest

Copilot · 2025-11-04T22:41:26Z

dev/integration/src/tests/integration/foundational/test_suite.py

+@integration()
+class TestFoundation(IntegrationFixtures):
+
+    def load_activity(self, activity_name) -> Activity:


Missing import for return type annotation. The method uses Activity as a return type but it's not imported in this file. Add Activity to the imports from microsoft_agents.activity.

Copilot · 2025-11-04T22:41:26Z

dev/integration/src/tests/integration/foundational/test_suite.py

+        assert result is not None
+        last = result[-1]
+        assert last.type == ActivityTypes.message
+        assert last.text.lower() == "you said: {activity.text}".lower()


String formatting issue. The assertion uses a literal string {activity.text} instead of an f-string. Change to f\"you said: {activity.text}\" to properly interpolate the activity.text variable.

Suggested change

assert last.text.lower() == "you said: {activity.text}".lower()

assert last.text.lower() == f"you said: {activity.text}".lower()

Copilot · 2025-11-04T22:41:27Z

dev/integration/src/tests/integration/foundational/_common.py

+
+def load_activity(channel: str, name: str) -> Activity:
+
+    with open("./dev/integration/src/tests/integration/foundational/activities/{}/{}.json".format(channel, name), "r") as f:


[nitpick] Use f-string for better readability. Replace .format(channel, name) with an f-string: f\"./dev/integration/src/tests/integration/foundational/activities/{channel}/{name}.json\".

Suggested change

with open("./dev/integration/src/tests/integration/foundational/activities/{}/{}.json".format(channel, name), "r") as f:

with open(f"./dev/integration/src/tests/integration/foundational/activities/{channel}/{name}.json", "r") as f:

Copilot · 2025-11-04T22:41:28Z

dev/integration/src/tests/integration/foundational/test_suite.py

+import asyncio
+


Import of 'asyncio' is not used.

Suggested change

import asyncio

Copilot · 2025-11-04T22:41:29Z

dev/integration/src/tests/integration/foundational/test_suite.py

+    ActivityTypes,
+)
+
+from src.core import integration, IntegrationFixtures, AiohttpEnvironment


Import of 'AiohttpEnvironment' is not used.

Suggested change

from src.core import integration, IntegrationFixtures, AiohttpEnvironment

from src.core import integration, IntegrationFixtures

Copilot · 2025-11-04T22:41:29Z

dev/integration/src/tests/integration/foundational/test_suite.py

+)
+
+from src.core import integration, IntegrationFixtures, AiohttpEnvironment
+from src.samples import QuickstartSample


Import of 'QuickstartSample' is not used.

Suggested change

from src.samples import QuickstartSample

Copilot · 2025-11-04T22:41:29Z

dev/integration/src/core/utils.py

+from microsoft_agents.activity import (
+    Activity,
+    ActivityTypes,
+    DeliveryModes,
+    ConversationAccount,
+    ChannelAccount,
+)


Import of 'ActivityTypes' is not used.

Copilot · 2025-11-04T22:41:29Z

dev/integration/src/tests/test_framework/core/client/test_response_client.py

+        assert activities[0].type == "message"
+        assert activities[0].text == "Hello, World!"
+
+        assert (await response_client.pop()) == []


This 'assert' statement contains an expression which may have side effects.

Copilot

Pull Request Overview

Copilot reviewed 30 out of 38 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

dev/integration/src/core/aiohttp/aiohttp_environment.py:1

Import of 'E' is not used.

from tkinter import E

dev/integration/src/tests/manual_test.py:2

Import of 'pytest' is not used.

import pytest

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T22:59:56Z

dev/integration/src/tests/integration/foundational/_common.py

+from microsoft_agents.activity import Activity
+
+def load_activity(channel: str, name: str) -> Activity:
+
+    with open("./dev/integration/src/tests/integration/foundational/activities/{}/{}.json".format(channel, name), "r") as f:


Hardcoded relative path may fail depending on execution context. Consider using pathlib.Path(__file__).parent to construct a path relative to the current file, or use os.path.join() with a base directory constant to make the path more robust.

Suggested change

from microsoft_agents.activity import Activity

def load_activity(channel: str, name: str) -> Activity:

with open("./dev/integration/src/tests/integration/foundational/activities/{}/{}.json".format(channel, name), "r") as f:

from pathlib import Path

from microsoft_agents.activity import Activity

def load_activity(channel: str, name: str) -> Activity:

activity_path = Path(__file__).parent / "activities" / channel / f"{name}.json"

with open(activity_path, "r") as f:

rodrigobr-msft added 12 commits October 21, 2025 14:16

basic integration utility

cfb8847

Integration test suite factory implementation

4d93a46

Implementing core models for integration testing

be2fb1c

AutoClient mockup

0d5539a

Adding runner starter code

bf4c006

Adding foundational classes

ebe622d

Drafting AgentClient and ResponseClient implementations

45678e9

Spec test

c2b84cb

Filling in more implementation details

2816e68

More files

2214827

Cleaning up implementations

c90c8e4

Adding expect replies sending method

36f5c3b

Copilot AI review requested due to automatic review settings October 29, 2025 21:29

github-advanced-security bot found potential problems Oct 29, 2025

View reviewed changes

dev/integration/src/core/client/bot_response.py Fixed Show fixed Hide fixed

Copilot AI reviewed Oct 29, 2025

View reviewed changes

rodrigobr-msft added 2 commits October 30, 2025 15:04

Beginning unit tests

dfdd959

Adding integration decor from sample test cases

d4828fb

Copilot AI review requested due to automatic review settings October 30, 2025 22:20

Copilot AI reviewed Oct 30, 2025

View reviewed changes

rodrigobr-msft added 2 commits October 30, 2025 17:04

Integration from service url tests

91b3c44

_handle_conversation implementation for response_client

1eefe44

Copilot AI review requested due to automatic review settings October 31, 2025 00:07

github-advanced-security bot found potential problems Oct 31, 2025

View reviewed changes

dev/integration/src/core/client/response_client.py Fixed Show fixed Hide fixed

Copilot AI reviewed Oct 31, 2025

View reviewed changes

rodrigobr-msft added 2 commits October 31, 2025 15:12

AgentClient tests completed

a06da9a

Creating response client tests

d36ec7a

Copilot AI review requested due to automatic review settings November 3, 2025 16:14

Copilot AI reviewed Nov 3, 2025

View reviewed changes

rodrigobr-msft added 2 commits November 3, 2025 08:51

Hosting server for response client

c096048

Response client tests completed

5451ddf

Copilot AI review requested due to automatic review settings November 3, 2025 20:10

Another commit

dd0a87d

Copilot AI reviewed Nov 3, 2025

View reviewed changes

rodrigobr-msft added 2 commits November 3, 2025 12:25

Reorganizing files

6a4e8ef

Completed TestIntegrationFromServiceUrl unit tests

7793790

Copilot AI review requested due to automatic review settings November 3, 2025 20:53

Reformatting with black

3ebbd44

github-advanced-security bot found potential problems Nov 3, 2025

View reviewed changes

Copilot AI reviewed Nov 3, 2025

View reviewed changes

rodrigobr-msft added 2 commits November 3, 2025 12:59

Quickstart integration test beginning

a6681bf

Draft of quickstart sample setup

1a7264b

Copilot AI review requested due to automatic review settings November 3, 2025 21:23

Copilot AI reviewed Nov 3, 2025

View reviewed changes

rodrigobr-msft added 2 commits November 3, 2025 13:44

Environment config connection

9ba4a43

Renaming messaging endpoint to agent url

fab4368

Copilot AI review requested due to automatic review settings November 4, 2025 16:29

Copilot AI reviewed Nov 4, 2025

View reviewed changes

rodrigobr-msft added 2 commits November 4, 2025 10:39

Removing unnecessary files

a111155

Fixing agent client payload sending

a2a1092

Copilot AI review requested due to automatic review settings November 4, 2025 19:41

Copilot AI reviewed Nov 4, 2025

View reviewed changes

rodrigobr-msft added 2 commits November 4, 2025 13:34

First successful integration test

ae8a286

Beginning foundational test cases

9a5a6a8

Copilot AI review requested due to automatic review settings November 4, 2025 22:36

Copilot AI reviewed Nov 4, 2025

View reviewed changes

rodrigobr-msft added 2 commits November 4, 2025 14:42

TypingIndicator test

aad011a

Adding more test cases

be0032a

Copilot AI review requested due to automatic review settings November 4, 2025 22:55

Copilot AI reviewed Nov 4, 2025

View reviewed changes

More foundational integration test cases

e3f4324

	self._activities_list_lock = []
	self._activities_list_lock = Lock()

	response = (await response_client.pop())[0]
	response = (await response_client.get())[0]

	from typing import Any, Optional, cast
	from typing import Optional, cast

		@@ -0,0 +1,151 @@
		from typing import Optional, TypeVar, Union, Callable, Any

	from typing import Optional, TypeVar, Union, Callable, Any
	from typing import Optional, TypeVar, Callable, Any

		@@ -0,0 +1,38 @@
		from typing import TypeVar, Any, AsyncGenerator, Callable

	from typing import TypeVar, Any, AsyncGenerator, Callable
	from typing import AsyncGenerator, Callable

	self._environment = environment_cls(sample_cls.get_config())
	self._environment = environment_cls(await sample_cls.get_config())

	authorization=self.authorization,
	**self.agents_sdk_config
	authorization=self.authorization


		import aiohttp.web

		from .application_runner import ApplicationRunner

	from .client import AgentClient, ResponseClient
	from .client import ResponseClient

	from ._common import SimpleRunner, OtherSimpleRunner
	from ._common import SimpleRunner

	def create_response_client(self) -> Callable[None, ResponseClient]:
	def create_response_client(self) -> Callable[[], ResponseClient]:

		@@ -0,0 +1,65 @@
		import json
		from contextlib import contextmanager

		@@ -0,0 +1,115 @@
		from typing import Optional
		from typing import Optional

	raise RuntimeError("ResponseClient is already running.")
	raise RuntimeError("AiohttpRunner is already running.")

		@@ -0,0 +1,59 @@

		from tkinter import E
		from aiohttp.web import Request, Response, Application, run_app

		@@ -0,0 +1,50 @@
		import pytest
		from typing import Optional, TypeVar, Union, Callable, Any

		from ..core import integration


		@integration(service_url="http://localhost:3978/api/messages")

	@integration(service_url="http://localhost:3978/api/messages")
	@integration(messaging_endpoint="http://localhost:3978/api/messages")

Integration testing framework #211

Are you sure you want to change the base?

Integration testing framework #211

Conversation

rodrigobr-msft commented Oct 29, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

		assert activities[0].type == "message"
		assert activities[0].text == "Hello, World!"

-        assert activities[0].type == "message"
-        assert activities[0].text == "Hello, World!"
+        activity = activities[0]
+        assert activity.type == "message"
+        assert activity.text == "Hello, World!"

-aioresponses
-microsoft-agents-activity
-microsoft-agents-hosting-core
+# Example environment variable template
+# Copy this file to .env and fill in the values as needed
+API_KEY=
+DATABASE_URL=
+DEBUG=false

		def create_runner(self) -> ApplicationRunner:
		"""Create an application runner for the environment."""

	assert (await response_client.pop()) == []
	popped_activities = await response_client.pop()
	assert popped_activities == []

	from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment
	from src.core import integration, IntegrationFixtures, AiohttpEnvironment

	from src.core import integration, IntegrationFixtures, AiohttpEnvironment, AiohttpEnvironment
	from src.core import AiohttpEnvironment, AiohttpEnvironment

	res = await client.send_expect_replies("Hello, Agent!")
	await client.send_expect_replies("Hello, Agent!")

-    def create_runner(self, host: str, port: int) -> ApplicationRunner:
+    def create_runner(self, runner_config: dict) -> ApplicationRunner:
+        host = runner_config.get("host", "127.0.0.1")
+        port = runner_config.get("port", 8080)

	raise RuntimeError("ResponseClient is already running.")
	raise RuntimeError("Server is already running.")