comment explaining test assertion

Author: trask

smoke-tests/apps/SamplingOverrides/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/SamplingOverrides3Test.java

@@ -51,24 +51,19 @@ void testSampling() throws Exception {
     testing
         .mockedIngestion
         .getItemsEnvelopeDataType("RequestData")
-        .forEach(
-            item -> {
-              assertThat(item.getSampleRate()).isEqualTo(10);
-            });
+        .forEach(item -> assertThat(item.getSampleRate()).isEqualTo(10));
     testing
         .mockedIngestion
         .getItemsEnvelopeDataType("RemoteDependencyData")
-        .forEach(
-            item -> {
-              assertThat(item.getSampleRate()).isEqualTo(10);
-            });
+        // even though the configured dependency sampling is 50%
+        // since that is less than 100%, it should not exceed its parent request sampling percentage
+        .forEach(item -> assertThat(item.getSampleRate()).isEqualTo(10));
     testing
         .mockedIngestion
         .getItemsEnvelopeDataType("MessageData")
-        .forEach(
-            item -> {
-              assertThat(item.getSampleRate()).isEqualTo(10);
-            });
+        // even though the configured log message sampling is 50%
+        // since that is less than 100%, it should not exceed its parent request sampling percentage
+        .forEach(item -> assertThat(item.getSampleRate()).isEqualTo(10));
   }
 
   @Environment(TOMCAT_8_JAVA_8)

smoke-tests/apps/SamplingOverrides/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/SamplingOverrides4Test.java

@@ -53,24 +53,15 @@ void testSampling() throws Exception {
     testing
         .mockedIngestion
         .getItemsEnvelopeDataType("RequestData")
-        .forEach(
-            item -> {
-              assertThat(item.getSampleRate()).isEqualTo(50);
-            });
+        .forEach(item -> assertThat(item.getSampleRate()).isEqualTo(50));
     testing
         .mockedIngestion
         .getItemsEnvelopeDataType("RemoteDependencyData")
-        .forEach(
-            item -> {
-              assertThat(item.getSampleRate()).isEqualTo(10);
-            });
+        .forEach(item -> assertThat(item.getSampleRate()).isEqualTo(10));
     testing
         .mockedIngestion
         .getItemsEnvelopeDataType("MessageData")
-        .forEach(
-            item -> {
-              assertThat(item.getSampleRate()).isEqualTo(10);
-            });
+        .forEach(item -> assertThat(item.getSampleRate()).isEqualTo(10));
   }
 
   @Environment(TOMCAT_8_JAVA_8)