Improve smoke tests around exceptions #3899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
exception-type-name-missing
branch
2 times, most recently
from
f196945 to
8e28cd8
Compare
trask
commented
Oct 9, 2024
Comment on lines
+26
to
+29
| @Scheduled(fixedRate = 100) | ||
| public void exceptional() { | ||
| throw new RuntimeException("exceptional"); | ||
| } |
Member
Author
There was a problem hiding this comment.
we were missing a non-Servlet test that captures an exception on a "request" telemetry
while Servlets do capture an exception in OTel, we suppress the exception if it is identical to the logged exception that is also captured (see #3555)
trask
force-pushed
the
exception-type-name-missing
branch
2 times, most recently
from
d46999e to
3826be6
Compare
trask
requested review from
harsimar,
heyams,
jeanbisutti and
ramthi
as code owners
trask
changed the title
Contributor
|
need to wait for the new exporter release. |
trask
force-pushed
the
exception-type-name-missing
branch
from
3826be6 to
a056a2c
Compare
Member
Author
|
smoke tests should pass once new azure sdk release is out and this repo is updated to use it |
heyams
approved these changes
Oct 9, 2024
trask
force-pushed
the
exception-type-name-missing
branch
from
a056a2c to
23b2b65
Compare
trask
force-pushed
the
exception-type-name-missing
branch
from
23b2b65 to
62110d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving smoke tests and testing the fix in Azure/azure-sdk-for-java#42241