Skip to content

Fix deserialization of enums in Alerting #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Fix deserialization of enums in Alerting #4125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f9d919
Fix deserialisation of enums in Alerting
johnoliver Mar 6, 2025
de0acbb
Fix formatting
johnoliver Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ...api/src/main/java/com/microsoft/applicationinsights/alerting/aiconfig/AlertingConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import com.azure.json.JsonToken;
import com.azure.json.JsonWriter;
import java.io.IOException;
import java.util.Locale;

public class AlertingConfig {

Expand Down Expand Up @@ -56,7 +57,8 @@ public static RequestFilter fromJson(JsonReader jsonReader) throws IOException {
reader.nextToken();
String fieldName = reader.getFieldName();
if ("type".equals(fieldName)) {
deserializedRequestFilter.setType(RequestFilterType.valueOf(reader.getString()));
deserializedRequestFilter.setType(
RequestFilterType.valueOf(reader.getString().toUpperCase(Locale.ROOT)));
} else if ("value".equals(fieldName)) {
deserializedRequestFilter.setValue(reader.getString());
} else {
Expand Down Expand Up @@ -184,7 +186,7 @@ public static RequestAggregation fromJson(JsonReader jsonReader) throws IOExcept
String fieldName = reader.getFieldName();
if ("type".equals(fieldName)) {
deserializedRequestAggregation.setType(
RequestAggregationType.valueOf(reader.getString()));
RequestAggregationType.valueOf(reader.getString().toUpperCase(Locale.ROOT)));
} else if ("windowSizeMillis".equals(fieldName)) {
deserializedRequestAggregation.setWindowSizeMillis(jsonReader.getLong());
} else if ("configuration".equals(fieldName)) {
Expand Down Expand Up @@ -254,7 +256,8 @@ public static RequestTriggerThreshold fromJson(JsonReader jsonReader) throws IOE
String fieldName = reader.getFieldName();
if ("type".equals(fieldName)) {
deserializedRequestTriggerThreshold.setType(
RequestTriggerThresholdType.valueOf(reader.getString()));
RequestTriggerThresholdType.valueOf(
reader.getString().toUpperCase(Locale.ROOT)));
} else if ("value".equals(fieldName)) {
deserializedRequestTriggerThreshold.setValue(reader.getFloat());
} else {
Expand Down Expand Up @@ -314,7 +317,8 @@ public static RequestTriggerThrottling fromJson(JsonReader jsonReader) throws IO
String fieldName = reader.getFieldName();
if ("type".equals(fieldName)) {
deserializedRequestTriggerThrottling.setType(
RequestTriggerThrottlingType.valueOf(reader.getString()));
RequestTriggerThrottlingType.valueOf(
reader.getString().toUpperCase(Locale.ROOT)));
} else if ("value".equals(fieldName)) {
deserializedRequestTriggerThrottling.setValue(reader.getLong());
} else {
Expand Down Expand Up @@ -426,7 +430,8 @@ public static RequestTrigger fromJson(JsonReader jsonReader) throws IOException
if ("name".equals(fieldName)) {
deserializedRequestTrigger.setName(reader.getString());
} else if ("type".equals(fieldName)) {
deserializedRequestTrigger.setType(RequestTriggerType.valueOf(reader.getString()));
deserializedRequestTrigger.setType(
RequestTriggerType.valueOf(reader.getString().toUpperCase(Locale.ROOT)));
} else if ("filter".equals(fieldName)) {
deserializedRequestTrigger.setFilter(RequestFilter.fromJson(reader));
} else if ("aggregation".equals(fieldName)) {
Expand Down
Loading