Skip to content

Log as warn invalid JMX metrics #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Log as warn invalid JMX metrics #4161

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46d2ed5
Log as warn invalid JMX metrics
jeanbisutti Apr 3, 2025
213ccb5
Feedback and put the code at the right place
jeanbisutti Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ...crosoft/applicationinsights/agent/internal/perfcounter/AbstractJmxPerformanceCounter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@

import com.microsoft.applicationinsights.agent.internal.telemetry.TelemetryClient;
import java.util.Collection;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.slf4j.MDC;
Expand All @@ -24,6 +26,8 @@ public abstract class AbstractJmxPerformanceCounter implements PerformanceCounte
private final Collection<JmxAttributeData> attributes;
private boolean alreadyLogged = false;

private final Set<String> invalidJmxMetrics = new HashSet<>();

/**
* The main method. The method will fetch the data and send it. The method will not do anything if
* there was a major problem accessing the needed counter.
Expand All @@ -38,6 +42,7 @@ public synchronized void report(TelemetryClient telemetryClient) {
for (Map.Entry<String, Collection<Object>> displayAndValues : result.entrySet()) {
boolean ok = true;
double value = 0.0;
String metricName = displayAndValues.getKey();
for (Object obj : displayAndValues.getValue()) {
try {
if (obj instanceof Boolean) {
Expand All @@ -46,14 +51,22 @@ public synchronized void report(TelemetryClient telemetryClient) {
value += Double.parseDouble(String.valueOf(obj));
}
} catch (RuntimeException e) {
if (!invalidJmxMetrics.contains(metricName)) {
invalidJmxMetrics.add(metricName);
try (MDC.MDCCloseable ignored = CUSTOM_JMX_METRIC_ERROR.makeActive()) {
logger.warn(
"{} JMX metric is invalid because only numeric and boolean JMX metric values are supported.",
metricName);
}
}
ok = false;
break;
}
}

if (ok) {
try {
send(telemetryClient, displayAndValues.getKey(), value);
send(telemetryClient, metricName, value);
} catch (RuntimeException e) {
try (MDC.MDCCloseable ignored = CUSTOM_JMX_METRIC_ERROR.makeActive()) {
logger.error("Error while sending JMX data: '{}'", e.toString());
Expand Down
Loading