Skip to content

Fix SpotBugs 6.2.1 compatibility by configuring tasks to ignore missing class failures #4252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025
Merged

Fix SpotBugs 6.2.1 compatibility by configuring tasks to ignore missing class failures #4252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45ea63d
Update version
trask Jul 8, 2025
0d04c3d
volatile
trask Jul 8, 2025
a5641a5
remove
trask Jul 8, 2025
5bddd89
Merge branch 'main' into copilot/fix-4251
trask Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...in/java/com/microsoft/applicationinsights/agent/internal/init/AppInsightsCertificate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

package com.microsoft.applicationinsights.agent.internal.init;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
Expand Down Expand Up @@ -75,9 +74,6 @@ boolean isInJavaKeystore() {
return loadedCertificates.contains(APP_INSIGHT_ROOT_CERTIFICATE);
}

@SuppressFBWarnings(
value = "SECCI", // Command Injection
justification = "No user data is used to construct the command below")
private String loadCertificates() {
String keyStoreLocation = System.getProperty("java.home") + "/lib/security/cacerts";
return executeWithoutException(
Expand Down
2 changes: 1 addition & 1 deletion ...n/java/com/microsoft/applicationinsights/agent/internal/telemetry/BatchItemProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ private static final class Worker implements Runnable {
private final long exporterTimeoutNanos;
private final int maxPendingExports;

private long nextExportTime;
private volatile long nextExportTime;

private final Queue<TelemetryItem> queue;
private final int queueCapacity;
Expand Down
7 changes: 5 additions & 2 deletions buildSrc/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ plugins {
spotless {
java {
googleJavaFormat()
licenseHeaderFile(rootProject.file("../buildscripts/spotless.license.java"), "(package|import|public)")
licenseHeaderFile(
rootProject.file("../buildscripts/spotless.license.java"),
"(package|import|public)"
)
target("src/**/*.java")
}
}
Expand All @@ -28,7 +31,7 @@ dependencies {

// When updating, update above in plugins too
implementation("com.diffplug.spotless:spotless-plugin-gradle:7.1.0")
implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:6.1.7")
implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:6.2.1")
implementation("com.gradleup.shadow:shadow-gradle-plugin:8.3.8")

implementation("org.owasp:dependency-check-gradle:12.1.3")
Expand Down