-
Notifications
You must be signed in to change notification settings - Fork 208
Fix flaky test in micrometer-1.0 instrumentation by increasing timeout #4255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5313895
Initial plan
Copilot 95eeb34
Fix flaky test by increasing timeout for shouldCaptureFunctionTimer
Copilot 2713d42
Improve FunctionTimer test robustness with better polling strategy in…
Copilot 6891dc6
Improve FunctionTimer test robustness with explicit polling strategy …
Copilot 02dfdeb
Add GitHub Actions stress test workflow for micrometer FunctionTimer …
Copilot 388e3a9
Revert timeout fix for shouldCaptureFunctionTimer test for stress tes…
Copilot 31de0e6
Increase micrometer stress test from 40 to 100 parallel runs
Copilot 0f13638
Change stress test to run all micrometer-1.0 tests instead of just sp…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: Micrometer FunctionTimer Stress Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'agent/instrumentation/micrometer-1.0/**' | ||
| - '.github/workflows/micrometer-stress-test.yml' | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| stress-test-function-timer: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| run: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100] | ||
| fail-fast: false | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up JDK for running Gradle | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 17 | ||
|
|
||
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@v4 | ||
|
|
||
| - name: Run shouldCaptureFunctionTimer test (Run ${{ matrix.run }}) | ||
| run: > | ||
| ./gradlew :agent:instrumentation:micrometer-1.0:test | ||
| --tests "MicrometerTest.shouldCaptureFunctionTimer" | ||
| --info | ||
|
|
||
| - name: Upload test reports on failure | ||
| uses: actions/upload-artifact@v4 | ||
| if: failure() | ||
| with: | ||
| name: test-reports-run-${{ matrix.run }} | ||
| path: '**/build/reports/tests/test/**/*' | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the flakiness is related to this test being run along with other tests in the module, so let's try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the stress test to run all micrometer-1.0 tests instead of just the specific test. This should better reproduce the flakiness that occurs when tests run together. Commit: 0f13638