Skip to content

Fix ErrorProne 2.38.0 build failures by updating checker configuration #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 9, 2025
Merged

Fix ErrorProne 2.38.0 build failures by updating checker configuration #4257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5569f6e
Initial plan
Copilot Jul 2, 2025
f15ad57
Initial analysis: Identify ErrorProne 2.38.0 build failure
Copilot Jul 2, 2025
ca5f68a
Fix ErrorProne 2.38.0 build failures by disabling new invalid/unwante…
Copilot Jul 2, 2025
170b610
Fix IntLiteralCast ErrorProne violations by using float literals inst…
Copilot Jul 2, 2025
ed6b3dc
Fix TimeInStaticInitializer ErrorProne violations by moving time-depe…
Copilot Jul 2, 2025
428c167
Fix EnumOrdinal ErrorProne violations by using explicit enum mapping …
Copilot Jul 2, 2025
0ac5619
Use @SuppressWarnings instead of fixing TimeInStaticInitializer and E…
Copilot Jul 7, 2025
163814c
Remove stale ErrorProne configuration comments for TimeInStaticInitia…
Copilot Jul 7, 2025
5fbdf62
Revert MockedProfilerSettingsServlet to original state and disable Ti…
Copilot Jul 7, 2025
ce8dc10
Fix license-check failure by regenerating license report for ErrorPro…
Copilot Jul 8, 2025
500bdc2
Update comment for AddNullMarkedToPackageInfo disable
Copilot Jul 8, 2025
54d3699
Merge branch 'main' into copilot/fix-4256
trask Jul 8, 2025
0ad6fb7
revertsome
trask Jul 8, 2025
e1c279e
fix
trask Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...rting/src/test/java/com/microsoft/applicationinsights/alerting/AlertingSubsystemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ private static AlertingSubsystem getAlertMonitor(
AlertConfiguration.builder()
.setType(AlertMetricType.CPU)
.setEnabled(true)
.setThreshold((float) 80)
.setThreshold(80.0f)
.setProfileDurationSeconds(30)
.setCooldownSeconds(14400)
.build(),
AlertConfiguration.builder()
.setType(AlertMetricType.MEMORY)
.setEnabled(true)
.setThreshold((float) 20)
.setThreshold(20.0f)
.setProfileDurationSeconds(120)
.setCooldownSeconds(14400)
.build(),
Expand Down Expand Up @@ -89,14 +89,14 @@ void manualAlertWorks() {
AlertConfiguration.builder()
.setType(AlertMetricType.CPU)
.setEnabled(true)
.setThreshold((float) 80)
.setThreshold(80.0f)
.setProfileDurationSeconds(30)
.setCooldownSeconds(14400)
.build(),
AlertConfiguration.builder()
.setType(AlertMetricType.MEMORY)
.setEnabled(true)
.setThreshold((float) 20)
.setThreshold(20.0f)
.setProfileDurationSeconds(120)
.setCooldownSeconds(14400)
.build(),
Expand Down Expand Up @@ -130,14 +130,14 @@ void manualAlertDoesNotTriggerAfterExpired() {
AlertConfiguration.builder()
.setType(AlertMetricType.CPU)
.setEnabled(true)
.setThreshold((float) 80)
.setThreshold(80.0f)
.setProfileDurationSeconds(30)
.setCooldownSeconds(14400)
.build(),
AlertConfiguration.builder()
.setType(AlertMetricType.MEMORY)
.setEnabled(true)
.setThreshold((float) 20)
.setThreshold(20.0f)
.setProfileDurationSeconds(120)
.setCooldownSeconds(14400)
.build(),
Expand Down
4 changes: 2 additions & 2 deletions ...microsoft/applicationinsights/agent/internal/profiler/triggers/AlertConfigParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void saneDataIsParsed() {
AlertConfiguration.builder()
.setType(AlertMetricType.CPU)
.setEnabled(true)
.setThreshold((float) 80)
.setThreshold(80.0f)
.setProfileDurationSeconds(30)
.setCooldownSeconds(14400)
.build());
Expand All @@ -53,7 +53,7 @@ void saneDataIsParsed() {
AlertConfiguration.builder()
.setType(AlertMetricType.MEMORY)
.setEnabled(true)
.setThreshold((float) 20)
.setThreshold(20.0f)
.setProfileDurationSeconds(120)
.setCooldownSeconds(14400)
.build());
Expand Down
4 changes: 3 additions & 1 deletion buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ tasks {

// Don't support Android without desugar
disable("AndroidJdkLibsChecker")
disable("Java7ApiChecker")
disable("StaticOrDefaultInterfaceMethod")

// needed temporarily while hosting azure-monitor-opentelemetry-exporter in this repo
Expand All @@ -70,6 +69,9 @@ tasks {
// cognitive load is dubious.
disable("YodaCondition")

// Requires adding compile dependency to JSpecify
disable("AddNullMarkedToPackageInfo")

if (name.contains("Jmh")) {
disable("MemberName")
}
Expand Down
2 changes: 2 additions & 0 deletions ...dk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public void setException(Throwable throwable, int stackSize) {
this.throwable = throwable;
}

@SuppressWarnings("EnumOrdinal")
public void setSeverityLevel(SeverityLevel severityLevel) {
data.setSeverityLevel(
severityLevel == null
Expand All @@ -65,6 +66,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) {
}

@Nullable
@SuppressWarnings("EnumOrdinal")
public SeverityLevel getSeverityLevel() {
return data.getSeverityLevel() == null
? null
Expand Down
2 changes: 2 additions & 0 deletions ...ic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public void setMessage(String message) {
data.setMessage(message);
}

@SuppressWarnings("EnumOrdinal")
public void setSeverityLevel(SeverityLevel severityLevel) {
data.setSeverityLevel(
severityLevel == null
Expand All @@ -56,6 +57,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) {
}

@Nullable
@SuppressWarnings("EnumOrdinal")
public SeverityLevel getSeverityLevel() {
return data.getSeverityLevel() == null
? null
Expand Down
2 changes: 1 addition & 1 deletion dependencyManagement/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ val DEPENDENCY_BOMS = listOf(

val autoServiceVersion = "1.1.1"
val autoValueVersion = "1.11.0"
val errorProneVersion = "2.36.0"
val errorProneVersion = "2.38.0"
val jmhVersion = "1.37"
val mockitoVersion = "4.11.0"
val slf4jVersion = "2.0.17"
Expand Down
2 changes: 1 addition & 1 deletion licenses/more-licenses.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ _2025-07-08 14:53:50 UTC_
> - **POM Project URL**: [http://stephenc.github.com/jcip-annotations](http://stephenc.github.com/jcip-annotations)
> - **POM License**: Apache License, Version 2.0 - [https://www.apache.org/licenses/LICENSE-2.0](https://www.apache.org/licenses/LICENSE-2.0)

**6** **Group:** `com.google.errorprone` **Name:** `error_prone_annotations` **Version:** `2.36.0`
**6** **Group:** `com.google.errorprone` **Name:** `error_prone_annotations` **Version:** `2.38.0`
> - **Manifest Project URL**: [https://errorprone.info/error_prone_annotations](https://errorprone.info/error_prone_annotations)
> - **Manifest License**: Apache License, Version 2.0 (Not Packaged)
> - **POM License**: Apache License, Version 2.0 - [http://www.apache.org/licenses/LICENSE-2.0](http://www.apache.org/licenses/LICENSE-2.0)
Expand Down
1 change: 1 addition & 0 deletions .../microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

@SuppressWarnings("TimeInStaticInitializer")
public class MockedProfilerSettingsServlet extends HttpServlet {

private static final Map<ProfilerState, String> CONFIGS;
Expand Down