Update Logback smoke tests to use new assertion framework and extend framework for MessageData and ExceptionData #4322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Logback smoke tests to use the new assertion framework introduced in #4141 and extends the framework to support MessageData and ExceptionData assertions.
Changes Made
Framework Extensions
Added
MessageAssertclass - Provides fluent assertions for MessageData with methods like:hasMessage()- Assert message contenthasSeverityLevel()- Assert severity levelhasProperty()- Assert propertieshasPropertiesSize()- Assert property countAdded
ExceptionAssertclass - Provides fluent assertions for ExceptionData with methods like:hasExceptionType()- Assert exception typehasExceptionMessage()- Assert exception messagehasSeverityLevel()- Assert severity levelhasEmptyProperties()- Assert no properties (for non-logger exceptions)Extended
TraceAssert- Added support for:hasMessageSatisying()- Assert message data in tracehasExceptionCount()- Assert exception counthasExceptionSatisying()- Assert exception data in traceTest Updates
LogbackTest.java
test()method to use new framework for asserting message datatestWithException()method to use new framework for asserting exception dataLogbackDisabledTest.java & LogbackLevelOffTest.java
ExceptionAssertclassBenefits
Example Usage
Before:
After:
The tests now use the same modern assertion framework introduced in #4141, making them more maintainable and consistent with the rest of the codebase.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.