Sync spotless configuration with OpenTelemetry Java Instrumentation #4366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Jul 21, 2025
Comment on lines
+167
to
+176
| val generateLicenseReportEnabled = | ||
| gradle.startParameter.taskNames.any { it.equals("generateLicenseReport") } | ||
| named("generateLicenseReport").configure { | ||
| dependsOn(cleanLicenses) | ||
| finalizedBy(":spotlessApply") | ||
| // disable licence report generation unless this task is explicitly run | ||
| // the files produced by this task are used by other tasks without declaring them as dependency | ||
| // which gradle considers an error | ||
| enabled = enabled && generateLicenseReportEnabled | ||
| } | ||
| if (generateLicenseReportEnabled) { | ||
| project.parent?.parent?.tasks?.getByName("spotlessMisc")?.dependsOn(named("generateLicenseReport")) |
Member
Author
There was a problem hiding this comment.
this is also copy from upstream
trask
requested review from
harsimar,
jeanbisutti,
rajkumar-rangaraj,
ramthi and
xiang17
as code owners
rajkumar-rangaraj
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream file: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/conventions/src/main/kotlin/otel.spotless-conventions.gradle.kts