Fix TODO: Remove unused okio dependency from agent-tooling #4401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tations dependency Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
[WIP] fix this todo in agent/agent-tooling/build.gradle.kts:
// TODO(trask): update tests, no need to use this anymore
testImplementation("com.squareup.okio:okio:3.15.0")
Fix TODO: Remove unused okio dependency from agent-tooling
Jul 30, 2025
Copilot finished work on behalf of
trask
July 30, 2025 17:17
trask
requested review from
harsimar,
jeanbisutti,
rajkumar-rangaraj,
ramthi and
xiang17
as code owners
trask
reviewed
Jul 30, 2025
Member
|
@copilot remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a TODO comment in
agent/agent-tooling/build.gradle.ktsby removing the unusedokiodependency that was no longer needed by the tests.Problem
The build file contained a TODO comment indicating that the okio dependency was no longer necessary:
A comprehensive search of the codebase confirmed that no Java files in the agent-tooling module were importing or using any okio classes (such as
okio.Buffer,okio.Source,okio.Sink, etc.).Solution
testImplementation("com.squareup.okio:okio:3.15.0")dependencytestImplementation("org.jetbrains:annotations:13.0")The JetBrains annotations dependency was necessary because some test files use
@NotNullannotations fromorg.jetbrains.annotations.NotNull, which were previously available transitively through okio's Kotlin standard library dependency.Testing
./gradlew :agent:agent-tooling:compileTestJavasucceedsTelemetryProcessorMaskingTestandProfilingInitializerTestto ensure functionality is preservedThis change reduces the dependency footprint while maintaining all existing functionality.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.