Fix log sampling overrides by running preview processors before filtering#4527
Closed
trask wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix log sampling overrides by running preview processors before filtering#4527trask wants to merge 1 commit intomicrosoft:mainfrom
trask wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
Author
|
Closing, as sampling overrides should occur before telemetry processors are run. The previous behavior was unfortunately more of a bug. Attempting to work around this and preserve the prior behavior is complex and leading to potentially other inconsistencies and behavioral changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TelemetryProcessorLogFilterSamplingOverridesTest) that reproduces issue Filter logs using attributes does not work starting version 3.7.2 #4526 by exercising sampling overrides based on attributes derived by preview processors.AzureMonitorLogFilteringProcessorapplies preview attribute/log processors before executing severity filtering and sampling overrides, ensuring those overrides see the processed attributes.Root Cause
AzureMonitorLogFilteringProcessor, moving severity filtering and sampling overrides fromAgentLogExporterto a processor that now runs ahead of preview attribute and log processors.Fix Details
AzureMonitorLogFilteringProcessorbefore sampling decisions so overrides can match on transformed attributes.SecondEntryPointinto the filtering processor to maintain the prior processing order.