NLog ApplicationInsightsTarget with support for IncludeMldc#2103
NLog ApplicationInsightsTarget with support for IncludeMldc#2103snakefoot wants to merge 33 commits intomicrosoft:mainfrom
Conversation
snakefoot
changed the title
|
@TimothyMothra why has this never get merged? Or has received any feedback? |
|
Should I interpret the staleness of this PR to mean that there is a very low likelihood of #2785 being resolved? |
|
I'm guessing Microsoft wanted to invite existing NLog users to try the fruits of ApplicationInsights, which give birth to this NLog Target. Microsoft is probably putting most of their energy into their pure Microsoft Extension Logging integration with ApplicationInsights, and not any hybrid modes. Microsoft probably believes that one would not use NLog, after having started using Microsoft Extensions Logging. |
|
Maybe we should fork this repo and release it as a NLog package. Not perfect, but I dont like getting ghosted. |
Would prefer if someone with extensive knowledge about ApplicationInsights (along with its telemetry capture) took up the challenge. Since right now this NLog-target package cannot stand on its own (doesn't capture/forward all application-performance keyfigures). |
|
From what I could see, I suspect maybe the App Insights team has been focused on other platforms (e.g. Python, etc.) for a little while, plus MS has been dedicating resources to integrating OpenTelemetry (which is a less proprietary design for similar functionality) to both .NET and App Insights so I'm hopeful it has just been a matter of lacking resources to dedicate to this side for now, though it does seem this has been here quite a while. I've also recently learned that .NET 8 is introducing a new Either way, without knowing what implementation we could possibly pursue with those things yet, we find ourselves missing needed functionality to properly implement App Insights at the immediate moment, since all of our logging goes through NLog and we don't have a current enough bridge to bring our traces and exceptions from there into App Insights. |
snakefoot
force-pushed
the
develop
branch
2 times, most recently
from
810d9eb to
8948cf1
Compare
|
See also: direction is to use OpenTelemetry |
|
The overview linked there has the following excerpt which makes me wonder where we should be focusing our effort for the next release:
|
merge MASTER to DEVELOP
* public apis remove and errors fix * changes * first pass on deleting stuff from channel folder * deleting some more stuff * trace folder cleanup * more cleanup, this one has build errors * clean * Clean up except context. * Fix formatting in Nightly Builds section of Readme * adding some dependency changes, not fully done * drafting track trace, not done * track trace modification --------- Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
…pattern (microsoft#3001) * Shimmed NLog and fix builder pattern * Connection string update.
* ASP.NET Core and Worker Service Support * Release mode fix * Fix regression * AssemblyInfo Fix
* Updated tests * Fix warning * Add dependency support * Other changes
* Update CI * Remove classic ASP.NET example from sln
* Update NLog tests * remove ignore test * dispose to make code analyzers happy.
* Trimmed public API. Start/Stop operation with initial test * Fix tests
* ExceptionTelemetry DataContract * Updated app, exception properties
|
There are no plans to add any new features to existing NLog ApplicationInsightsTarget. |
5 participants
Add support for NLog Mapped Diagnostic Logical Context (MDLC)
Changes
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build