Skip to content

Conversation

@rajkumar-rangaraj
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 19, 2025 21:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Azure Active Directory (Entra ID) authentication to the NLog target by introducing a new Credential property that accepts a TokenCredential for AAD authentication with Azure Monitor.

Key changes:

  • Added Credential property to ApplicationInsightsTarget for AAD token-based authentication
  • Integrated OpenTelemetry resource configuration with distribution name tracking
  • Updated documentation and examples to demonstrate the new AAD authentication approach

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
LOGGING/src/NLogTarget/ApplicationInsightsTarget.cs Added Credential property, integrated credential configuration in InitializeTarget, and added OpenTelemetry resource attributes
LOGGING/test/NLogTarget.Tests/NLogTargetTests.cs Added test for Credential property getter/setter and MockTokenCredential helper class
examples/NLogConsoleApp/Program.cs Updated commented example code to demonstrate new credential-based AAD authentication approach
LOGGING/README.md Updated AAD authentication documentation with new programmatic configuration example
.publicApi/Microsoft.ApplicationInsights.NLogTarget.dll/Stable/PublicAPI.Unshipped.txt Added public API surface for new Credential property

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rajkumar-rangaraj rajkumar-rangaraj merged commit 16c877a into main Dec 19, 2025
22 checks passed
@rajkumar-rangaraj rajkumar-rangaraj deleted the rajrang/aad branch December 19, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants