Skip to content

Mark cloud context internal#3090

Merged
rajkumar-rangaraj merged 1 commit intomainfrom
rajrang/CCInternal
Jan 27, 2026
Merged

Mark cloud context internal#3090
rajkumar-rangaraj merged 1 commit intomainfrom
rajrang/CCInternal

Conversation

@rajkumar-rangaraj
Copy link
Member

Fix Issue # .

Changes

(Please provide a brief description of the changes here.)

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Copilot AI review requested due to automatic review settings January 27, 2026 03:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR marks the CloudContext class and the TelemetryContext.Cloud property as internal, representing a breaking change in the public API. The change removes public access to Cloud.RoleName and Cloud.RoleInstance properties, aligning with the 3.x architectural shift towards OpenTelemetry where these values should be set via resource attributes.

Changes:

  • Changed CloudContext class visibility from public to internal
  • Changed TelemetryContext.Cloud property visibility from public to internal and relocated it after public properties
  • Removed CloudContext and related APIs from the public API surface in PublicAPI.Unshipped.txt

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
CloudContext.cs Changed class visibility modifier from public sealed to internal sealed
TelemetryContext.cs Changed Cloud property from public to internal and moved it after public properties to maintain organizational consistency
PublicAPI.Unshipped.txt Removed CloudContext class and TelemetryContext.Cloud property from the public API surface

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rajkumar-rangaraj rajkumar-rangaraj merged commit 32e8ae3 into main Jan 27, 2026
28 checks passed
@rajkumar-rangaraj rajkumar-rangaraj deleted the rajrang/CCInternal branch January 27, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants