Skip to content

Bug 616929: [Payables Agent] Fixes discount error handling #6107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ventselartur wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bug 616929: [Payables Agent] Fixes discount error handling #6107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/Apps/W1/EDocument/App/src/Processing/Import/Purchase/EDocPurchaseDraftSubform.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ page 6183 "E-Doc. Purchase Draft Subform"

trigger OnValidate()
begin
UpdateCalculatedAmounts(true);
UpdateCalculatedAmounts(true, true);
end;
}
field("Direct Unit Cost"; Rec."Unit Price")
Expand All @@ -96,7 +96,7 @@ page 6183 "E-Doc. Purchase Draft Subform"
Editable = true;
trigger OnValidate()
begin
UpdateCalculatedAmounts(true);
UpdateCalculatedAmounts(true, true);
end;
}
field("Total Discount"; Rec."Total Discount")
Expand All @@ -106,7 +106,7 @@ page 6183 "E-Doc. Purchase Draft Subform"
Editable = true;
trigger OnValidate()
begin
UpdateCalculatedAmounts(true);
UpdateCalculatedAmounts(true, true);
end;
}
field("Line Amount"; LineAmount)
Expand Down Expand Up @@ -336,7 +336,7 @@ page 6183 "E-Doc. Purchase Draft Subform"
if EDocumentPurchaseLine.Get(Rec."E-Document Entry No.", Rec."Line No.") then;
AdditionalColumns := Rec.AdditionalColumnsDisplayText();
SetHasAdditionalColumns();
UpdateCalculatedAmounts(false);
UpdateCalculatedAmounts(false, false);
IsLineMatchedToOrderLine := EDocPOMatching.IsEDocumentLineMatchedToAnyPOLine(EDocumentPurchaseLine);
IsLineMatchedToReceiptLine := EDocPOMatching.IsEDocumentLineMatchedToAnyReceiptLine(EDocumentPurchaseLine);
OrderMatchedCaption := IsLineMatchedToOrderLine ? GetSummaryOfMatchedOrders() : '';
Expand Down Expand Up @@ -374,7 +374,7 @@ page 6183 "E-Doc. Purchase Draft Subform"
DimVisible1, DimVisible2, DimOther, DimOther, DimOther, DimOther, DimOther, DimOther);
end;

local procedure UpdateCalculatedAmounts(UpdateParentRecord: Boolean)
local procedure UpdateCalculatedAmounts(UpdateParentRecord: Boolean; LaunchErrorOnInvalidDiscount: Boolean)
var
TotalEDocPurchaseLine: Record "E-Document Purchase Line";
EDocumentImportHelper: Codeunit "E-Document Import Helper";
Expand All @@ -383,6 +383,7 @@ page 6183 "E-Doc. Purchase Draft Subform"
begin
LineSubtotal := Rec.Quantity * Rec."Unit Price";
LineAmount := LineSubtotal - Rec."Total Discount";
if LaunchErrorOnInvalidDiscount then
if LineSubtotal = 0 then begin
if Rec."Total Discount" > 0 then
Error(DiscountExceedsSubtotalErr)
Expand Down
Loading