Skip to content

Remove activity listener composer #5467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pranavjoshi001
Copy link

@pranavjoshi001 pranavjoshi001 commented Apr 25, 2025

Changelog Entry

  • Removed ActivitListenerComposer and useUpsertedActivities hook as it is not needed anymore.

Description

  • useReduceActivities is enhanced version which does partial computation and better to be replaced in place of useUpsertedActivities
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

OEvgeny
OEvgeny previously approved these changes Apr 29, 2025
Co-authored-by: Eugene <[email protected]>
@pranavjoshi001 pranavjoshi001 requested a review from OEvgeny April 29, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants