Skip to content

[WIP] Introduction of polyMiddleware #5515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[WIP] Introduction of polyMiddleware #5515

wants to merge 6 commits into from

Conversation

compulim
Copy link
Contributor

Fixes #

Changelog Entry

Description

Design

Specific Changes

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

OEvgeny
OEvgeny reviewed Jul 17, 2025
View reviewed changes
OEvgeny
OEvgeny reviewed Jul 17, 2025
View reviewed changes
packages/middleware/src/internal/createActivityPolyMiddlewareFromLegacy.tsx
Comment on lines +65 to +71
const legacyResult = legacyHandler({ activity, nextVisibleActivity: undefined as any });

if (!legacyResult) {
return undefined;
}

return activityComponent(bridgeComponent, { activity, render: legacyResult });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be hooks mismatch due to:

  • on the first pass legacyResult is false
  • on the second pass it flips, so we call the activityComponent

OEvgeny
OEvgeny reviewed Jul 17, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OEvgeny OEvgeny OEvgeny left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n will be requested when the pull request is marked ready for review a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten will be requested when the pull request is marked ready for review cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath will be requested when the pull request is marked ready for review srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford will be requested when the pull request is marked ready for review tdurnford is a code owner

@beyackle2 beyackle2 Awaiting requested review from beyackle2 beyackle2 will be requested when the pull request is marked ready for review beyackle2 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compulim @OEvgeny