-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Bump samples to use botframework-webchat@main and rename packages
#5533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botframework-webchat@main and rename packagesbotframework-webchat@main and rename packages
botframework-webchat@main and rename packagesbotframework-webchat@main and rename packages
OEvgeny
reviewed
Aug 6, 2025
OEvgeny
approved these changes
Aug 6, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the dependency management for samples, archives certain samples due to maintenance constraints, and introduces organizational package naming conventions.
- Updates
npm run bumpscripts across all samples to use a more sophisticated dependency management system - Bumps samples to use
botframework-webchat@mainbranch and other latest dependencies - Archives
01.getting-started/l.sharepoint-web-partand the entire07.advanced-web-chat-appsdirectory
Reviewed Changes
Copilot reviewed 36 out of 52 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| samples/package.json | Adds new bump scripts and renames package to use @MSInternal scope |
| samples/README.md | Marks archived samples with strikethrough formatting |
| Various package.json files | Updates package names to @MSInternal scope and dependency versions |
| Various README.md files | Adds archive notice to affected samples |
| samples/06.recomposing-ui/c.smart-display/src/BotResponse.tsx | Updates react-film import syntax |
| package.json | Updates root package bump command for samples |
| CHANGELOG.md | Documents the archival of samples |
Files not reviewed (6)
- samples/01.getting-started/k.direct-line-token/javascript/web/package-lock.json: Language not supported
- samples/01.getting-started/l.sharepoint-web-part/package-lock.json: Language not supported
- samples/07.advanced-web-chat-apps/b.sso-for-enterprise/rest-api/package-lock.json: Language not supported
- samples/07.advanced-web-chat-apps/c.sso-for-intranet/web/package-lock.json: Language not supported
- samples/07.advanced-web-chat-apps/d.sso-for-teams/web/package-lock.json: Language not supported
- samples/07.advanced-web-chat-apps/e.sso-on-behalf-of-authentication/rest-api/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Samples
07.advanced-web-chat-appsis being archived and will no longer receive updates, in PR #5533, by @compulimDescription
Updated
npm run bumpscript.Bumped samples to use latest dependencies including
botframework-webchat@main.Archived
01.getting-started/l.sharepoint-web-partand07.advanced-web-chat-appsdue to resources to update/test the samples. Removedpackage-lock.jsonso we are not in the business ofnpm audit.Renamed samples and moved under
@msinternal/*.Design
Specific Changes
npm run bumpscripts for samplesbotframework-webchat@main01.getting-started/l.sharepoint-web-partand07.advanced-web-chat-apps@msinternal/*I have added tests and executed them locallyCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)