Skip to content

Conversation

@compulim
Copy link
Contributor

@compulim compulim commented Aug 5, 2025

Changelog Entry

Samples

  • Samples under 07.advanced-web-chat-apps is being archived and will no longer receive updates, in PR #5533, by @compulim

Description

Updated npm run bump script.

Bumped samples to use latest dependencies including botframework-webchat@main.

Archived 01.getting-started/l.sharepoint-web-part and 07.advanced-web-chat-apps due to resources to update/test the samples. Removed package-lock.json so we are not in the business of npm audit.

Renamed samples and moved under @msinternal/*.

Design

Specific Changes

  • Updated npm run bump scripts for samples
  • Bumped dependencies in samples including botframework-webchat@main
  • Archived 01.getting-started/l.sharepoint-web-part and 07.advanced-web-chat-apps
  • Renamed samples and moved under @msinternal/*
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim changed the title Bump samples to use botframework-webchat@main and rename packages [WIP] Bump samples to use botframework-webchat@main and rename packages Aug 5, 2025
@compulim compulim changed the title [WIP] Bump samples to use botframework-webchat@main and rename packages Bump samples to use botframework-webchat@main and rename packages Aug 6, 2025
@compulim compulim marked this pull request as ready for review August 6, 2025 22:33
@compulim compulim requested a review from beyackle2 as a code owner August 6, 2025 22:33
@OEvgeny OEvgeny requested a review from Copilot August 6, 2025 23:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dependency management for samples, archives certain samples due to maintenance constraints, and introduces organizational package naming conventions.

  • Updates npm run bump scripts across all samples to use a more sophisticated dependency management system
  • Bumps samples to use botframework-webchat@main branch and other latest dependencies
  • Archives 01.getting-started/l.sharepoint-web-part and the entire 07.advanced-web-chat-apps directory

Reviewed Changes

Copilot reviewed 36 out of 52 changed files in this pull request and generated no comments.

Show a summary per file
File Description
samples/package.json Adds new bump scripts and renames package to use @MSInternal scope
samples/README.md Marks archived samples with strikethrough formatting
Various package.json files Updates package names to @MSInternal scope and dependency versions
Various README.md files Adds archive notice to affected samples
samples/06.recomposing-ui/c.smart-display/src/BotResponse.tsx Updates react-film import syntax
package.json Updates root package bump command for samples
CHANGELOG.md Documents the archival of samples
Files not reviewed (6)
  • samples/01.getting-started/k.direct-line-token/javascript/web/package-lock.json: Language not supported
  • samples/01.getting-started/l.sharepoint-web-part/package-lock.json: Language not supported
  • samples/07.advanced-web-chat-apps/b.sso-for-enterprise/rest-api/package-lock.json: Language not supported
  • samples/07.advanced-web-chat-apps/c.sso-for-intranet/web/package-lock.json: Language not supported
  • samples/07.advanced-web-chat-apps/d.sso-for-teams/web/package-lock.json: Language not supported
  • samples/07.advanced-web-chat-apps/e.sso-on-behalf-of-authentication/rest-api/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

@compulim compulim merged commit 154445d into main Aug 6, 2025
28 checks passed
@compulim compulim deleted the feat-bump-samples branch August 6, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants