Skip to content

Upgrade tests to html2 (part 5) #5546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions __tests__/html/carousel.flipperButton.js

This file was deleted.

7 changes: 0 additions & 7 deletions __tests__/html/carousel.flipperButton.rtl.js

This file was deleted.

7 changes: 0 additions & 7 deletions __tests__/html/carousel.navigation.tab.cardInput.js

This file was deleted.

5 changes: 0 additions & 5 deletions __tests__/html/carousel.navigation.tab.js

This file was deleted.

5 changes: 0 additions & 5 deletions __tests__/html/chatAdapter.directLineAppServiceExtension.js

This file was deleted.

5 changes: 0 additions & 5 deletions __tests__/html/chatAdapter.directLineSpeech.js

This file was deleted.

5 changes: 0 additions & 5 deletions __tests__/html/chatAdapter.nullFields.js

This file was deleted.

3 changes: 0 additions & 3 deletions __tests__/html/chatAdapter.reconnect.js

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions __tests__/html/chatAdapter.sequenceId.noSequenceId.js

This file was deleted.

3 changes: 0 additions & 3 deletions __tests__/html/chatAdapter.sequenceId.simple.js

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
await pageConditions.became('Carousel should scroll right', () => carouselFilmstrip.scrollLeft > 100, 1000);

await testHelpers.sleep(500); // Wait both flippers to fade in.
await host.snapshot();
await host.snapshot('local');

// WHEN: Left flipper is clicked.
const leftFlipper = carouselLayout.querySelector('[aria-label="Previous"]');
Expand All @@ -58,7 +58,7 @@
); // 1 pixel for tolerance.

await testHelpers.sleep(500); // Wait for right flipper to fade away.
await host.snapshot();
await host.snapshot('local');
});
</script>
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
await pageConditions.became('Carousel should scroll left', () => carouselFilmstrip.scrollLeft < -100, 1000);

await testHelpers.sleep(500); // Wait both flippers to fade in.
await host.snapshot();
await host.snapshot('local');

// WHEN: Right flipper is clicked. In RTL, the right flipper goes back.
const rightFlipper = carouselLayout.querySelector('[aria-label="Previous"]');
Expand All @@ -59,7 +59,7 @@
); // 1 pixel for tolerance.

await testHelpers.sleep(500); // Wait for right flipper to fade away.
await host.snapshot();
await host.snapshot('local');
});
</script>
</body>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

// Focus on first card button
await host.sendTab();
await host.snapshot();
await host.snapshot('local');
});
</script>
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
document.activeElement === document.activeElement.parentElement.children[0],
1000
);
await host.snapshot();
await host.snapshot('local');

// Second focus is not very stable because of its position, we are skipping snapshotting it.
// Third focus inside carousel
Expand All @@ -59,7 +59,7 @@
5,
5000
);
await host.snapshot();
await host.snapshot('local');

// Press ESCAPE key should focus the activity.
await host.sendKeys('ESCAPE');
Expand All @@ -74,7 +74,7 @@
5,
5000
);
await host.snapshot();
await host.snapshot('local');
});
</script>
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
await pageObjects.sendMessageViaSendBox('echo Hello, World!', { waitForSend: true });
await pageConditions.minNumActivitiesShown(3);

await host.snapshot();
await host.snapshot('local');
});
</script>
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
await pageConditions.suggestedActionsShown();
await pageConditions.allImagesLoaded();

await host.snapshot();
await host.snapshot('local');
});
</script>
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
expect(sending[1].activity.channelData.state).toBeUndefined();

// THEN: It should show message in order of "2", "1", followed by "0".
await host.snapshot();
await host.snapshot('local');

// WHEN: The first message has echoed back with a timestamp of 1.
sending[0].resolve({
Expand All @@ -122,7 +122,7 @@
// THEN: It should show message in the order of "1", "2", followed by "0".
// "1" should be marked as sent.
// "0" should be sending.
await host.snapshot();
await host.snapshot('local');

// THEN: The first outgoing message should appears first, before the bot's message.
// The first outgoing message has a smaller timestamp (t=1) than the bot's message (t=2).
Expand Down Expand Up @@ -150,7 +150,7 @@
]);

// THEN: It should show message in the order of "0", "1", followed by "2".
await host.snapshot();
await host.snapshot('local');
});
</script>
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
await pageConditions.scrollToBottomCompleted();

// THEN: It should show a chat history sorted based on "ts" field.
await host.snapshot();
await host.snapshot('local');
});
</script>
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
await pageConditions.scrollToBottomCompleted();

// THEN: It should show a transcript sorted based on "seq" field.
await host.snapshot();
await host.snapshot('local');
});
</script>
</body>
Expand Down
Loading