fix: Update model in checkquota.sh and remove unnecessary sleep #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harsh-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two improvements: updating model identifiers and removing an unnecessary delay in script execution to improve performance.
- Removes an unnecessary time.sleep(4) call in create_search_index.py to enhance efficiency
- Updates model definitions in checkquota.sh (not shown in this diff)
Files not reviewed (1)
- infra/scripts/checkquota.sh: Language not supported
Roopan-Microsoft
approved these changes
Apr 29, 2025
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes updates to the
infra/scriptsdirectory, addressing changes to model definitions and script functionality. The most important changes involve updating model identifiers in a quota-checking script and removing an unnecessary delay in the indexing script.Updates to model definitions:
infra/scripts/checkquota.sh: Updated the model identifier fromOpenAI.Standard.gpt-4toOpenAI.GlobalStandard.gpt-4o-miniin theMIN_CAPACITYmapping to reflect the latest naming conventions or requirements.Script functionality improvements:
infra/scripts/index_scripts/create_search_index.py: Removed an unnecessarytime.sleep(4)call, likely to improve the efficiency of the script during batch uploads.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information