fix: merging dev to main #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roopan-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR refines a function description for clarity and enhances Docker build efficiency by updating the ignore patterns.
- Expanded
.dockerignoreto exclude a broad set of local artifacts, IDE settings, and temporary files for cleaner containers. - Corrected and clarified the
@kernel_functiondescription onget_SQL_Responseinchat_logic_handler.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/.dockerignore | Added comprehensive ignore patterns for Docker builds |
| src/App/backend/chat_logic_handler.py | Updated @kernel_function description for get_SQL_Response decorator |
Abdul-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Co-authored-by: Copilot <[email protected]>
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Co-authored-by: Copilot <[email protected]>
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prajwal-Microsoft
approved these changes
May 21, 2025
|
🎉 This PR is included in version 1.1.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
.dockerignorefile and refine a function's description inchat_logic_handler.py. The changes enhance container build efficiency and clarify the functionality of a database query method.Updates to
.dockerignore:**/.DS_Store,**/__pycache__,node_modules/), IDE/project settings (**/.vscode,**/*.user), and Python-specific files (*.py[cod],build/,.tox/). This ensures cleaner and more efficient Docker images.Refinement of function description:
@kernel_functiondecorator description forget_SQL_Responseinchat_logic_handler.pyto clarify that it retrieves database details about client assets, investments, and meeting schedules, including upcoming or next meeting dates/times.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information