fix: update minimal tls version #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the security and compatibility of the infrastructure deployment scripts by enforcing a minimum TLS version for SQL servers, upgrading the Bicep CLI version, and updating the Azure Cognitive Services API version.
- Updated Bicep CLI version and associated template hashes in infra/main.json.
- Upgraded the API version for Azure Cognitive Services and removed deprecated configuration properties.
- Enforced a minimum TLS version of 1.2 in both infra/main.json and infra/deploy_sql_db.bicep.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/main.json | Upgraded Bicep CLI version, updated API version for Cognitive Services, and removed apiProperties. |
| infra/deploy_sql_db.bicep | Added minimalTlsVersion to ensure SQL server security. |
Avijit-Microsoft
approved these changes
May 22, 2025
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces updates to the infrastructure deployment scripts, focusing on enhancing security, upgrading dependencies, and improving compatibility with newer API versions. The most significant changes include enforcing a minimum TLS version for SQL servers, upgrading the Bicep CLI version, and transitioning to a newer API version for Azure Cognitive Services.
Security Enhancements:
1.2for SQL servers in bothinfra/deploy_sql_db.bicepandinfra/main.jsonto improve security. [1] [2]Dependency Upgrades:
0.34.44.8038to0.35.1.17967across multiple sections ininfra/main.json, resulting in updated template hashes. [1] [2] [3] [4] [5] [6] [7] [8] [9]API Version Updates:
2021-10-01to2024-04-01-previewininfra/main.jsonto ensure compatibility with the latest features. This includes changes to resource references, key retrieval, and endpoint configurations. [1] [2] [3] [4] [5] [6] [7]Cognitive Services Configuration:
apiPropertiessection (e.g.,statisticsEnabled) from the Azure Cognitive Services configuration ininfra/main.json, simplifying the resource properties.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information