feat: FDP changes, Updation to use AI agents #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssistants (#566) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files.
* initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * fix: correct variable names for managed identity and AI foundry in scripts and templates
Ragini-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR implements significant restructuring and refactoring across multiple areas including end-to-end tests, configuration files, and the core database and chat service functionality. Key changes include restructuring of test cases and fixtures, migration from the old db.py module to a new sqldb_service.py module, and updates to various Azure service configuration and deployment scripts.
Reviewed Changes
Copilot reviewed 39 out of 43 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e-test/* | Reorganized tests and fixtures; updated module import paths |
| src/App/backend/services/sqldb_service.py | New database service implementation with sample data update logic |
| src/App/backend/services/chat_service.py | New chat service implementation streaming responses via an agent |
| src/App/backend/agents/agent_factory.py | Added singleton pattern for AzureAIAgent management |
| infra/* | Updated deployment scripts and Bicep files to reflect new config paths |
Comments suppressed due to low confidence (1)
src/App/backend/services/sqldb_service.py:140
- Multiple commit() calls in update_sample_data() could be optimized by batching updates into a single transaction to reduce I/O overhead and improve performance. Consider combining the update statements and committing once after all updates complete.
rows = dict_cursor(cursor)
| yield chunk.content # just the deltaText | ||
| finally: | ||
| thread = chunk.thread if chunk else None | ||
| await thread.delete() if thread else None |
There was a problem hiding this comment.
In the 'finally' block of the generate() function, if no chunk is yielded the variable 'chunk' will not be defined, which can lead to an UnboundLocalError. Consider storing the thread reference before entering the async loop or initializing 'chunk' to a default value to ensure safe cleanup.
Roopan-Microsoft
approved these changes
Jun 20, 2025
Avijit-Microsoft
approved these changes
Jun 20, 2025
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Roopan-Microsoft
pushed a commit
that referenced
this pull request
Jun 27, 2025
…from popup (#578) * feat: FDP changes, Updation to use AI agents (#571) * Implemented Log execution time per prompt in Report * updated readme * updated the code * added functions * feat: added fdp changes, updated to use ai agents instead of openai assistants (#566) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * refactor: couple of typo fix (#570) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * fix: correct variable names for managed identity and AI foundry in scripts and templates --------- Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> * bug fix(#19849) --------- Co-authored-by: Prajwal-Microsoft <[email protected]> Co-authored-by: Ragini-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]>
Roopan-Microsoft
pushed a commit
that referenced
this pull request
Jun 27, 2025
* Implemented Log execution time per prompt in Report * updated readme * updated the code * added functions * feat: added fdp changes, updated to use ai agents instead of openai assistants (#566) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * refactor: couple of typo fix (#570) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * fix: correct variable names for managed identity and AI foundry in scripts and templates * feat: quota check during azd up (#579) * quota-check-during azd up * updated bicep and parameter json * fix: There is no progress/Process message when deleting chat history from popup (#578) * feat: FDP changes, Updation to use AI agents (#571) * Implemented Log execution time per prompt in Report * updated readme * updated the code * added functions * feat: added fdp changes, updated to use ai agents instead of openai assistants (#566) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * refactor: couple of typo fix (#570) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * fix: correct variable names for managed identity and AI foundry in scripts and templates --------- Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> * bug fix(#19849) --------- Co-authored-by: Prajwal-Microsoft <[email protected]> Co-authored-by: Ragini-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> * updated openai version (#581) * deleted params --------- Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> Co-authored-by: Ragini-Microsoft <[email protected]>
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Infrastructure Updates: Transition to AI Foundry
infra/deploy_ai_foundry.bicep: Replaced legacy AI services (aiServices,aiHub,aiHubProject) with new AI Foundry resources (aiFoundry,aiFoundryProject). Added support for AI Foundry-specific endpoints, project management, and connections to Cognitive Search and App Insights. Removed redundant resources such as storage accounts and container registries. [1] [2] [3]infra/abbreviations.json: Added abbreviations for AI Foundry (aiFoundry,aiFoundryProject) to support naming conventions for new resources.infra/deploy_app_service.bicep: Updated parameters to remove sensitive keys (e.g., Azure OpenAI Key, SQL Database credentials) and replaced AI project-specific parameters with AI Foundry equivalents (aiFoundryProjectEndpoint,aiFoundryName). Adjusted environment variable configuration for the web app. [1] [2]Documentation Updates: Reflect AI Foundry Transition
docs/DeploymentGuide.md: Updated Azure OpenAI API version to2025-04-01-preview. Modified deployment scripts to include new parameters for AI Foundry and Cognitive Search resources. [1] [2]Removal of Redundant Resources
infra/deploy_ai_foundry.bicep: Removed unused resources such ascontainerRegistry,storage, and various secrets related to legacy AI services (e.g.,COG-SERVICES-ENDPOINT,COG-SERVICES-KEY). Consolidated outputs to reflect AI Foundry endpoints and project names. [1] [2]These changes streamline the deployment process, improve security by removing sensitive keys, and align the infrastructure with the new AI Foundry architecture.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information