feat: Merge the Azd Quota check changes from dev to main #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssistants (#566) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files.
* initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * fix: correct variable names for managed identity and AI foundry in scripts and templates
* quota-check-during azd up * updated bicep and parameter json
Abdul-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request implements updates for the Azd Quota check changes and transitions deployment configurations and resource naming. Key changes include:
- Enhancements in test infrastructure and parameterization, incorporating new environment-based configuration via the backend common config.
- Updates to deployment and agent initialization logic in both application and supporting infrastructure scripts.
- Removal of deprecated code (e.g. db.py) and updates to dependency versions.
Reviewed Changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e-test/* | Various test refactors and new test cases for functional and GP flows. |
| tests/e2e-test/conftest.py | Added improved log capture and streamlined test setup. |
| tests/e2e-test/requirements.txt | Added new testing dependencies and updated existing versions. |
| tests/e2e-test/pages/homePage.py | Introduced new chat history functions and refactored locators. |
| src/App/backend/services/chat_service.py | Updated stream response logic to match new config usage. |
| src/App/backend/common/config.py | Centralized configuration for environment variables. |
| infra/scripts/* | Updated role assignments and new parameters for AI Foundry and AI Search. |
Roopan-Microsoft
changed the title
…from popup (#578) * feat: FDP changes, Updation to use AI agents (#571) * Implemented Log execution time per prompt in Report * updated readme * updated the code * added functions * feat: added fdp changes, updated to use ai agents instead of openai assistants (#566) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * refactor: couple of typo fix (#570) * initial bicep changes for fdp * update role assignments in bicep * feat: initial fdp changes for client advisor * updated post deployment scripts to use keyless authentication * rebuilt main.json * fix configuration handling and error checking in backend services * updated unit tests * Refactor code for improved readability and maintainability by organizing imports and formatting code blocks consistently across multiple files. * fix: correct variable names for managed identity and AI foundry in scripts and templates --------- Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> * bug fix(#19849) --------- Co-authored-by: Prajwal-Microsoft <[email protected]> Co-authored-by: Ragini-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]>
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
approved these changes
Jun 27, 2025
Priyanka-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Priyanka-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
approved these changes
Jun 27, 2025
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant updates to the deployment infrastructure and documentation, focusing on transitioning to a new "AI Foundry" resource model, updating API versions, and simplifying deployment configurations. Key changes include replacing the "AI Services" resource with "AI Foundry," revising related configurations, and removing unused parameters and resources.
Transition to AI Foundry Resource Model:
infra/deploy_ai_foundry.bicep, including new resource definitions foraiFoundry,aiFoundryProject, and associated connections. Updated resource properties to reflect the new model. [1] [2] [3]infra/abbreviations.jsonto include prefixes for "AI Foundry" (aiFoundryandaiFoundryProject).API Version Updates:
Azure OpenAI API Versionindocs/DeploymentGuide.mdto2025-04-01-preview.Microsoft.CognitiveServices/accountsandMicrosoft.Search/searchServices, to align with the latest previews. [1] [2]Deployment Configuration Simplifications:
infra/deploy_app_service.bicep, such asAzureOpenAIKey,AzureSearchKey, and SQL database credentials. [1] [2] [3]docs/DeploymentGuide.mdby adding new required parameters for AI Foundry and AI Search resources.Resource Cleanup and Refactoring:
infra/deploy_ai_foundry.bicep. [1] [2]Output and Role Assignment Updates:
infra/deploy_ai_foundry.bicepto reflect AI Foundry resources instead of AI Services.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information