fix: updated model capacity minimum to 200 #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum resource allocations for models to meet new capacity requirements.
- Bump
gpt-4o-minidefault capacity from 30 to 200 andtext-embedding-ada-002from 40 to 80 in the quota check script. - Align documentation examples in
docs/QuotaCheck.mdwith the new defaults. - Adjust CI workflow environment variables (
GPT_MIN_CAPACITY,TEXT_EMBEDDING_MIN_CAPACITY) in.github/workflows/CAdeploy.yml.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/scripts/quota_check_params.sh | Updated DEFAULT_MODEL_CAPACITY string to new thresholds |
| docs/QuotaCheck.md | Revised example commands and default values for capacities |
| .github/workflows/CAdeploy.yml | Lowered GPT_MIN_CAPACITY and increased TEXT_EMBEDDING_MIN_CAPACITY |
Comments suppressed due to low confidence (2)
docs/QuotaCheck.md:55
- The sample output section still shows the previous capacity values. Please update any example output to reflect the new default gpt-4o-mini capacity of 200.
### **Sample Output**
infra/scripts/quota_check_params.sh:50
- Consider adding or updating tests for
quota_check_params.shto verify that the script correctly parses and applies the new default capacities.
DEFAULT_MODEL_CAPACITY="gpt-4o-mini:200,text-embedding-ada-002:80"
Roopan-Microsoft
approved these changes
Jul 14, 2025
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Roopan-Microsoft
added a commit
that referenced
this pull request
Jul 17, 2025
* updated model capacity minimume to 200 (#602) * docs: Added file and images (#577) * Create exp.md * Add files via upload * Delete docs/images/re_use_log/exp.md * Add files via upload * Update CustomizingAzdParameters.md * Update DeploymentGuide.md add the section Reusing an Existing Log Analytics Workspace * Update re-use-log-analytics.md update the back link url and remove extra space --------- Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]> * docs: Add and update links for CustomizingAzdParameters.md and re-use-log-analytics.md (#606) * Update CustomizingAzdParameters.md Added link * Update re-use-log-analytics.md Updated link * fix: Increase retry attempts and improve error messaging for Azure Blob Storage uploads (#607) --------- Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Atulku-Microsoft <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates default model capacities and environment variables to align with new requirements for resource allocation. The most significant changes include increasing the capacity for
gpt-4o-miniand adjusting related documentation and scripts accordingly.Updates to model capacities:
.github/workflows/CAdeploy.yml: ReducedGPT_MIN_CAPACITYfrom 250 to 200 and increasedTEXT_EMBEDDING_MIN_CAPACITYfrom 40 to 80 in the workflow environment variables.infra/scripts/quota_check_params.sh: UpdatedDEFAULT_MODEL_CAPACITYto setgpt-4o-minicapacity to 200 (previously 30) while keepingtext-embedding-ada-002at 80.Documentation updates:
docs/QuotaCheck.md: Updated examples and default values to reflect the newgpt-4o-minicapacity of 200 in various usage scenarios. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information