fix: Increase retry attempts and improve error messaging for file upload script #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ob Storage uploads
Harsh-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR improves the retry mechanism for Azure Blob Storage file uploads by increasing retry attempts from 3 to 5, enhancing error messaging with attempt counters, and refining the retry logic to better handle upload failures.
- Increased maximum retry attempts from 3 to 5 for better resilience
- Enhanced logging to show current attempt number and wait time
- Fixed retry logic by removing duplicate sleep calls and adding proper failure handling
| if [ $? -ne 0 ]; then | ||
| retries=3 | ||
| maxRetries=5 | ||
| retries=$maxRetries |
There was a problem hiding this comment.
The retry logic is duplicated between two upload operations. Consider extracting this into a reusable function to reduce code duplication and improve maintainability.
Roopan-Microsoft
approved these changes
Jul 16, 2025
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Roopan-Microsoft
added a commit
that referenced
this pull request
Jul 17, 2025
* updated model capacity minimume to 200 (#602) * docs: Added file and images (#577) * Create exp.md * Add files via upload * Delete docs/images/re_use_log/exp.md * Add files via upload * Update CustomizingAzdParameters.md * Update DeploymentGuide.md add the section Reusing an Existing Log Analytics Workspace * Update re-use-log-analytics.md update the back link url and remove extra space --------- Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]> * docs: Add and update links for CustomizingAzdParameters.md and re-use-log-analytics.md (#606) * Update CustomizingAzdParameters.md Added link * Update re-use-log-analytics.md Updated link * fix: Increase retry attempts and improve error messaging for Azure Blob Storage uploads (#607) --------- Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Atulku-Microsoft <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request improves the retry mechanism for uploading files to Azure Blob Storage in the
infra/scripts/copy_kb_files.shscript. The changes increase the maximum retry attempts, enhance logging for better visibility, and refine the retry logic to handle failures more effectively.Enhancements to retry mechanism:
maxRetriesvariable added and used consistently)Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information