fix: merging dev changes to main branch #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tingpr fix: model deployment when reusing existing foundry
* fixed opent telemetry issue CustomDomainInUse, FlagMustBeSetForRestore (#618) (#619) Co-authored-by: VishalS-Microsoft <[email protected]> * directory update in dependabot template (#634) --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]>
* Agent deletion handled successfully * use get azure credentials * remove unused import --------- Co-authored-by: Shreyas-Microsoft <[email protected]>
feat: Add required environment variables for local debugging in .env generated by azd up
fix: Sample data processing script fails when using cross-subscription existing AI project resource ID
chore: Down merge from main to dev
ci: Fixed the Deployment Pipeline
docs: Update AZURE_LOCATION Parameter Description in Docs
chore: standardize parameter descriptions and naming conventions
docs: Azure Region Selection Updated in Deployment.Md Docs
Roopan-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Build-your-own-copilot-Solution-Accelerator infrastructure with improved agent management, better parameter handling, enhanced error handling, and documentation updates.
- Enhanced agent factory with better lifecycle management and logging
- Refactored Bicep templates to use standardized naming conventions and improved parameter validation
- Improved script parameter simplification and documentation updates
Reviewed Changes
Copilot reviewed 24 out of 28 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| chat_with_data_plugin.py | Enhanced agent initialization with improved thread cleanup and additional logging |
| agent_factory.py | Added SQL agent support and comprehensive error handling for agent deletion |
| app.py | Improved application lifecycle management with better error handling |
| main.bicep | Major refactoring with standardized naming, comprehensive outputs, and improved parameter documentation |
| Various deployment scripts | Parameter simplification and improved resource ID handling |
| Documentation files | Added new guide for reusing existing AI Foundry projects |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixed typo error. Co-authored-by: Copilot <[email protected]>
Prasanjeet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Updated the finally block for function "get_SQL_Response" Co-authored-by: Copilot <[email protected]>
Prasanjeet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Removed Commented-out code Co-authored-by: Copilot <[email protected]>
Prasanjeet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
`project_client` is always initialized before thread creation, so `if thread:` is sufficient.
Prasanjeet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Avijit-Microsoft
approved these changes
Aug 18, 2025
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Azure Deployment Workflow Improvements:
.github/workflows/CAdeploy.ymlfor clarity and consistency (e.g.,AI_FOUNDARY_NAME→AI_FOUNDRY_RESOURCE_ID,SQL_SERVER→SQL_SERVER_NAME) and adjusted related script references accordingly. [1] [2] [3] [4]environmentNametosolutionNamein the Bicep deployment step for clarity and alignment with template parameters.Documentation Enhancements:
docs/re-use-foundry-project.mddetailing how to reuse an existing Azure AI Foundry Project, and linked it from the deployment documentation. [1] [2]AZURE_LOCATIONindocs/CustomizingAzdParameters.mdanddocs/DeploymentGuide.mdto indicate that the user selects the region during deployment, improving accuracy. [1] [2]docs/LocalSetupAndDeploy.md, including information about automatic.envfile generation when usingazd.Bicep Template Improvements:
infra/core/database/cosmos/deploy_cosmos_db.bicepandinfra/core/database/cosmos/cosmos-role-assign.bicep, including marking parameters as required or optional and correcting typos. [1] [2]cosmosOutput) to the Cosmos DB deployment Bicep module, providing details of the deployed resources for downstream usage.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information