fix: Return correct response for total asset value #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, and the total value matches the asset value displayed in the left panel.
Prekshith-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Contributor
Author
|
@microsoft-github-policy-service agree |
Roopan-Microsoft
approved these changes
Sep 1, 2025
Roopan-Microsoft
added a commit
that referenced
this pull request
Sep 1, 2025
* model deployment when reusing existing foundry * change model deployment name * removed system managed identity code * seggregated the files * fix: Updated file names * chore: down merging main into dev (#638) * fixed opent telemetry issue CustomDomainInUse, FlagMustBeSetForRestore (#618) (#619) Co-authored-by: VishalS-Microsoft <[email protected]> * directory update in dependabot template (#634) --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> * added for cross-subscription existing AI project resource ID * update * fix: agent cleanup (#639) * Agent deletion handled successfully * use get azure credentials * remove unused import --------- Co-authored-by: Shreyas-Microsoft <[email protected]> * TS( 21657) Bicep Standard code changes * Added required env variables for local debugging in .env generated by azd up * Added "Required/Optional" and changed aiProjectName suffix. * removed location tag * foundry project documentation * corrected name * updated CAdeploy.yml * update CAdeploy.yml * changed pipeline variable * updated main.json file * updated yml file * test * test * update * update * test * update CAdeploy.yml * CustomizingAzdparamMd * deploymentMdUpdate * Updated * Update infra/main.bicep Fixed typo error. Co-authored-by: Copilot <[email protected]> * Update src/App/backend/plugins/chat_with_data_plugin.py Updated the finally block for function "get_SQL_Response" Co-authored-by: Copilot <[email protected]> * Update infra/main.bicep Removed Commented-out code Co-authored-by: Copilot <[email protected]> * Revert Copilot suggestion: `and project_client` is unnecessary. `project_client` is always initialized before thread creation, so `if thread:` is sufficient. * docs: Added Troubleshoot.md files for BYOC-Client Advisor (#650) * Added Troubleshoot.md files for BYOC-Client Advisor * fixed Check Markdown Broken Links * updated troubleshotingsteps file * Changed MACAE Github issues link with BYOC issue link --------- Co-authored-by: NirajC-Microsoft <[email protected]> * added colon Co-authored-by: Copilot <[email protected]> * Replace 'u' with 'you' for proper grammarUpdate docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * extra space removed Co-authored-by: Copilot <[email protected]> * The command block is not properly closed Co-authored-by: Copilot <[email protected]> * The command should be wrapped in a proper code block with language identifier for better formatting and readability. Co-authored-by: Copilot <[email protected]> * The total asset value and current asset value are responding correctly, and the total value matches the asset value displayed in the left panel. (#651) --------- Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Prajwal D C <[email protected]> Co-authored-by: Rafi-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Kanchan Nagshetti (Persistent Systems Inc) <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Prekshith-Microsoft <[email protected]>
Roopan-Microsoft
added a commit
that referenced
this pull request
Sep 5, 2025
* model deployment when reusing existing foundry * change model deployment name * removed system managed identity code * seggregated the files * fix: Updated file names * chore: down merging main into dev (#638) * fixed opent telemetry issue CustomDomainInUse, FlagMustBeSetForRestore (#618) (#619) Co-authored-by: VishalS-Microsoft <[email protected]> * directory update in dependabot template (#634) --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> * added for cross-subscription existing AI project resource ID * update * fix: agent cleanup (#639) * Agent deletion handled successfully * use get azure credentials * remove unused import --------- Co-authored-by: Shreyas-Microsoft <[email protected]> * TS( 21657) Bicep Standard code changes * Added required env variables for local debugging in .env generated by azd up * Added "Required/Optional" and changed aiProjectName suffix. * removed location tag * foundry project documentation * corrected name * updated CAdeploy.yml * update CAdeploy.yml * changed pipeline variable * updated main.json file * updated yml file * test * test * update * update * test * update CAdeploy.yml * CustomizingAzdparamMd * deploymentMdUpdate * Updated * Update infra/main.bicep Fixed typo error. Co-authored-by: Copilot <[email protected]> * Update src/App/backend/plugins/chat_with_data_plugin.py Updated the finally block for function "get_SQL_Response" Co-authored-by: Copilot <[email protected]> * Update infra/main.bicep Removed Commented-out code Co-authored-by: Copilot <[email protected]> * Revert Copilot suggestion: `and project_client` is unnecessary. `project_client` is always initialized before thread creation, so `if thread:` is sufficient. * docs: Added Troubleshoot.md files for BYOC-Client Advisor (#650) * Added Troubleshoot.md files for BYOC-Client Advisor * fixed Check Markdown Broken Links * updated troubleshotingsteps file * Changed MACAE Github issues link with BYOC issue link --------- Co-authored-by: NirajC-Microsoft <[email protected]> * added colon Co-authored-by: Copilot <[email protected]> * Replace 'u' with 'you' for proper grammarUpdate docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * extra space removed Co-authored-by: Copilot <[email protected]> * The command block is not properly closed Co-authored-by: Copilot <[email protected]> * The command should be wrapped in a proper code block with language identifier for better formatting and readability. Co-authored-by: Copilot <[email protected]> * The total asset value and current asset value are responding correctly, and the total value matches the asset value displayed in the left panel. (#651) * Bicep file changes to add CreatedBy tag (#655) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * fix: Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file. (#659) * Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file. * Consolidate parameters in CAdeploy.yml --------- Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Prajwal D C <[email protected]> Co-authored-by: Rafi-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Kanchan Nagshetti (Persistent Systems Inc) <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Prekshith-Microsoft <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]>
Roopan-Microsoft
added a commit
that referenced
this pull request
Sep 8, 2025
* model deployment when reusing existing foundry * change model deployment name * removed system managed identity code * seggregated the files * fix: Updated file names * chore: down merging main into dev (#638) * fixed opent telemetry issue CustomDomainInUse, FlagMustBeSetForRestore (#618) (#619) Co-authored-by: VishalS-Microsoft <[email protected]> * directory update in dependabot template (#634) --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> * added for cross-subscription existing AI project resource ID * update * fix: agent cleanup (#639) * Agent deletion handled successfully * use get azure credentials * remove unused import --------- Co-authored-by: Shreyas-Microsoft <[email protected]> * TS( 21657) Bicep Standard code changes * Added required env variables for local debugging in .env generated by azd up * Added "Required/Optional" and changed aiProjectName suffix. * removed location tag * foundry project documentation * corrected name * updated CAdeploy.yml * update CAdeploy.yml * changed pipeline variable * updated main.json file * updated yml file * test * test * update * update * test * update CAdeploy.yml * CustomizingAzdparamMd * deploymentMdUpdate * Updated * Update infra/main.bicep Fixed typo error. Co-authored-by: Copilot <[email protected]> * Update src/App/backend/plugins/chat_with_data_plugin.py Updated the finally block for function "get_SQL_Response" Co-authored-by: Copilot <[email protected]> * Update infra/main.bicep Removed Commented-out code Co-authored-by: Copilot <[email protected]> * Revert Copilot suggestion: `and project_client` is unnecessary. `project_client` is always initialized before thread creation, so `if thread:` is sufficient. * docs: Added Troubleshoot.md files for BYOC-Client Advisor (#650) * Added Troubleshoot.md files for BYOC-Client Advisor * fixed Check Markdown Broken Links * updated troubleshotingsteps file * Changed MACAE Github issues link with BYOC issue link --------- Co-authored-by: NirajC-Microsoft <[email protected]> * added colon Co-authored-by: Copilot <[email protected]> * Replace 'u' with 'you' for proper grammarUpdate docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * extra space removed Co-authored-by: Copilot <[email protected]> * The command block is not properly closed Co-authored-by: Copilot <[email protected]> * The command should be wrapped in a proper code block with language identifier for better formatting and readability. Co-authored-by: Copilot <[email protected]> * The total asset value and current asset value are responding correctly, and the total value matches the asset value displayed in the left panel. (#651) * Bicep file changes to add CreatedBy tag (#655) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * fix: Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file. (#659) * Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file. * Consolidate parameters in CAdeploy.yml --------- Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Prajwal D C <[email protected]> Co-authored-by: Rafi-Microsoft <[email protected]> Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Kanchan Nagshetti (Persistent Systems Inc) <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Prekshith-Microsoft <[email protected]>
Roopan-Microsoft
added a commit
that referenced
this pull request
Sep 17, 2025
* chore: Dev to Main changes merge (#657) * model deployment when reusing existing foundry * change model deployment name * removed system managed identity code * seggregated the files * fix: Updated file names * chore: down merging main into dev (#638) * fixed opent telemetry issue CustomDomainInUse, FlagMustBeSetForRestore (#618) (#619) Co-authored-by: VishalS-Microsoft <[email protected]> * directory update in dependabot template (#634) --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> * added for cross-subscription existing AI project resource ID * update * fix: agent cleanup (#639) * Agent deletion handled successfully * use get azure credentials * remove unused import --------- Co-authored-by: Shreyas-Microsoft <[email protected]> * TS( 21657) Bicep Standard code changes * Added required env variables for local debugging in .env generated by azd up * Added "Required/Optional" and changed aiProjectName suffix. * removed location tag * foundry project documentation * corrected name * updated CAdeploy.yml * update CAdeploy.yml * changed pipeline variable * updated main.json file * updated yml file * test * test * update * update * test * update CAdeploy.yml * CustomizingAzdparamMd * deploymentMdUpdate * Updated * Update infra/main.bicep Fixed typo error. Co-authored-by: Copilot <[email protected]> * Update src/App/backend/plugins/chat_with_data_plugin.py Updated the finally block for function "get_SQL_Response" Co-authored-by: Copilot <[email protected]> * Update infra/main.bicep Removed Commented-out code Co-authored-by: Copilot <[email protected]> * Revert Copilot suggestion: `and project_client` is unnecessary. `project_client` is always initialized before thread creation, so `if thread:` is sufficient. * docs: Added Troubleshoot.md files for BYOC-Client Advisor (#650) * Added Troubleshoot.md files for BYOC-Client Advisor * fixed Check Markdown Broken Links * updated troubleshotingsteps file * Changed MACAE Github issues link with BYOC issue link --------- Co-authored-by: NirajC-Microsoft <[email protected]> * added colon Co-authored-by: Copilot <[email protected]> * Replace 'u' with 'you' for proper grammarUpdate docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * extra space removed Co-authored-by: Copilot <[email protected]> * The command block is not properly closed Co-authored-by: Copilot <[email protected]> * The command should be wrapped in a proper code block with language identifier for better formatting and readability. Co-authored-by: Copilot <[email protected]> * The total asset value and current asset value are responding correctly, and the total value matches the asset value displayed in the left panel. (#651) * Bicep file changes to add CreatedBy tag (#655) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * fix: Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file. (#659) * Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file. * Consolidate parameters in CAdeploy.yml --------- Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Prajwal D C <[email protected]> Co-authored-by: Rafi-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Kanchan Nagshetti (Persistent Systems Inc) <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Prekshith-Microsoft <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> * fix: merging dev to main changes (#661) * model deployment when reusing existing foundry * change model deployment name * removed system managed identity code * seggregated the files * fix: Updated file names * chore: down merging main into dev (#638) * fixed opent telemetry issue CustomDomainInUse, FlagMustBeSetForRestore (#618) (#619) Co-authored-by: VishalS-Microsoft <[email protected]> * directory update in dependabot template (#634) --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> * added for cross-subscription existing AI project resource ID * update * fix: agent cleanup (#639) * Agent deletion handled successfully * use get azure credentials * remove unused import --------- Co-authored-by: Shreyas-Microsoft <[email protected]> * TS( 21657) Bicep Standard code changes * Added required env variables for local debugging in .env generated by azd up * Added "Required/Optional" and changed aiProjectName suffix. * removed location tag * foundry project documentation * corrected name * updated CAdeploy.yml * update CAdeploy.yml * changed pipeline variable * updated main.json file * updated yml file * test * test * update * update * test * update CAdeploy.yml * CustomizingAzdparamMd * deploymentMdUpdate * Updated * Update infra/main.bicep Fixed typo error. Co-authored-by: Copilot <[email protected]> * Update src/App/backend/plugins/chat_with_data_plugin.py Updated the finally block for function "get_SQL_Response" Co-authored-by: Copilot <[email protected]> * Update infra/main.bicep Removed Commented-out code Co-authored-by: Copilot <[email protected]> * Revert Copilot suggestion: `and project_client` is unnecessary. `project_client` is always initialized before thread creation, so `if thread:` is sufficient. * docs: Added Troubleshoot.md files for BYOC-Client Advisor (#650) * Added Troubleshoot.md files for BYOC-Client Advisor * fixed Check Markdown Broken Links * updated troubleshotingsteps file * Changed MACAE Github issues link with BYOC issue link --------- Co-authored-by: NirajC-Microsoft <[email protected]> * added colon Co-authored-by: Copilot <[email protected]> * Replace 'u' with 'you' for proper grammarUpdate docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * extra space removed Co-authored-by: Copilot <[email protected]> * The command block is not properly closed Co-authored-by: Copilot <[email protected]> * The command should be wrapped in a proper code block with language identifier for better formatting and readability. Co-authored-by: Copilot <[email protected]> * The total asset value and current asset value are responding correctly, and the total value matches the asset value displayed in the left panel. (#651) * Bicep file changes to add CreatedBy tag (#655) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * fix: Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file. (#659) * Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file. * Consolidate parameters in CAdeploy.yml --------- Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Prajwal D C <[email protected]> Co-authored-by: Rafi-Microsoft <[email protected]> Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Kanchan Nagshetti (Persistent Systems Inc) <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Prekshith-Microsoft <[email protected]> * fixed vulnerabilities * removed duplicate variable --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Prajwal D C <[email protected]> Co-authored-by: Rafi-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Shreyas-Microsoft <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Prekshith-Microsoft <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]>
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request clarifies how asset value queries should be handled in both the T-SQL prompt instructions and the SQL agent system prompt. Specifically, it distinguishes between questions about total asset values (which should use SUM) and questions about current values (which should return the latest investments without summing).
Prompt instruction updates:
functionAppSqlPromptininfra/main.bicepto specify that questions about total "asset value"/"portfolio value"/"AUM" should return the SUM of latest investments, while questions about "current asset/investment value" should return all latest investments without SUM.agent_factory.pyto include the same clarification on handling asset value queries.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information