-
Notifications
You must be signed in to change notification settings - Fork 158
fix: Return consistent response for 'what is the asset value' query. #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tingpr fix: model deployment when reusing existing foundry
* fixed opent telemetry issue CustomDomainInUse, FlagMustBeSetForRestore (#618) (#619) Co-authored-by: VishalS-Microsoft <[email protected]> * directory update in dependabot template (#634) --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]>
* Agent deletion handled successfully * use get azure credentials * remove unused import --------- Co-authored-by: Shreyas-Microsoft <[email protected]>
feat: Add required environment variables for local debugging in .env generated by azd up
fix: Sample data processing script fails when using cross-subscription existing AI project resource ID
chore: Down merge from main to dev
docs: Update AZURE_LOCATION Parameter Description in Docs
chore: standardize parameter descriptions and naming conventions
docs: Azure Region Selection Updated in Deployment.Md Docs
Fixed typo error. Co-authored-by: Copilot <[email protected]>
Updated the finally block for function "get_SQL_Response" Co-authored-by: Copilot <[email protected]>
Removed Commented-out code Co-authored-by: Copilot <[email protected]>
`project_client` is always initialized before thread creation, so `if thread:` is sufficient.
* Added Troubleshoot.md files for BYOC-Client Advisor * fixed Check Markdown Broken Links * updated troubleshotingsteps file * Changed MACAE Github issues link with BYOC issue link --------- Co-authored-by: NirajC-Microsoft <[email protected]>
Co-authored-by: Copilot <[email protected]>
…teps.md Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…entifier for better formatting and readability. Co-authored-by: Copilot <[email protected]>
…y, and the total value matches the asset value displayed in the left panel. (#651)
Co-authored-by: Copilot <[email protected]>
…to prevent validation pipeline failures caused by the deployer function in the Bicep file. (#659) * Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file. * Consolidate parameters in CAdeploy.yml
…at is the asset value' question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes asset value query logic to ensure consistent responses, adds resource tagging for deployment traceability, and corrects a minor documentation typo. The changes improve query instruction clarity, enhance infrastructure deployment tracking, and fix documentation accuracy.
- Clarified T-SQL query instructions for asset value calculations to ensure consistent behavior
- Added
createdByparameter for resource tagging to improve deployment traceability - Fixed typo in troubleshooting documentation from "ParentResourceNotfound" to "ParentResourceNotFound"
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/App/backend/agents/agent_factory.py | Updated SQL agent instructions for clearer asset value query logic |
| infra/main.bicep | Added createdBy parameter and improved asset value query instructions |
| docs/TroubleShootingSteps.md | Fixed typo in error name for better documentation accuracy |
| .github/workflows/CAdeploy.yml | Added createdBy parameter to deployment pipeline |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Purpose
This pull request introduces improvements to asset value query instructions, adds a new
createdByparameter for resource tagging, and makes a minor documentation correction. The changes enhance clarity and traceability in both infrastructure deployment and SQL query generation.Asset value query logic improvements:
infra/main.bicepandsrc/App/backend/agents/agent_factory.pyhave been clarified. The guidance now explicitly states to always return the SUM of the latest investments for total asset value questions, and to return all latest investments without summing for current asset/investment value questions. This helps ensure more accurate and consistent query responses. [1] [2]Resource tagging enhancements:
createdByparameter is introduced ininfra/main.bicep, which captures the deployer's username and adds it as aCreatedBytag to resource groups. This improves traceability of deployments..github/workflows/CAdeploy.ymlnow passes thecreatedByparameter during resource group creation, ensuring the tag is set during automated deployments.Documentation update:
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information