Skip to content

Conversation

@Prekshith-Microsoft
Copy link
Contributor

Purpose

This pull request introduces improvements to asset value query instructions, adds a new createdBy parameter for resource tagging, and makes a minor documentation correction. The changes enhance clarity and traceability in both infrastructure deployment and SQL query generation.

Asset value query logic improvements:

  • The instructions for generating T-SQL queries in both infra/main.bicep and src/App/backend/agents/agent_factory.py have been clarified. The guidance now explicitly states to always return the SUM of the latest investments for total asset value questions, and to return all latest investments without summing for current asset/investment value questions. This helps ensure more accurate and consistent query responses. [1] [2]

Resource tagging enhancements:

  • A new createdBy parameter is introduced in infra/main.bicep, which captures the deployer's username and adds it as a CreatedBy tag to resource groups. This improves traceability of deployments.
  • The deployment pipeline in .github/workflows/CAdeploy.yml now passes the createdBy parameter during resource group creation, ensuring the tag is set during automated deployments.

Documentation update:

  • A typo in the troubleshooting documentation was fixed, correcting "ParentResourceNotfound" to "ParentResourceNotFound" for better clarity and alignment with Azure documentation.
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Priyanka-Microsoft and others added 30 commits July 25, 2025 13:41
…tingpr

fix: model deployment when reusing existing foundry
* fixed opent telemetry issue CustomDomainInUse, FlagMustBeSetForRestore (#618) (#619)

Co-authored-by: VishalS-Microsoft <[email protected]>

* directory update in dependabot template (#634)

---------

Co-authored-by: NirajC-Microsoft <[email protected]>
Co-authored-by: VishalS-Microsoft <[email protected]>
Co-authored-by: Prajwal-Microsoft <[email protected]>
* Agent deletion handled successfully

* use get azure credentials

* remove unused import

---------

Co-authored-by: Shreyas-Microsoft <[email protected]>
feat: Add required environment variables for local debugging in .env generated by azd up
fix: Sample data processing script fails when using cross-subscription existing AI project resource ID
chore: Down merge from main to dev
Prajwal-Microsoft and others added 22 commits August 13, 2025 14:30
docs: Update AZURE_LOCATION Parameter Description in Docs
chore: standardize parameter descriptions and naming conventions
docs: Azure Region Selection Updated in Deployment.Md Docs
Fixed typo error.

Co-authored-by: Copilot <[email protected]>
Updated the finally block for function "get_SQL_Response"

Co-authored-by: Copilot <[email protected]>
Removed Commented-out code

Co-authored-by: Copilot <[email protected]>
`project_client` is always initialized before thread creation, so `if thread:` is sufficient.
* Added Troubleshoot.md files for BYOC-Client Advisor

* fixed Check Markdown Broken Links

* updated troubleshotingsteps file

* Changed MACAE Github issues link with BYOC issue link

---------

Co-authored-by: NirajC-Microsoft <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…entifier for better formatting and readability.

Co-authored-by: Copilot <[email protected]>
…y, and the total value matches the asset value displayed in the left panel. (#651)
…to prevent validation pipeline failures caused by the deployer function in the Bicep file. (#659)

* Adding a hardcoded createdBy parameter to the CAdeploy.yml file to prevent validation pipeline failures caused by the deployer function in the Bicep file.

* Consolidate parameters in CAdeploy.yml
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes asset value query logic to ensure consistent responses, adds resource tagging for deployment traceability, and corrects a minor documentation typo. The changes improve query instruction clarity, enhance infrastructure deployment tracking, and fix documentation accuracy.

  • Clarified T-SQL query instructions for asset value calculations to ensure consistent behavior
  • Added createdBy parameter for resource tagging to improve deployment traceability
  • Fixed typo in troubleshooting documentation from "ParentResourceNotfound" to "ParentResourceNotFound"

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/App/backend/agents/agent_factory.py Updated SQL agent instructions for clearer asset value query logic
infra/main.bicep Added createdBy parameter and improved asset value query instructions
docs/TroubleShootingSteps.md Fixed typo in error name for better documentation accuracy
.github/workflows/CAdeploy.yml Added createdBy parameter to deployment pipeline

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.