-
Notifications
You must be signed in to change notification settings - Fork 158
fix: added tags in CAdeploy.yml file #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
fix: Dev to main merge
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roopan-Microsoft
approved these changes
Sep 22, 2025
Roopan-Microsoft
pushed a commit
that referenced
this pull request
Sep 29, 2025
* fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]>
Roopan-Microsoft
pushed a commit
that referenced
this pull request
Oct 1, 2025
…emoved the unsued params (#690) * fix: Dev to main (#681) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> * fix: Removed commented params * Update README and azure.yml for minimum azd version 1.18.0 --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Prajwal D C <[email protected]>
Roopan-Microsoft
added a commit
that referenced
this pull request
Oct 3, 2025
…on & updated docs (#692) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Create new Managed Identity for SQL operations with least privileges * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * Update GitHub Issues link in troubleshooting steps * removed SQL user assigned identity from key vault and SQL DB module * Refactor DNS zone naming and update SQL database redundancy settings * fix pylint issues * refactor: Update README, azure.yml for minimum azd version 1.18.0 & removed the unsued params (#690) * fix: Dev to main (#681) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> * fix: Removed commented params * Update README and azure.yml for minimum azd version 1.18.0 --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Prajwal D C <[email protected]> * Update Azure template validation action to latest version * Update azure-dev.yml * Update azure-dev.yml * Chore: Disable Dev Container usage in Azure validation step Disable the use of Dev Container for Azure template validation. * chore: Refactor Azure DevOps workflow configuration * fix: Rename main.bicep for network module * chore: Update Azure template validation action version * chore: Add validateTests parameter to Azure Dev workflow * chore: Update Azure template validation action version * fix post deployment script to support exp * refactor: Comments fixed --------- Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Vamshi-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]>
|
🎉 This PR is included in version 1.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to both deployment automation and end-to-end test reliability. The most significant update is the enhancement of resource group creation in the Azure deployment workflow, which now adds detailed tagging for better resource management. Additionally, the test automation script has been refined to optimize wait times, improving test stability and efficiency.
Deployment workflow enhancements:
CreatedBy,Purpose,CreatedDate,ApplicationName, andSecurityControl) when creating the Azure resource group in.github/workflows/CAdeploy.ymlto improve resource tracking and lifecycle management.CreatedDate) in ISO format for resource group creation to aid in auditing and lifecycle operations.Test automation improvements:
delete_chat_historymethod ofhomePage.pyto optimize the flow and improve reliability of UI interactions, reducing unnecessary delays and ensuring actions complete as expected.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information