-
Notifications
You must be signed in to change notification settings - Fork 158
fix: Dev to main #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dev to main #681
Conversation
* CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps
… bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces comprehensive documentation enhancements, deployment improvements, and testing reliability fixes. The primary focus is on expanding troubleshooting guidance and adding container registry management documentation.
- Enhanced troubleshooting documentation with 15+ new error scenarios and improved existing error descriptions
- Added new ACR Build and Push Guide for Docker image management
- Improved deployment tagging and metadata in CI/CD workflows and infrastructure templates
- Fixed end-to-end test timing issues for better reliability
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/TroubleShootingSteps.md | Expanded troubleshooting guide with new Azure deployment errors and improved existing error descriptions |
| docs/ACRBuildAndPushGuide.md | New comprehensive guide for building and pushing Docker images to Azure Container Registry |
| .github/workflows/CAdeploy.yml | Added timestamp-based tagging to deployments for better traceability |
| infra/main.bicep | Improved tag logic for created by user and template name based on networking configuration |
| tests/e2e-test/pages/homePage.py | Adjusted wait times in delete chat history test for better reliability |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…emoved the unsued params (#690) * fix: Dev to main (#681) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> * fix: Removed commented params * Update README and azure.yml for minimum azd version 1.18.0 --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Prajwal D C <[email protected]>
…on & updated docs (#692) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Create new Managed Identity for SQL operations with least privileges * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * Update GitHub Issues link in troubleshooting steps * removed SQL user assigned identity from key vault and SQL DB module * Refactor DNS zone naming and update SQL database redundancy settings * fix pylint issues * refactor: Update README, azure.yml for minimum azd version 1.18.0 & removed the unsued params (#690) * fix: Dev to main (#681) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> * fix: Removed commented params * Update README and azure.yml for minimum azd version 1.18.0 --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Prajwal D C <[email protected]> * Update Azure template validation action to latest version * Update azure-dev.yml * Update azure-dev.yml * Chore: Disable Dev Container usage in Azure validation step Disable the use of Dev Container for Azure template validation. * chore: Refactor Azure DevOps workflow configuration * fix: Rename main.bicep for network module * chore: Update Azure template validation action version * chore: Add validateTests parameter to Azure Dev workflow * chore: Update Azure template validation action version * fix post deployment script to support exp * refactor: Comments fixed --------- Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Vamshi-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]>
|
🎉 This PR is included in version 1.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
This pull request introduces several documentation enhancements and deployment improvements, primarily focusing on expanding troubleshooting guidance, adding a new guide for Azure Container Registry (ACR) image management, and improving tagging and metadata in deployment scripts and infrastructure templates. Additionally, minor improvements were made to end-to-end tests for better reliability.
Documentation Enhancements:
ACRBuildAndPushGuide.mdthat provides step-by-step instructions for building and pushing Docker images to Azure Container Registry, including prerequisites, build/push commands, and manual image update steps for both Backend and WebApp services.TroubleShootingSteps.mdwith new troubleshooting entries for a wide range of Azure deployment errors (e.g.,InvalidRequestContent,ReadOnlyDisabledSubscription,SkuNotAvailable,PrincipalNotFound,RedundancyConfigurationNotAvailable, etc.), including detailed causes, resolutions, and relevant documentation links. Also improved clarity and accuracy in existing error explanations and updated support links. [1] [2] [3] [4] [5] F9d75360L321, F9d75360L352)Deployment and Infrastructure Improvements:
.github/workflows/CAdeploy.ymlto add timestamp-based tagging to deployments, improving traceability by including aCreatedDatetag with each deployment.infra/main.biceptemplate to improve the logic for thecreatedBytag, using the user principal name if available, otherwise falling back to the object ID, and updated theTemplateNametag to reflect whether private networking is enabled.Testing Improvements:
delete_chat_historyend-to-end test by adjusting wait times for UI actions to better accommodate asynchronous UI updates.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information