refactor: Removed commented params #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]>
Prajwal-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Prajwal-Microsoft
merged commit 68a0936
into
psl-Azd-version-update
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several documentation improvements, workflow enhancements, and infrastructure updates to make Azure deployments more robust and user-friendly. The most notable changes include expanding troubleshooting guidance for deployment errors, adding a comprehensive guide for building and pushing container images to Azure Container Registry (ACR), and improving resource tagging and metadata handling in deployment templates.
Documentation enhancements:
docs/TroubleShootingSteps.md, covering new error types such asInvalidRequestContent,ReadOnlyDisabledSubscription,SkuNotAvailable,CrossTenantDeploymentNotPermitted,RequestDisallowedByPolicy,FlagMustBeSetForRestore,PrincipalNotFound,RedundancyConfigurationNotAvailableInRegion,DeploymentNotFound,DeploymentCanceled,ResourceGroupDeletionTimeout,SubscriptionDoesNotHaveServer,BadRequestfor failed provisioning,SpecialFeatureOrQuotaIdRequired, andContainerAppOperationError. Each error includes actionable resolution steps and relevant Microsoft documentation links. [1] [2] [3] [4]docs/ACRBuildAndPushGuide.mdfile with step-by-step instructions for building and pushing Docker images for WebApp and Backend services to Azure Container Registry, including manual update steps and verification commands.Infrastructure and workflow improvements:
.github/workflows/CAdeploy.yml, added logic to generate a UTC timestamp for resource tagging, and enhanced deployment parameters to include detailed tags for security, purpose, and creation date.infra/main.bicepandinfra/main.jsonto improve resource tagging: thecreatedByparameter now captures either the username or object ID based on context, and a newTypetag distinguishes between WAF and Non-WAF deployments. Metadata descriptions were also clarified. [1] [2] [3]Minor cleanups:
infra/main.bicepfor clarity. [1] [2] [3]infra/main.jsonto reflect the latest changes.These changes collectively improve deployment reliability, make troubleshooting easier, and provide clearer guidance for working with Azure resources.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information