Skip to content

fix: Quota unavailability handling in quotacheck pipeline #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

fix: Quota unavailability handling in quotacheck pipeline #701

merged 1 commit into from
Oct 10, 2025

Conversation

@NirajC-Microsoft
Copy link
Contributor

@NirajC-Microsoft NirajC-Microsoft commented Oct 8, 2025

Purpose

This pull request introduces significant improvements to the post-deployment experience and resource management for the Build Your Own Copilot Accelerator. The main changes include the addition of a comprehensive post-deployment guide, enhanced automation and robustness in sample data processing scripts, and updates to resource tagging and output management in the deployment templates.

Documentation Enhancements:

  • Added a new AVM Post Deployment Guide (docs/AVMPostDeploymentGuide.md) that provides clear, step-by-step instructions for post-deployment actions, including cloning the repo, importing sample data, configuring authentication, and cleaning up resources after failed deployments.

Sample Data Processing Automation:

  • Refactored process_sample_data.sh to automatically fetch resource names and deployment outputs from Azure deployment metadata, reducing manual input and improving reliability. The script now authenticates with Azure CLI if needed and retrieves all necessary variables from deployment outputs or prompts the user only if the deployment does not exist. [1] [2]
  • Cleaned up unused script arguments and improved handling of global variables for network access states and SQL public access, streamlining the script and reducing potential errors.

Infrastructure and Resource Tagging:

  • Added a DeploymentName tag to resource groups in main.bicep, enabling easier identification and management of deployments.

Output Management:

  • Removed the output of the managed identity client ID from main.bicep, likely for security or simplification purposes.

Quota Checking Script Robustness:

  • Improved the quota checking script (checkquota.sh) to more reliably flag insufficient quota scenarios, enhancing deployment validation.
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 6678b91 into dev Oct 10, 2025
5 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-quotacheckfix-fix-byoc branch October 10, 2025 05:14
Roopan-Microsoft pushed a commit that referenced this pull request Oct 13, 2025
@NirajC-Microsoft @Prajwal-Microsoft @Prekshith-Microsoft
fix: Dev to main (#706)
c6d8703 
* post deployment script changes

* Updated the network module

* script fix

* update azure.yml

* fix script 1

* Quotacheck fix (#701)

---------

Co-authored-by: Prajwal-Microsoft <[email protected]>
Co-authored-by: Prekshith D J (Persistent Systems Inc) <[email protected]>
Roopan-Microsoft pushed a commit that referenced this pull request Oct 20, 2025
@Dhruvkumar-Microsoft @NirajC-Microsoft
@Prajwal-Microsoft @Prekshith-Microsoft
fix: Dev to main merge (#712)
80b9638 
* post deployment script changes

* Updated the network module

* script fix

* update azure.yml

* fix script 1

* Quotacheck fix (#701)

* Add AZURE_DEV_COLLECT_TELEMETRY variable in azure-dev.yml file (#711)

---------

Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]>
Co-authored-by: Prajwal-Microsoft <[email protected]>
Co-authored-by: Prekshith D J (Persistent Systems Inc) <[email protected]>
Roopan-Microsoft added a commit that referenced this pull request Oct 27, 2025
@Roopan-Microsoft @NirajC-Microsoft
@Prajwal-Microsoft @Prekshith-Microsoft @Vemarthula-Microsoft @dependabot
fix: Merging dev changes to main branch (#715)
389c741 
* post deployment script changes

* Updated the network module

* script fix

* update azure.yml

* fix script 1

* Quotacheck fix (#701)

* Add AZURE_DEV_COLLECT_TELEMETRY variable in azure-dev.yml file (#711)

* fix: Validate and fix the dependabot changes & latest Version Upgrade (#717)

* build: bump the backend-deps group in /src/App with 18 updates

---
updated-dependencies:
- dependency-name: azure-identity
  dependency-version: 1.23.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: openai
  dependency-version: 1.98.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: azure-storage-blob
  dependency-version: 12.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: python-dotenv
  dependency-version: 1.1.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: uvicorn
  dependency-version: 0.35.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: aiohttp
  dependency-version: 3.12.15
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: pymssql
  dependency-version: 2.3.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: backend-deps
- dependency-name: flake8
  dependency-version: 7.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: isort
  dependency-version: 6.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: backend-deps
- dependency-name: pytest-asyncio
  dependency-version: 1.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: backend-deps
- dependency-name: pytest-cov
  dependency-version: 6.2.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: backend-deps
- dependency-name: azure-search-documents
  dependency-version: 11.6.0b12
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: backend-deps
- dependency-name: azure-ai-projects
  dependency-version: 1.0.0
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: backend-deps
- dependency-name: opentelemetry-sdk
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: opentelemetry-api
  dependency-version: 1.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: opentelemetry-semantic-conventions
  dependency-version: 0.57b0
  dependency-type: direct:production
  dependency-group: backend-deps
- dependency-name: opentelemetry-instrumentation
  dependency-version: 0.57b0
  dependency-type: direct:production
  dependency-group: backend-deps
- dependency-name: azure-monitor-opentelemetry
  dependency-version: 1.6.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: backend-deps
...

Signed-off-by: dependabot[bot] <[email protected]>

* build: bump msal

Bumps the backend-deps group in /infra/scripts/fabric_scripts with 1 update: [msal](https://github.com/AzureAD/microsoft-authentication-library-for-python).


Updates `msal` from 1.31.1 to 1.33.0
- [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-python/releases)
- [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/dev/RELEASES.md)
- [Commits](AzureAD/microsoft-authentication-library-for-python@1.31.1...1.33.0)

---
updated-dependencies:
- dependency-name: msal
  dependency-version: 1.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
...

Signed-off-by: dependabot[bot] <[email protected]>

* build: bump openai in /src/App in the backend-deps group

Bumps the backend-deps group in /src/App with 1 update: [openai](https://github.com/openai/openai-python).


Updates `openai` from 1.98.0 to 1.99.1
- [Release notes](https://github.com/openai/openai-python/releases)
- [Changelog](https://github.com/openai/openai-python/blob/main/CHANGELOG.md)
- [Commits](openai/openai-python@v1.98.0...v1.99.1)

---
updated-dependencies:
- dependency-name: openai
  dependency-version: 1.99.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
...

Signed-off-by: dependabot[bot] <[email protected]>

* build: bump the backend-deps group

Bumps the backend-deps group in /infra/scripts/index_scripts with 2 updates: [msal[broker]](https://github.com/AzureAD/microsoft-authentication-library-for-python) and [azure-search-documents](https://github.com/Azure/azure-sdk-for-python).


Updates `msal[broker]` from 1.31.1 to 1.33.0
- [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-python/releases)
- [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/dev/RELEASES.md)
- [Commits](AzureAD/microsoft-authentication-library-for-python@1.31.1...1.33.0)

Updates `azure-search-documents` from 11.6.0b9 to 11.6.0b12
- [Release notes](https://github.com/Azure/azure-sdk-for-python/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/search/azure-search-documents/CHANGELOG.md)
- [Commits](Azure/azure-sdk-for-python@azure-search-documents_11.6.0b9...azure-search-documents_11.6.0b12)

---
updated-dependencies:
- dependency-name: msal[broker]
  dependency-version: 1.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: azure-search-documents
  dependency-version: 11.6.0b12
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: backend-deps
...

Signed-off-by: dependabot[bot] <[email protected]>

* build: bump the backend-deps group in /src/App with 3 updates

Bumps the backend-deps group in /src/App with 3 updates: [azure-identity](https://github.com/Azure/azure-sdk-for-python), [openai](https://github.com/openai/openai-python) and [azure-monitor-opentelemetry](https://github.com/Azure/azure-sdk-for-python).


Updates `azure-identity` from 1.23.1 to 1.24.0
- [Release notes](https://github.com/Azure/azure-sdk-for-python/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/esrp_release.md)
- [Commits](Azure/azure-sdk-for-python@azure-identity_1.23.1...azure-identity_1.24.0)

Updates `openai` from 1.99.1 to 1.102.0
- [Release notes](https://github.com/openai/openai-python/releases)
- [Changelog](https://github.com/openai/openai-python/blob/main/CHANGELOG.md)
- [Commits](openai/openai-python@v1.99.1...v1.102.0)

Updates `azure-monitor-opentelemetry` from 1.6.13 to 1.7.0
- [Release notes](https://github.com/Azure/azure-sdk-for-python/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/esrp_release.md)
- [Commits](Azure/azure-sdk-for-python@azure-monitor-opentelemetry_1.6.13...azure-monitor-opentelemetry_1.7.0)

---
updated-dependencies:
- dependency-name: azure-identity
  dependency-version: 1.24.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: openai
  dependency-version: 1.102.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: azure-monitor-opentelemetry
  dependency-version: 1.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
...

Signed-off-by: dependabot[bot] <[email protected]>

* build: bump the backend-deps group in /src/App with 13 updates

Bumps the backend-deps group in /src/App with 13 updates:

| Package | From | To |
| --- | --- | --- |
| [azure-identity](https://github.com/Azure/azure-sdk-for-python) | `1.24.0` | `1.25.0` |
| [openai](https://github.com/openai/openai-python) | `1.102.0` | `2.0.1` |
| [uvicorn](https://github.com/Kludex/uvicorn) | `0.35.0` | `0.37.0` |
| [black](https://github.com/psf/black) | `25.1.0` | `25.9.0` |
| [isort](https://github.com/PyCQA/isort) | `6.0.1` | `6.1.0` |
| [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) | `1.1.0` | `1.2.0` |
| [pytest-cov](https://github.com/pytest-dev/pytest-cov) | `6.2.1` | `7.0.0` |
| [azure-search-documents](https://github.com/Azure/azure-sdk-for-python) | `11.6.0b12` | `11.7.0b1` |
| [opentelemetry-sdk](https://github.com/open-telemetry/opentelemetry-python) | `1.36.0` | `1.37.0` |
| [opentelemetry-api](https://github.com/open-telemetry/opentelemetry-python) | `1.36.0` | `1.37.0` |
| [opentelemetry-semantic-conventions](https://github.com/open-telemetry/opentelemetry-python) | `0.57b0` | `0.58b0` |
| [opentelemetry-instrumentation](https://github.com/open-telemetry/opentelemetry-python-contrib) | `0.57b0` | `0.58b0` |
| [azure-monitor-opentelemetry](https://github.com/Azure/azure-sdk-for-python) | `1.7.0` | `1.8.1` |


Updates `azure-identity` from 1.24.0 to 1.25.0
- [Release notes](https://github.com/Azure/azure-sdk-for-python/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/esrp_release.md)
- [Commits](Azure/azure-sdk-for-python@azure-identity_1.24.0...azure-identity_1.25.0)

Updates `openai` from 1.102.0 to 2.0.1
- [Release notes](https://github.com/openai/openai-python/releases)
- [Changelog](https://github.com/openai/openai-python/blob/main/CHANGELOG.md)
- [Commits](openai/openai-python@v1.102.0...v2.0.1)

Updates `uvicorn` from 0.35.0 to 0.37.0
- [Release notes](https://github.com/Kludex/uvicorn/releases)
- [Changelog](https://github.com/Kludex/uvicorn/blob/main/docs/release-notes.md)
- [Commits](Kludex/uvicorn@0.35.0...0.37.0)

Updates `black` from 25.1.0 to 25.9.0
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@25.1.0...25.9.0)

Updates `isort` from 6.0.1 to 6.1.0
- [Release notes](https://github.com/PyCQA/isort/releases)
- [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md)
- [Commits](PyCQA/isort@6.0.1...6.1.0)

Updates `pytest-asyncio` from 1.1.0 to 1.2.0
- [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases)
- [Commits](pytest-dev/pytest-asyncio@v1.1.0...v1.2.0)

Updates `pytest-cov` from 6.2.1 to 7.0.0
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v6.2.1...v7.0.0)

Updates `azure-search-documents` from 11.6.0b12 to 11.7.0b1
- [Release notes](https://github.com/Azure/azure-sdk-for-python/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/search/azure-search-documents/CHANGELOG.md)
- [Commits](Azure/azure-sdk-for-python@azure-search-documents_11.6.0b12...azure-search-documents_11.7.0b1)

Updates `opentelemetry-sdk` from 1.36.0 to 1.37.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-python/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-python/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-python@v1.36.0...v1.37.0)

Updates `opentelemetry-api` from 1.36.0 to 1.37.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-python/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-python/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-python@v1.36.0...v1.37.0)

Updates `opentelemetry-semantic-conventions` from 0.57b0 to 0.58b0
- [Release notes](https://github.com/open-telemetry/opentelemetry-python/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-python/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-python/commits)

Updates `opentelemetry-instrumentation` from 0.57b0 to 0.58b0
- [Release notes](https://github.com/open-telemetry/opentelemetry-python-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-python-contrib/commits)

Updates `azure-monitor-opentelemetry` from 1.7.0 to 1.8.1
- [Release notes](https://github.com/Azure/azure-sdk-for-python/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/esrp_release.md)
- [Commits](Azure/azure-sdk-for-python@azure-monitor-opentelemetry_1.7.0...azure-monitor-opentelemetry_1.8.1)

---
updated-dependencies:
- dependency-name: azure-identity
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: openai
  dependency-version: 2.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: backend-deps
- dependency-name: uvicorn
  dependency-version: 0.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: black
  dependency-version: 25.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: isort
  dependency-version: 6.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: pytest-asyncio
  dependency-version: 1.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: pytest-cov
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: backend-deps
- dependency-name: azure-search-documents
  dependency-version: 11.7.0b1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: opentelemetry-sdk
  dependency-version: 1.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: opentelemetry-api
  dependency-version: 1.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: opentelemetry-semantic-conventions
  dependency-version: 0.58b0
  dependency-type: direct:production
  dependency-group: backend-deps
- dependency-name: opentelemetry-instrumentation
  dependency-version: 0.58b0
  dependency-type: direct:production
  dependency-group: backend-deps
- dependency-name: azure-monitor-opentelemetry
  dependency-version: 1.8.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
...

Signed-off-by: dependabot[bot] <[email protected]>

* build: bump msal

Bumps the backend-deps group in /infra/scripts/fabric_scripts with 1 update: [msal](https://github.com/AzureAD/microsoft-authentication-library-for-python).


Updates `msal` from 1.33.0 to 1.34.0
- [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-python/releases)
- [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/dev/RELEASES.md)
- [Commits](AzureAD/microsoft-authentication-library-for-python@1.33.0...1.34.0)

---
updated-dependencies:
- dependency-name: msal
  dependency-version: 1.34.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
...

Signed-off-by: dependabot[bot] <[email protected]>

* build: bump the backend-deps group

Bumps the backend-deps group in /infra/scripts/index_scripts with 2 updates: [msal[broker]](https://github.com/AzureAD/microsoft-authentication-library-for-python) and [azure-search-documents](https://github.com/Azure/azure-sdk-for-python).


Updates `msal[broker]` from 1.33.0 to 1.34.0
- [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-python/releases)
- [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/dev/RELEASES.md)
- [Commits](AzureAD/microsoft-authentication-library-for-python@1.33.0...1.34.0)

Updates `azure-search-documents` from 11.6.0b12 to 11.7.0b1
- [Release notes](https://github.com/Azure/azure-sdk-for-python/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/search/azure-search-documents/CHANGELOG.md)
- [Commits](Azure/azure-sdk-for-python@azure-search-documents_11.6.0b12...azure-search-documents_11.7.0b1)

---
updated-dependencies:
- dependency-name: msal[broker]
  dependency-version: 1.34.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
- dependency-name: azure-search-documents
  dependency-version: 11.7.0b1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: backend-deps
...

Signed-off-by: dependabot[bot] <[email protected]>

* updated requirement file and chat with data plugin file

* Fix body structure in create_or_update method

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]>
Co-authored-by: Prajwal-Microsoft <[email protected]>
Co-authored-by: Prekshith D J (Persistent Systems Inc) <[email protected]>
Co-authored-by: Vemarthula-Microsoft <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

🎉 This PR is included in version 1.9.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Roopan-Microsoft Roopan-Microsoft Roopan-Microsoft approved these changes

@Avijit-Microsoft Avijit-Microsoft Awaiting requested review from Avijit-Microsoft Avijit-Microsoft is a code owner

@Prajwal-Microsoft Prajwal-Microsoft Awaiting requested review from Prajwal-Microsoft Prajwal-Microsoft is a code owner

@Vinay-Microsoft Vinay-Microsoft Awaiting requested review from Vinay-Microsoft Vinay-Microsoft is a code owner

@aniaroramsft aniaroramsft Awaiting requested review from aniaroramsft aniaroramsft is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NirajC-Microsoft @Roopan-Microsoft