fix: Merging dev changes to main branch

[Roopan-Microsoft]

Purpose

• This pull request introduces significant improvements to Azure resource deployment and post-deployment guidance. The main changes include a refactor of the networking modules in infra/main.bicep to use a new virtualNetwork module, updates to resource references for private networking, and the addition of a post-deployment guide. Additionally, workflow and script enhancements improve telemetry and deployment instructions.

Infrastructure Refactor and Networking Improvements:

• Refactored networking in infra/main.bicep to use a new virtualNetwork module, added explicit modules for Bastion Host and Jumpbox VM, and updated all dependent resource references from network to virtualNetwork. This improves modularity and clarity of resource relationships. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
• Added DeploymentName tag and changed output from AZURE_CLIENT_ID to AZURE_SUBSCRIPTION_ID for improved resource tracking and output clarity. [1] [2]

Documentation and Usability:

• Added a new docs/AVMPostDeploymentGuide.md with clear post-deployment steps, including cloning the repo, importing sample data, configuring authentication, and cleaning up resources.

Workflow and Script Enhancements:

• Updated .github/workflows/azure-dev.yml to remove push trigger and add telemetry collection environment variable for improved CI/CD control and monitoring. [1] [2]
• Improved deployment instructions in azure.yaml hooks to include the resource group parameter in sample data processing commands, ensuring correct resource targeting. [1] [2]

Does this introduce a breaking change?

• Yes
• No

Golden Path Validation

• I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

• I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

• ...

Other Information

[Copilot]

Pull Request Overview

This pull request refactors the Azure networking infrastructure by consolidating the virtual network module from a nested structure (infra/modules/network/) into a single top-level module (infra/modules/virtualNetwork.bicep), and moving Bastion Host and Jumpbox VM resources directly into infra/main.bicep. The changes also improve the post-deployment experience by enhancing the sample data processing script to fetch deployment outputs dynamically and adding comprehensive post-deployment documentation.

Key Changes:

• Consolidated networking modules from infra/modules/network/ into a single infra/modules/virtualNetwork.bicep with default subnet configurations
• Moved Bastion Host and Jumpbox VM from nested modules to explicit declarations in infra/main.bicep using AVM modules
• Enhanced process_sample_data.sh to automatically retrieve deployment parameters from Azure deployment outputs instead of requiring manual input

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
infra/main.bicep	Refactored to use new virtualNetwork module and explicit AVM modules for Bastion Host and Jumpbox VM; updated all resource references from network to virtualNetwork; changed output from AZURE_CLIENT_ID to AZURE_SUBSCRIPTION_ID
infra/modules/virtualNetwork.bicep	New consolidated module with hardcoded subnet configurations (web, peps, bastion, jumpbox) replacing the previous nested structure
infra/modules/network.bicep	Removed - functionality moved to virtualNetwork.bicep and main.bicep
infra/modules/network/virtualNetwork.bicep	Removed - replaced by top-level virtualNetwork.bicep
infra/modules/network/network-resources.bicep	Removed - Bastion and Jumpbox now declared directly in main.bicep
infra/modules/network/bastionHost.bicep	Removed - Bastion Host now uses AVM module directly in main.bicep
infra/modules/network/jumpbox.bicep	Removed - Jumpbox VM now uses AVM module directly in main.bicep
infra/scripts/process_sample_data.sh	Enhanced to fetch deployment parameters from Azure deployment outputs; added authentication check and manual input fallback
infra/scripts/checkquota.sh	Added missing quota check flag for warning condition
docs/AVMPostDeploymentGuide.md	New post-deployment guide with instructions for cloning repo, importing sample data, configuring authentication, and cleanup
azure.yaml	Updated deployment instructions to include resource group parameter in sample data processing commands
.github/workflows/azure-dev.yml	Removed push trigger; added telemetry collection environment variable

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.