Skip to content

Conversation

@Kanchan-Microsoft
Copy link
Contributor

Purpose

This pull request updates the infrastructure templates to improve tag inheritance and corrects resource dependency orderings. The most significant change ensures that resource group tags are merged into deployed resources, allowing for better tag consistency and management. Additionally, the dependency arrays in the ARM template JSON have been reordered for accuracy and correctness.

Tag inheritance improvements:

  • Updated the resourceGroupTags resource in main.bicep to include tags from the parent resource group by spreading resourceGroup().tags into the tags object.
  • Modified the ARM template (main.json) to merge resource group tags with custom tags and template-specific tags using shallowMerge, ensuring all relevant tags are applied to resources.

Dependency order corrections:

  • Reordered the dependsOn array for certain resources in main.json to ensure dependencies are listed in the correct sequence, specifically for storage-related DNS zones.
  • Adjusted the order of dependencies for machine learning services and notebooks in the dependsOn array to reflect the proper deployment sequence.

Other:

  • Updated the template hash in main.json to reflect changes in the generated template.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Kanchan-Microsoft Kanchan-Microsoft changed the title fix: Prevent removal of existing RG tags fix: Prevent removal of existing RG tags when deploying GSA Oct 28, 2025
@Prajwal-Microsoft Prajwal-Microsoft merged commit a739636 into byoc-researcher Oct 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants