fix: Prevent removal of existing RG tags when deploying GSA #719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the infrastructure templates to improve tag inheritance and corrects resource dependency orderings. The most significant change ensures that resource group tags are merged into deployed resources, allowing for better tag consistency and management. Additionally, the dependency arrays in the ARM template JSON have been reordered for accuracy and correctness.
Tag inheritance improvements:
resourceGroupTagsresource inmain.bicepto include tags from the parent resource group by spreadingresourceGroup().tagsinto the tags object.main.json) to merge resource group tags with custom tags and template-specific tags usingshallowMerge, ensuring all relevant tags are applied to resources.Dependency order corrections:
dependsOnarray for certain resources inmain.jsonto ensure dependencies are listed in the correct sequence, specifically for storage-related DNS zones.dependsOnarray to reflect the proper deployment sequence.Other:
main.jsonto reflect changes in the generated template.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information