fix: Merging the changes from dev to main

[Kanchan-Microsoft]

Purpose

This pull request introduces significant improvements and refactoring to the Azure infrastructure deployment, focusing on modularizing networking resources, updating resource references, and enhancing documentation and workflow configuration. The most impactful changes include replacing the monolithic network module with granular modules for virtual network, Bastion host, and Jumpbox VM, updating all dependent resource references, and adding a comprehensive post-deployment guide.

Infrastructure Refactoring and Modularization:

• Replaced the single network module in infra/main.bicep with dedicated modules for virtualNetwork, bastionHost, and jumpboxVM, improving clarity and maintainability of private networking components. All dependent modules now reference outputs from virtualNetwork instead of the old network module.

• Updated resource group tagging to include inherited tags and deployment name, ensuring better traceability and compliance.

• Changed the output from exposing the client ID of the managed identity to exposing the Azure Subscription ID, likely for improved post-deployment automation or documentation.

Documentation Improvements:

• Added a new docs/AVMPostDeploymentGuide.md file providing step-by-step instructions for post-deployment actions, including cloning the repo, importing sample data, configuring authentication, and cleaning up resources.

Workflow and Script Updates:

• Modified the Azure DevOps workflow (.github/workflows/azure-dev.yml) to only trigger on manual dispatch, not on every push to main, and added support for telemetry collection via a new environment variable.

• Updated provisioning hooks in azure.yaml to pass the resource group name as an argument to the sample data processing script, improving automation and clarity for users.

Does this introduce a breaking change?

• Yes
• No

Golden Path Validation

• I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

• I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

• ...

Other Information

[Copilot]

Pull Request Overview

This pull request merges changes from the dev branch to main, focusing on dependency updates, infrastructure refactoring, and improved post-deployment workflows. The changes modularize the Azure networking infrastructure by replacing a monolithic network module with separate components for virtual networks, Bastion hosts, and Jumpbox VMs, while also updating Python dependencies across multiple requirements files.

Key changes include:

• Upgrading Python dependencies across application and script requirements files
• Refactoring infrastructure from a single network module to separate virtualNetwork, bastionHost, and jumpboxVM modules
• Updating the sample data processing script to fetch deployment parameters from Azure instead of command-line arguments

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/App/requirements.txt	Updates core application dependencies to newer versions
src/App/requirements-dev.txt	Updates development dependencies to match main requirements
src/App/backend/plugins/chat_with_data_plugin.py	Changes API parameter name from 'body' to 'index'
infra/scripts/process_sample_data.sh	Refactors to fetch deployment outputs from Azure instead of using command-line arguments
infra/scripts/index_scripts/requirements.txt	Updates msal and azure-search-documents versions
infra/scripts/fabric_scripts/requirements.txt	Updates msal package version
infra/scripts/checkquota.sh	Adds flag to track insufficient quota warnings
infra/modules/virtualNetwork.bicep	New modular virtual network module with embedded subnet configurations
infra/modules/network/virtualNetwork.bicep	Removed - replaced by top-level virtualNetwork module
infra/modules/network/network-resources.bicep	Removed - functionality split into separate modules
infra/modules/network/jumpbox.bicep	Removed - functionality moved to main.bicep
infra/modules/network/bastionHost.bicep	Removed - functionality moved to main.bicep
infra/modules/network.bicep	Removed - replaced by modular approach
infra/main.bicep	Replaces network module with separate virtualNetwork, bastionHost, and jumpboxVM modules
docs/AVMPostDeploymentGuide.md	New post-deployment guide with setup instructions
azure.yaml	Updates provisioning hooks to pass resource group name to sample data script
.github/workflows/azure-dev.yml	Changes workflow to manual dispatch only and adds telemetry configuration

Comments suppressed due to low confidence (1)

infra/modules/virtualNetwork.bicep:1

• The parameter name is incorrectly indented and appears to be starting on line 397, but the formatting suggests this line should be part of the params block starting at line 396. This will cause a Bicep syntax error.

/****************************************************************************************************************************/

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Inconsistent indentation compared to surrounding lines. The line should be aligned with the 'service' property on line 1235.

Suggested change

	subnetResourceId: virtualNetwork!.outputs.pepsSubnetResourceId
	subnetResourceId: virtualNetwork!.outputs.pepsSubnetResourceId