-
Notifications
You must be signed in to change notification settings - Fork 160
fix: merging dev changes to main #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* docs: update deployment guide to clarify VS Code Dev Containers and bash command usage * docs: update post-deployment instructions to simplify sample data import command
… deployment script (#726) * Refactor process_sample_data.sh to streamline required variable retrieval * prompt for Azure CLI authentication in process_sample_data.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the process_sample_data.sh script to support multiple deployment methods and improves the documentation accordingly. The script now intelligently detects whether values should be sourced from Azure Developer CLI (azd) environment, Azure deployment outputs, or manual user input.
Key changes:
- Added support for azd environment variable retrieval as the default method when no resource group is provided
- Restructured the script to check for deployment method and fall back gracefully with improved error handling
- Updated documentation to clarify usage for both azd-based deployments and custom ARM/Bicep deployments
- Simplified the command usage by removing the resource group parameter from azd deployments
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| infra/scripts/process_sample_data.sh | Refactored to support multiple value retrieval methods (azd env, deployment outputs, manual input) with improved flow control and error handling |
| docs/DeploymentGuide.md | Updated post-deployment instructions to distinguish between azd and custom deployment methods with clearer formatting |
| docs/AVMPostDeploymentGuide.md | Enhanced documentation structure with better formatting and clarified usage instructions for AVM deployments |
| azure.yaml | Simplified the command by removing the resource group parameter to leverage azd environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Purpose
azd-based and custom Azure deployments. The changes clarify instructions for post-deployment steps, improve the user experience for importing sample data, and enhance the robustness of the sample data script by modularizing environment variable retrieval and validation.Documentation improvements:
docs/AVMPostDeploymentGuide.mdanddocs/DeploymentGuide.mdto clearly distinguish betweenazdand custom/ARM deployments, providing step-by-step instructions for each scenario and emphasizing which command to use based on deployment type. Also improved formatting, added tips and notes, and clarified authentication and troubleshooting steps. [1] [2]Sample data script enhancements (
infra/scripts/process_sample_data.sh):azdenvironment, Azure deployment outputs, or prompt the user interactively if necessary. Improved validation and error handling for missing values. [1] [2]Azure deployment hooks:
azure.yamlto print the correct sample data import command for both PowerShell and Bash, removing the unnecessary resource group argument forazd-based deployments. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information