-
Notifications
You must be signed in to change notification settings - Fork 162
feat: Enhance Developer Experience Support in Client Advisor #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a developer-friendly deployment option by adding custom infrastructure templates and deployment workflows that enable local development with Azure Container Registry and enhanced user permissions for debugging.
- Adds
main_custom.bicepinfrastructure template with developer-optimized configurations including ACR integration and user role assignments - Introduces
azure_custom.yamlwith automated container build and deployment hooks for streamlined local development - Updates Key Vault naming convention from uppercase 'KV-' to lowercase 'kv-' for consistency across all templates
- Adds documentation for deploying local changes through file renaming workflow
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| infra/main_custom.bicep | New developer-focused Bicep template with ACR, user permissions for local debugging, and deployer role assignments for AI services, Key Vault, Cosmos DB, and Search |
| azure_custom.yaml | New Azure Developer CLI configuration with pre-deploy hooks for automated container building, pushing to ACR, and web app configuration |
| infra/main.bicep | Updates Key Vault resource naming from 'KV-' to 'kv-' for consistency with naming conventions |
| infra/main.json | Updates Key Vault variable naming from 'KV-' to 'kv-' to match the Bicep template change |
| docs/DeploymentGuide.md | Adds section documenting the file renaming workflow for deploying local changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Purpose
This pull request introduces a new deployment configuration for Azure, making it easier to build, package, and deploy the solution accelerator using custom hooks and scripts. The most significant changes are the addition of the
azure_custom.yamlfile, which automates container registry setup and deployment steps, and updated documentation to guide users on deploying local changes.Deployment automation and configuration:
azure_custom.yamlwith customazdhooks for pre-package, pre-deploy, post-provision, and post-deploy steps, automating container registry setup, image build/push, managed identity configuration, and web app updates for Windows environments.Documentation updates:
docs/DeploymentGuide.mdwith instructions for deploying local changes by renaming configuration and infrastructure files, ensuring users can easily switch between default and custom deployment flows.These changes streamline the deployment workflow, improve automation, and provide clear guidance for customizing and deploying local modifications.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information