Skip to content

Conversation

@Kanchan-Microsoft
Copy link
Contributor

Purpose

This pull request introduces a new deployment configuration for Azure, making it easier to build, package, and deploy the solution accelerator using custom hooks and scripts. The most significant changes are the addition of the azure_custom.yaml file, which automates container registry setup and deployment steps, and updated documentation to guide users on deploying local changes.

Deployment automation and configuration:

  • Added azure_custom.yaml with custom azd hooks for pre-package, pre-deploy, post-provision, and post-deploy steps, automating container registry setup, image build/push, managed identity configuration, and web app updates for Windows environments.
  • Defined infrastructure provisioning using Bicep in the new configuration, including parameterization for container registry and image settings.

Documentation updates:

  • Updated docs/DeploymentGuide.md with instructions for deploying local changes by renaming configuration and infrastructure files, ensuring users can easily switch between default and custom deployment flows.

These changes streamline the deployment workflow, improve automation, and provide clear guidance for customizing and deploying local modifications.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a developer-friendly deployment option by adding custom infrastructure templates and deployment workflows that enable local development with Azure Container Registry and enhanced user permissions for debugging.

  • Adds main_custom.bicep infrastructure template with developer-optimized configurations including ACR integration and user role assignments
  • Introduces azure_custom.yaml with automated container build and deployment hooks for streamlined local development
  • Updates Key Vault naming convention from uppercase 'KV-' to lowercase 'kv-' for consistency across all templates
  • Adds documentation for deploying local changes through file renaming workflow

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
infra/main_custom.bicep New developer-focused Bicep template with ACR, user permissions for local debugging, and deployer role assignments for AI services, Key Vault, Cosmos DB, and Search
azure_custom.yaml New Azure Developer CLI configuration with pre-deploy hooks for automated container building, pushing to ACR, and web app configuration
infra/main.bicep Updates Key Vault resource naming from 'KV-' to 'kv-' for consistency with naming conventions
infra/main.json Updates Key Vault variable naming from 'KV-' to 'kv-' to match the Bicep template change
docs/DeploymentGuide.md Adds section documenting the file renaming workflow for deploying local changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants