fix: Merging dev changes to main branch #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Merging from main branch
* Implementation of Configurable Logging Control via Flag * bicep updated * updated bicep * updated custom bicep
AjitPadhi-Microsoft
requested review from
Avijit-Microsoft and
Roopan-Microsoft
as code owners
AjitPadhi-Microsoft
requested review from
Prajwal-Microsoft,
Vinay-Microsoft,
aniaroramsft,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances logging configuration flexibility and ensures infrastructure deployment compatibility by downgrading Azure Resource Manager API versions. The changes introduce configurable logging levels for basic application logging and Azure SDK packages, while reverting from an potentially unsupported "2025-04-01" API version to the stable "2022-09-01" version for Microsoft.Resources/deployments across the infrastructure templates.
Key Changes:
- Added three new environment variables (
AZURE_BASIC_LOGGING_LEVEL,AZURE_PACKAGE_LOGGING_LEVEL,AZURE_LOGGING_PACKAGES) to make logging configuration dynamic and flexible - Downgraded Microsoft.Resources/deployments API version from "2025-04-01" to "2022-09-01" throughout infrastructure templates
- Reverted Bicep template generator from version 0.39.26.7824 to 0.37.4.10188
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/App/backend/common/config.py |
Added configuration properties for AZURE_BASIC_LOGGING_LEVEL and AZURE_PACKAGE_LOGGING_LEVEL with sensible defaults |
src/App/app.py |
Replaced hardcoded logging configuration with dynamic configuration using new environment variables; supports comma-separated list of Azure packages to configure |
src/App/.env.sample |
Added documentation for new logging environment variables with example values |
infra/main.bicep |
Added logging environment variables to web site deployment configuration |
infra/main_custom.bicep |
Added logging environment variables to web site deployment configuration |
infra/main.json |
Downgraded all Microsoft.Resources/deployments API versions from "2025-04-01" to "2022-09-01"; updated Bicep generator version metadata; added logging environment variables to web site deployment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fixed blank string issue Co-authored-by: Copilot <[email protected]>
Roopan-Microsoft
approved these changes
Dec 1, 2025
Roopan-Microsoft
approved these changes
Dec 1, 2025
|
🎉 This PR is included in version 1.10.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Logging configuration improvements:
AZURE_BASIC_LOGGING_LEVEL,AZURE_PACKAGE_LOGGING_LEVEL, andAZURE_LOGGING_PACKAGES) to the web site deployment inmain.bicep.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information