Fix uv_loop_close sequence to wait for in-flight synchronous calls that hold uv resources #7070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjen1-msft
force-pushed
the
fix-fsync-race
branch
2 times, most recently
from
995c68c to
83c92d9
Compare
cjen1-msft
force-pushed
the
fix-fsync-race
branch
from
02cdea5 to
4c217f1
Compare
cjen1-msft
force-pushed
the
fix-fsync-race
branch
from
4c217f1 to
2e5b6ac
Compare
eddyashton
reviewed
Aug 13, 2025
eddyashton
reviewed
Aug 13, 2025
eddyashton
reviewed
Aug 13, 2025
achamayou
approved these changes
Aug 13, 2025
Co-authored-by: Eddy Ashton <[email protected]>
Co-authored-by: Eddy Ashton <[email protected]>
achamayou
changed the title
achamayou
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a race condition, where a delayed fsync running in a worker thread tries to access resources which have already been freed by the main thread on shutdown.
Currently this PR is just trying to reproduce it in our test infrastructure.