Compatibility with TypeScript 5.9 #7171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
approved these changes
Aug 11, 2025
|
We should backport this to |
maxtropets
approved these changes
Aug 12, 2025
achamayou
approved these changes
Aug 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
achamayou
added
auto-backport
achamayou
changed the title
achamayou
pushed a commit
to achamayou/CCF
that referenced
this pull request
Aug 14, 2025
Co-authored-by: Max <[email protected]> Co-authored-by: Amaury Chamayou <[email protected]> (cherry picked from commit f9a7e51) # Conflicts: # CHANGELOG.md # js/ccf-app/package.json # tests/js-interpreter-reuse/package.json # tests/npm-app/package.json
achamayou
added a commit
that referenced
this pull request
Aug 14, 2025
…7185) Co-authored-by: cjen1-msft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript 5.9 made
ArrayBufferLike = ArrayBuffer | SharedArrayBuffer, which causes typescript to output many errors as our code has previously assumed that the input is always an ArrayBuffer.This PR removes the pins, and by adding
toArrayBuffer(b : ArrayBufferLike | Uint8Array | Buffer) : ArrayBufferandtoUint8ArrayBuffer(b : Uint8Array<ArrayBufferLike>) : Uint8Array<ArrayBuffer>to autils.tsmodule in ccf-app, fixes the corresponding errors with typescript 5.9.These in theory could live in maybe
converters.ts, however that would add an import onconverters.tsto bothpolyfill.tsandcrypto.tswhich seems inadvisable, instead of a direct import of justutils.ts.