Skip to content

Conversation

@achamayou
Copy link
Member

Replaces #7530

@achamayou achamayou requested a review from a team as a code owner January 2, 2026 11:27
Copilot AI review requested due to automatic review settings January 2, 2026 11:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Node.js type definitions from version 24.2.0 to 25.0.2 and adapts the codebase to accommodate breaking changes in the crypto module's type definitions.

  • Updates @types/node dependency to version 25.0.2
  • Replaces references to jscrypto.JsonWebKey with the custom JsonWebKey type defined in the project
  • Adds type casts to handle type incompatibilities introduced by the Node.js types update

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File Description
js/ccf-app/package.json Updates @types/node from v24.2.0 to v25.0.2
js/ccf-app/src/polyfill.ts Imports JsonWebKey type, replaces jscrypto.JsonWebKey references with custom JsonWebKey type, and adds as any casts to key.export() calls to work around type changes

@achamayou achamayou merged commit 1dfd70a into main Jan 2, 2026
17 checks passed
@achamayou achamayou deleted the update_node_types branch January 2, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants