Skip to content

Handle incomplete network identity fetching consistently #7703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxtropets merged 6 commits into from
Mar 5, 2026
+8 −5
Merged

Handle incomplete network identity fetching consistently #7703

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bdedcb7
Initial plan
Copilot Mar 4, 2026
12d5b75
Throw std::logic_error from get_cose_endorsements_chain when fetching…
Copilot Mar 4, 2026
1ea4d05
Remove 'i.e.' from get_cose_endorsements_chain docstring
Copilot Mar 4, 2026
6d75c61
Simplify @throws docstring: remove condition comparison
Copilot Mar 5, 2026
cc1418b
Merge branch 'main' into copilot/update-get-cose-endorsements-chain
achamayou Mar 5, 2026
01542b1
Merge branch 'main' into copilot/update-get-cose-endorsements-chain
achamayou Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions include/ccf/network_identity_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,11 @@ namespace ccf
[[nodiscard]] virtual FetchStatus endorsements_fetching_status() const = 0;

/// Returns the COSE endorsements chain for the given sequence number,
/// or std::nullopt if endorsement fetching has not completed or the
/// chain is not available for the given sequence number.
/// or std::nullopt if the chain is not available for the given sequence
/// number.
///
/// @throws std::logic_error if endorsement fetching has not completed
/// (i.e. endorsements_fetching_status() != FetchStatus::Done).
[[nodiscard]] virtual std::optional<CoseEndorsementsChain>
get_cose_endorsements_chain(ccf::SeqNo seqno) const = 0;

Expand Down
7 changes: 4 additions & 3 deletions src/node/rpc/network_identity_subsystem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,12 @@ namespace ccf
[[nodiscard]] std::optional<CoseEndorsementsChain>
get_cose_endorsements_chain(ccf::SeqNo seqno) const override
{
// All other cases must be handled after recovery has been completed and
// identities have been successfully fetched.
if (fetch_status.load() != FetchStatus::Done)
{
return std::nullopt;
throw std::logic_error(fmt::format(
"COSE endorsements chain requested for seqno {} but endorsement "
"fetching has not been completed yet",
seqno));
}

if (!current_service_from.has_value())
Expand Down