Increase maxargs #557
Open
Increase maxargs #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willxie-eng
approved these changes
Jun 1, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
willxie-eng
suggested changes
Jun 1, 2023
There was a problem hiding this comment.
We need to update HostExtensionsBase to also support System.Core. See: https://github.com/microsoft/CLRInstrumentationEngine/blob/main/src/Extensions.BaseLib/HostExtensionBase.cpp#L176
|
Hmm, maybe this isn't going to work after all. I'll take a look, but I'm starting to think that I might just need to support only loading the first N args in the intercept engine instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase the max number of args for the Interception Engine callbacks to support functions with more than 6 arguments.
This increases maxargs as much as is possible for Framework 4.6.
Change Log
Test Methodology
Local build. This change should not affect existing callers because they will not have been updated to call them. Existing functions did not change.