Skip to content

fix: Code QL issue fixes for usage of DefaultAzureCredential #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prajwal-Microsoft merged 1 commit into from
Oct 14, 2025
Merged

fix: Code QL issue fixes for usage of DefaultAzureCredential #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...c/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/Services/Queue/AzureStorageQueueService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public static Uri GetQueueUriFromConnectionString(string connectionString, strin

public AzureStorageQueueService(Uri storageQueueUri, ILogger<AzureStorageQueueService> log)
{
this._clientBuilder = queueName => new QueueClient(storageQueueUri, new DefaultAzureCredential());
this._clientBuilder = queueName => new QueueClient(storageQueueUri, new ManagedIdentityCredential());
this._log = log;
}

Expand Down
2 changes: 1 addition & 1 deletion Services/src/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/Utils/StorageAccessUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ static public BlobServiceClient GetBlobClientFromConnectionString(string Connect
var DefaultEndpointSuffix = "core.windows.net";
var storageAccountName = ConnectionString.Split(';').FirstOrDefault(x => x.Contains("AccountName")).Split('=')[1];
var storageAccountUri = new Uri($"https://{storageAccountName}.blob.{DefaultEndpointSuffix}");
return new BlobServiceClient(storageAccountUri, new DefaultAzureCredential());
return new BlobServiceClient(storageAccountUri, new ManagedIdentityCredential());
}

static public Stream GetReportResultBlob(string FileName, string ConnectionString)
Expand Down
2 changes: 1 addition & 1 deletion Services/src/kernel-memory/extensions/AzureAIDocIntel/AzureAIDocIntelEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public AzureAIDocIntelEngine(
switch (config.Auth)
{
case AzureAIDocIntelConfig.AuthTypes.AzureIdentity:
this._recognizerClient = new DocumentAnalysisClient(new Uri(config.Endpoint), new DefaultAzureCredential());
this._recognizerClient = new DocumentAnalysisClient(new Uri(config.Endpoint), new ManagedIdentityCredential());
break;

case AzureAIDocIntelConfig.AuthTypes.APIKey:
Expand Down
2 changes: 1 addition & 1 deletion Services/src/kernel-memory/extensions/AzureAISearch/AzureAISearch/AzureAISearchMemory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public AzureAISearchMemory(
case AzureAISearchConfig.AuthTypes.AzureIdentity:
this._adminClient = new SearchIndexClient(
new Uri(config.Endpoint),
new DefaultAzureCredential(),
new ManagedIdentityCredential(),
GetClientOptions());
break;

Expand Down
2 changes: 1 addition & 1 deletion Services/src/kernel-memory/extensions/AzureBlobs/AzureBlobsStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public AzureBlobsStorage(
{
this.ValidateAccountName(config.Account);
var suffix = this.ValidateEndpointSuffix(config.EndpointSuffix);
client = new BlobServiceClient(new Uri($"https://{config.Account}.blob.{suffix}"), new DefaultAzureCredential());
client = new BlobServiceClient(new Uri($"https://{config.Account}.blob.{suffix}"), new ManagedIdentityCredential());
break;
}

Expand Down
2 changes: 1 addition & 1 deletion Services/src/kernel-memory/extensions/AzureOpenAI/AzureOpenAITextEmbeddingGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public AzureOpenAITextEmbeddingGenerator(
deploymentName: config.Deployment,
modelId: config.Deployment,
endpoint: config.Endpoint,
credential: new DefaultAzureCredential(),
credential: new ManagedIdentityCredential(),
httpClient: httpClient);
break;

Expand Down
2 changes: 1 addition & 1 deletion Services/src/kernel-memory/extensions/AzureOpenAI/AzureOpenAITextGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public AzureOpenAITextGenerator(
switch (config.Auth)
{
case AzureOpenAIConfig.AuthTypes.AzureIdentity:
this._client = new OpenAIClient(new Uri(config.Endpoint), new DefaultAzureCredential(), options);
this._client = new OpenAIClient(new Uri(config.Endpoint), new ManagedIdentityCredential(), options);
break;

case AzureOpenAIConfig.AuthTypes.ManualTokenCredential:
Expand Down
2 changes: 1 addition & 1 deletion Services/src/kernel-memory/extensions/AzureQueues/AzureQueuesPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public AzureQueuesPipeline(
{
this.ValidateAccountName(config.Account);
var suffix = this.ValidateEndpointSuffix(config.EndpointSuffix);
this._clientBuilder = queueName => new QueueClient(new($"https://{config.Account}.queue.{suffix}/{queueName}"), new DefaultAzureCredential());
this._clientBuilder = queueName => new QueueClient(new($"https://{config.Account}.queue.{suffix}/{queueName}"), new ManagedIdentityCredential());
break;
}

Expand Down